fix(mcp): use writable cache dir for MCP user data, not browsers path#40961
Open
adityasingh2400 wants to merge 1 commit into
Open
fix(mcp): use writable cache dir for MCP user data, not browsers path#40961adityasingh2400 wants to merge 1 commit into
adityasingh2400 wants to merge 1 commit into
Conversation
createUserDataDir() built the MCP profile path from registryDirectory, which is rooted at PLAYWRIGHT_BROWSERS_PATH when that env var is set. That path is often read-only (NixOS Nix store, immutable Docker mounts, shared browser-binary caches), so MCP fails to launch with EACCES while trying to mkdir the profile directory. Use defaultCacheDirectory (XDG_CACHE_HOME on Linux, Library/Caches on macOS, LOCALAPPDATA on Windows) and namespace the profiles under ms-playwright-mcp. The PWMCP_PROFILES_DIR_FOR_TEST override is unchanged. Fixes: microsoft#40892
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createUserDataDir()resolved the MCP profile path underregistryDirectory, which equalsPLAYWRIGHT_BROWSERS_PATHwhen that env var is set. On NixOS, immutable Docker mounts, and other shared/read-only browser-binary caches, the profile mkdir then fails withEACCES.defaultCacheDirectory(XDG_CACHE_HOME / Library/Caches / LOCALAPPDATA) under anms-playwright-mcpsubdirectory.PWMCP_PROFILES_DIR_FOR_TESTis unchanged so tests keep using their own temp dirs.Fixes #40892