Skip to content

Use emoji in ConsoleActivityLogger summary and localize strings#16084

Merged
JamesNK merged 3 commits intomainfrom
cli/activity-logger-emoji-and-localization
Apr 12, 2026
Merged

Use emoji in ConsoleActivityLogger summary and localize strings#16084
JamesNK merged 3 commits intomainfrom
cli/activity-logger-emoji-and-localization

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Apr 12, 2026

Description

Use emoji in ConsoleActivityLogger summary output and localize hardcoded strings.

Changes:

  • Replace text symbols (✓, ✗, △) with emoji via ConsoleHelpers.FormatEmojiPrefix and KnownEmojis in the summary counts line and pipeline result header (color-enabled path only). Timeline/step output retains the original text symbols.
  • Add CheckMarkButton to KnownEmojis.
  • Extract all hardcoded user-facing strings from ConsoleActivityLogger into a new ConsoleActivityLoggerStrings resource file for localization.
  • Generate xlf translation files for all 13 supported languages.

Validation: All 1985 CLI tests pass (5 skipped, 0 failures).


My thoughts behind this change:

Emoji look better than text. But an emoji per step would be overwhelming. Keep text on steps and display emoji in summaries.

Before:
image

After:
image

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
    • No

- Replace text symbols with emoji (via FormatEmojiPrefix/KnownEmojis) in
  summary line and pipeline result header when color is enabled
- Add CheckMarkButton to KnownEmojis
- Extract hardcoded user-facing strings to new ConsoleActivityLoggerStrings
  resource file for localization
- Generate xlf translation files for all 13 languages
Copilot AI review requested due to automatic review settings April 12, 2026 06:01
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 12, 2026

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16084

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16084"

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Aspire CLI’s ConsoleActivityLogger to (1) move user-facing strings into localizable resources and (2) switch certain summary/header prefixes from text symbols to emoji (in the color-enabled output path) for more consistent rendering.

Changes:

  • Localize hardcoded ConsoleActivityLogger strings into a new ConsoleActivityLoggerStrings resource.
  • Use ConsoleHelpers.FormatEmojiPrefix + KnownEmojis for emoji prefixes in the summary counts line and pipeline result header (color-enabled path).
  • Add new XLF translation files for supported languages and add CheckMarkButton to KnownEmojis.

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/Aspire.Cli/Utils/ConsoleActivityLogger.cs Switches summary/header prefixes to emoji (color path) and replaces hardcoded strings with localized resources.
src/Aspire.Cli/Interaction/KnownEmojis.cs Adds CheckMarkButton emoji identifier.
src/Aspire.Cli/Resources/ConsoleActivityLoggerStrings.resx Adds new resource entries for ConsoleActivityLogger UI strings.
src/Aspire.Cli/Resources/ConsoleActivityLoggerStrings.Designer.cs Auto-generated strongly-typed accessor for the new resx resources.
src/Aspire.Cli/Resources/xlf/ConsoleActivityLoggerStrings.cs.xlf Adds Czech localization scaffold for the new resources.
src/Aspire.Cli/Resources/xlf/ConsoleActivityLoggerStrings.de.xlf Adds German localization scaffold for the new resources.
src/Aspire.Cli/Resources/xlf/ConsoleActivityLoggerStrings.es.xlf Adds Spanish localization scaffold for the new resources.
src/Aspire.Cli/Resources/xlf/ConsoleActivityLoggerStrings.fr.xlf Adds French localization scaffold for the new resources.
src/Aspire.Cli/Resources/xlf/ConsoleActivityLoggerStrings.it.xlf Adds Italian localization scaffold for the new resources.
src/Aspire.Cli/Resources/xlf/ConsoleActivityLoggerStrings.ja.xlf Adds Japanese localization scaffold for the new resources.
src/Aspire.Cli/Resources/xlf/ConsoleActivityLoggerStrings.ko.xlf Adds Korean localization scaffold for the new resources.
src/Aspire.Cli/Resources/xlf/ConsoleActivityLoggerStrings.pl.xlf Adds Polish localization scaffold for the new resources.
src/Aspire.Cli/Resources/xlf/ConsoleActivityLoggerStrings.pt-BR.xlf Adds Portuguese (Brazil) localization scaffold for the new resources.
src/Aspire.Cli/Resources/xlf/ConsoleActivityLoggerStrings.ru.xlf Adds Russian localization scaffold for the new resources.
src/Aspire.Cli/Resources/xlf/ConsoleActivityLoggerStrings.tr.xlf Adds Turkish localization scaffold for the new resources.
src/Aspire.Cli/Resources/xlf/ConsoleActivityLoggerStrings.zh-Hans.xlf Adds Simplified Chinese localization scaffold for the new resources.
src/Aspire.Cli/Resources/xlf/ConsoleActivityLoggerStrings.zh-Hant.xlf Adds Traditional Chinese localization scaffold for the new resources.
Files not reviewed (1)
  • src/Aspire.Cli/Resources/ConsoleActivityLoggerStrings.Designer.cs: Language not supported

…ckMarkButton

- Move FormatEmojiPrefix calls inside Spectre color markup so text-rendered
  emoji inherit the color
- Replace CheckBoxWithCheck with CheckMarkButton in InitCommand
- Remove unused CheckBoxWithCheck from KnownEmojis
@github-actions
Copy link
Copy Markdown
Contributor

Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
GitHub was asked to rerun all failed jobs for that attempt, and the rerun is being tracked in the rerun attempt.
The job links below point to the failed attempt jobs that matched the retry-safe transient failure rules.

@davidfowl
Copy link
Copy Markdown
Contributor

/deployment-test

@github-actions
Copy link
Copy Markdown
Contributor

🚀 Deployment tests starting on PR #16084...

This will deploy to real Azure infrastructure. Results will be posted here when complete.

View workflow run

@github-actions github-actions bot had a problem deploying to deployment-testing April 12, 2026 07:39 Failure
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions github-actions bot had a problem deploying to deployment-testing April 12, 2026 07:39 Failure
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions github-actions bot had a problem deploying to deployment-testing April 12, 2026 07:39 Failure
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions github-actions bot had a problem deploying to deployment-testing April 12, 2026 07:39 Failure
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions github-actions bot had a problem deploying to deployment-testing April 12, 2026 07:39 Failure
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions github-actions bot had a problem deploying to deployment-testing April 12, 2026 07:39 Failure
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions github-actions bot had a problem deploying to deployment-testing April 12, 2026 07:39 Failure
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions github-actions bot temporarily deployed to deployment-testing April 12, 2026 07:39 Inactive
@github-actions
Copy link
Copy Markdown
Contributor

Deployment E2E Tests failed — 23 passed, 7 failed, 0 cancelled

View test results and recordings

View workflow run

Test Result Recording
Deployment.EndToEnd-VnetSqlServerInfraDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-VnetKeyVaultInfraDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-VnetSqlServerConnectivityDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AcaCompactNamingDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-VnetKeyVaultConnectivityDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AzureAppConfigDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AzureKeyVaultDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-NspStorageKeyVaultDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AzureStorageDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AzureLogAnalyticsDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AppServiceReactDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AzureServiceBusDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AzureEventHubsDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AuthenticationTests ✅ Passed
Deployment.EndToEnd-AzureContainerRegistryDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AcaStarterDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AcaCustomRegistryDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AcaDeploymentErrorOutputTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-VnetStorageBlobInfraDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AcaExistingRegistryDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-VnetStorageBlobConnectivityDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AksStarterWithRedisDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-AksStarterDeploymentTests ✅ Passed ▶️ View Recording
Deployment.EndToEnd-TypeScriptVnetSqlServerInfraDeploymentTests ❌ Failed ▶️ View Recording
Deployment.EndToEnd-TypeScriptExpressDeploymentTests ❌ Failed ▶️ View Recording
Deployment.EndToEnd-PythonFastApiDeploymentTests ❌ Failed ▶️ View Recording
Deployment.EndToEnd-AcrPurgeTaskDeploymentTests ❌ Failed ▶️ View Recording
Deployment.EndToEnd-AcaManagedRedisDeploymentTests ❌ Failed ▶️ View Recording
Deployment.EndToEnd-AcaCompactNamingUpgradeDeploymentTests ❌ Failed ▶️ View Recording
Deployment.EndToEnd-AppServicePythonDeploymentTests ❌ Failed ▶️ View Recording

@github-actions
Copy link
Copy Markdown
Contributor

Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
GitHub was asked to rerun all failed jobs for that attempt, and the rerun is being tracked in the rerun attempt.
The job links below point to the failed attempt jobs that matched the retry-safe transient failure rules.

@github-actions
Copy link
Copy Markdown
Contributor

🎬 CLI E2E Test Recordings — 68 recordings uploaded (commit 1e3bed8)

View recordings
Test Recording
AddPackageInteractiveWhileAppHostRunningDetached ▶️ View Recording
AddPackageWhileAppHostRunningDetached ▶️ View Recording
AgentCommands_AllHelpOutputs_AreCorrect ▶️ View Recording
AgentInitCommand_DefaultSelection_InstallsSkillOnly ▶️ View Recording
AgentInitCommand_MigratesDeprecatedConfig ▶️ View Recording
AllPublishMethodsBuildDockerImages ▶️ View Recording
AspireAddPackageVersionToDirectoryPackagesProps ▶️ View Recording
AspireUpdateRemovesAppHostPackageVersionFromDirectoryPackagesProps ▶️ View Recording
Banner_DisplayedOnFirstRun ▶️ View Recording
Banner_DisplayedWithExplicitFlag ▶️ View Recording
Banner_NotDisplayedWithNoLogoFlag ▶️ View Recording
CertificatesClean_RemovesCertificates ▶️ View Recording
CertificatesTrust_WithNoCert_CreatesAndTrustsCertificate ▶️ View Recording
CertificatesTrust_WithUntrustedCert_TrustsCertificate ▶️ View Recording
ConfigSetGet_CreatesNestedJsonFormat ▶️ View Recording
CreateAndRunAspireStarterProject ▶️ View Recording
CreateAndRunAspireStarterProjectWithBundle ▶️ View Recording
CreateAndRunEmptyAppHostProject ▶️ View Recording
CreateAndRunJavaEmptyAppHostProject ▶️ View Recording
CreateAndRunJsReactProject ▶️ View Recording
CreateAndRunPythonReactProject ▶️ View Recording
CreateAndRunTypeScriptEmptyAppHostProject ▶️ View Recording
CreateAndRunTypeScriptStarterProject ▶️ View Recording
CreateJavaAppHostWithViteApp ▶️ View Recording
CreateStartAndStopAspireProject ▶️ View Recording
CreateTypeScriptAppHostWithViteApp ▶️ View Recording
DashboardRunWithOtelTracesReturnsNoTraces ▶️ View Recording
DeployK8sBasicApiService ▶️ View Recording
DeployK8sWithGarnet ▶️ View Recording
DeployK8sWithMongoDB ▶️ View Recording
DeployK8sWithMySql ▶️ View Recording
DeployK8sWithPostgres ▶️ View Recording
DeployK8sWithRabbitMQ ▶️ View Recording
DeployK8sWithRedis ▶️ View Recording
DeployK8sWithSqlServer ▶️ View Recording
DeployK8sWithValkey ▶️ View Recording
DeployTypeScriptAppToKubernetes ▶️ View Recording
DescribeCommandResolvesReplicaNames ▶️ View Recording
DescribeCommandShowsRunningResources ▶️ View Recording
DetachFormatJsonProducesValidJson ▶️ View Recording
DoctorCommand_DetectsDeprecatedAgentConfig ▶️ View Recording
DoctorCommand_WithSslCertDir_ShowsTrusted ▶️ View Recording
DoctorCommand_WithoutSslCertDir_ShowsPartiallyTrusted ▶️ View Recording
GlobalMigration_HandlesCommentsAndTrailingCommas ▶️ View Recording
GlobalMigration_HandlesMalformedLegacyJson ▶️ View Recording
GlobalMigration_PreservesAllValueTypes ▶️ View Recording
GlobalMigration_SkipsWhenNewConfigExists ▶️ View Recording
GlobalSettings_MigratedFromLegacyFormat ▶️ View Recording
InitTypeScriptAppHost_AugmentsExistingViteRepoAtRoot ▶️ View Recording
InvalidAppHostPathWithComments_IsHealedOnRun ▶️ View Recording
LegacySettingsMigration_AdjustsRelativeAppHostPath ▶️ View Recording
LogsCommandShowsResourceLogs ▶️ View Recording
PsCommandListsRunningAppHost ▶️ View Recording
PsFormatJsonOutputsOnlyJsonToStdout ▶️ View Recording
PublishWithDockerComposeServiceCallbackSucceeds ▶️ View Recording
RestoreGeneratesSdkFiles ▶️ View Recording
RestoreSupportsConfigOnlyHelperPackageAndCrossPackageTypes ▶️ View Recording
RunFromParentDirectory_UsesExistingConfigNearAppHost ▶️ View Recording
SecretCrudOnDotNetAppHost ▶️ View Recording
SecretCrudOnTypeScriptAppHost ▶️ View Recording
StagingChannel_ConfigureAndVerifySettings_ThenSwitchChannels ▶️ View Recording
StartAndWaitForTypeScriptSqlServerAppHostWithNativeAssets ▶️ View Recording
StopAllAppHostsFromAppHostDirectory ▶️ View Recording
StopAllAppHostsFromUnrelatedDirectory ▶️ View Recording
StopNonInteractiveMultipleAppHostsShowsError ▶️ View Recording
StopNonInteractiveSingleAppHost ▶️ View Recording
StopWithNoRunningAppHostExitsSuccessfully ▶️ View Recording
UnAwaitedChainsCompileWithAutoResolvePromises ▶️ View Recording

📹 Recordings uploaded automatically from CI run #24300630687

@JamesNK JamesNK merged commit cf4e539 into main Apr 12, 2026
853 of 866 checks passed
@davidfowl
Copy link
Copy Markdown
Contributor

I like the all caps 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants