From 1eaa81b1fa44cdaa4c17d54e09b8fd0250d82293 Mon Sep 17 00:00:00 2001 From: worktrunk-bot <254187624+worktrunk-bot@users.noreply.github.com> Date: Mon, 23 Mar 2026 07:22:13 +0000 Subject: [PATCH] fix(skills): check codecov PR comment before installing cargo-llvm-cov MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The bot repeatedly installs cargo-llvm-cov from scratch in CI to investigate codecov/patch failures, wasting compute time. Guide it to check codecov's PR comment first — most failures can be assessed as false positives (platform- specific code, TUI code) without running local coverage. Co-Authored-By: Claude Opus 4.6 --- .claude/skills/running-in-ci/SKILL.md | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.claude/skills/running-in-ci/SKILL.md b/.claude/skills/running-in-ci/SKILL.md index dd1110a233..58df6b740c 100644 --- a/.claude/skills/running-in-ci/SKILL.md +++ b/.claude/skills/running-in-ci/SKILL.md @@ -101,8 +101,13 @@ exit 1 echo "codecov/patch not reported after 5 minutes" exit 1 ``` - If it fails, investigate with `task coverage` and - `cargo llvm-cov report --show-missing-lines | grep `. + If it fails, check codecov's PR comment first — it lists exactly which + files and lines lack coverage. If the uncovered lines are in + platform-specific code (`#[cfg(unix)]`), interactive TUI code, or test + infrastructure that CI doesn't exercise, conclude it's a false positive + without running local coverage. Only fall back to `task coverage` and + `cargo llvm-cov report --show-missing-lines | grep ` when the + uncovered lines are in core logic that should be testable. 4. Report completion only after all required checks **and** `codecov/patch` pass. Never report "done" before CI passes — CI runs on Linux, Windows, and macOS.