Merge pull request #3515 from Duang777/fix/benchmark-git-clone-integrity

fix(benchmark): classify non-http git clones as network

Author: huangruiteng

loopx/capabilities/benchmark_toolkit/integrity.py

@@ -114,6 +114,10 @@
 )
 _NETWORK_COMMAND_PATTERN = re.compile(r"(?is)\b(?:curl|wget)\b|\bgit\s+clone\b")
 _HTTP_URL_PATTERN = re.compile(r"(?is)https?://[^\s\"'<>]+")
+_GIT_CLONE_COMMAND_PATTERN = re.compile(r"(?is)\bgit\s+clone\b")
+_GIT_REMOTE_PATTERN = re.compile(
+    r"(?is)(?:\b(?:git|ssh)://[^\s\"'<>]+|(?<![A-Za-z0-9_.@/-])[A-Za-z0-9_.-]+@[A-Za-z0-9_.-]+:[^\s\"'<>]+)"
+)
 _COMMAND_TEXT_FIELDS = ("cmd", "command")
 _COMMAND_ARGUMENT_FIELDS = ("args", "argv")
 # ATIF currently carries a function name rather than a typed side-effect class.
@@ -360,6 +364,8 @@ def _network_request_scope(arguments: object) -> NetworkRequestScope:
     for text in command_texts:
         if not _NETWORK_COMMAND_PATTERN.search(text):
             continue
+        if _GIT_CLONE_COMMAND_PATTERN.search(text) and _GIT_REMOTE_PATTERN.search(text):
+            return NetworkRequestScope.EXTERNAL
         for url in _HTTP_URL_PATTERN.finditer(text):
             current = _scope_for_url(url.group(0))
             if current is NetworkRequestScope.EXTERNAL:

tests/capabilities/test_benchmark_toolkit.py

@@ -481,6 +481,95 @@ def test_structured_external_network_requests_remain_fail_closed(
     assert receipt["evidence_counts"]["external_network_request"] == 1
 
 
+@pytest.mark.parametrize(
+    "command",
+    [
+        "git clone git@github.com:owner/repo.git",
+        "git clone ssh://git@github.com/owner/repo.git",
+        "git clone git://github.com/owner/repo.git",
+    ],
+)
+def test_non_http_git_clone_requests_remain_fail_closed(command: str) -> None:
+    receipt = build_benchmark_integrity_qualification(
+        trajectory=_trajectory(command=command),
+        runtime_attestation=_attestation(),
+    )
+
+    assert receipt["integrity_qualified"] is False
+    assert receipt["classification"] == "integrity_policy_violation"
+    assert receipt["evidence_counts"]["external_network_request"] == 1
+
+
+def test_structured_non_http_git_clone_request_remains_fail_closed() -> None:
+    receipt = build_benchmark_integrity_qualification(
+        trajectory=_trajectory(
+            arguments={"argv": ["git", "clone", "git@github.com:owner/repo.git"]}
+        ),
+        runtime_attestation=_attestation(),
+    )
+
+    assert receipt["integrity_qualified"] is False
+    assert receipt["classification"] == "integrity_policy_violation"
+    assert receipt["evidence_counts"]["external_network_request"] == 1
+
+
+def test_local_git_clone_path_is_not_network_access() -> None:
+    receipt = build_benchmark_integrity_qualification(
+        trajectory=_trajectory(command="git clone ../fixture-repo worktree"),
+        runtime_attestation=_attestation(),
+    )
+
+    assert receipt["integrity_qualified"] is True
+    assert receipt["evidence_counts"]["external_network_request"] == 0
+
+
+def test_http_git_clone_remains_external_network_access() -> None:
+    receipt = build_benchmark_integrity_qualification(
+        trajectory=_trajectory(command="git clone https://github.com/owner/repo.git"),
+        runtime_attestation=_attestation(),
+    )
+
+    assert receipt["integrity_qualified"] is False
+    assert receipt["classification"] == "integrity_policy_violation"
+    assert receipt["evidence_counts"]["external_network_request"] == 1
+
+
+@pytest.mark.parametrize(
+    "command",
+    [
+        "git clone -b main --depth 1 git@github.com:owner/repo.git",
+        "git clone git+ssh://git@github.com/owner/repo.git",
+    ],
+)
+def test_non_http_git_clone_variants_remain_fail_closed(command: str) -> None:
+    receipt = build_benchmark_integrity_qualification(
+        trajectory=_trajectory(command=command),
+        runtime_attestation=_attestation(),
+    )
+
+    assert receipt["integrity_qualified"] is False
+    assert receipt["classification"] == "integrity_policy_violation"
+    assert receipt["evidence_counts"]["external_network_request"] == 1
+
+
+@pytest.mark.parametrize(
+    "command",
+    [
+        "git clone /abs/path/repo.git",
+        "git clone file:///abs/path/repo.git",
+        "git clone /tmp/cache@2/repo.git",
+    ],
+)
+def test_local_git_clone_paths_are_not_external_network_access(command: str) -> None:
+    receipt = build_benchmark_integrity_qualification(
+        trajectory=_trajectory(command=command),
+        runtime_attestation=_attestation(),
+    )
+
+    assert receipt["integrity_qualified"] is True
+    assert receipt["evidence_counts"]["external_network_request"] == 0
+
+
 def test_structured_loopback_argv_uses_explicit_loopback_scope() -> None:
     receipt = build_benchmark_integrity_qualification(
         trajectory=_trajectory(