Merge pull request #5679 from loopx-project/codex/todo-retirement-callers-20261005

refactor(todos): retire unused Python frontier selector facades

Author: huangruiteng

loopx/control_plane/todos/frontier_revision.py

@@ -1,4 +1,4 @@
-"""Compact, complete revisions for Todo advancement frontiers."""
+"""Complete source codecs and index transport for the typed Todo frontier owner."""
 
 from __future__ import annotations
 
@@ -96,23 +96,6 @@ def _request(operation: str, **facts: Any) -> dict[str, Any]:
     return result
 
 
-def _checkpoint_tuple(value: Any) -> tuple[str | None, str | None, bool] | None:
-    if value is None:
-        return None
-    if value["complete"]:
-        return value["frontier_revision"], value["frontier_updated_at"], True
-    return None, None, False
-
-
-def selectable_advancement_frontier_revision(
-    source_items: list[dict[str, Any]] | None, *, agent_id: str | None,
-) -> tuple[str | None, str | None, bool]:
-    result = _checkpoint_tuple(_request("select", rows=frontier_source_facts(source_items),
-        agent_id=normalize_todo_claimed_by(agent_id))["checkpoint"])
-    assert result is not None
-    return result
-
-
 def build_advancement_frontier_revision_index(
     source_items: list[dict[str, Any]],
 ) -> dict[str, Any]:
@@ -127,10 +110,3 @@ def attach_advancement_frontier_revision_index(
 ) -> None:
     if role == "agent":
         summary["advancement_frontier_revision_index"] = build_advancement_frontier_revision_index(source_items)
-
-
-def advancement_frontier_revision_from_index(
-    value: Any, *, agent_id: str | None,
-) -> tuple[str | None, str | None, bool] | None:
-    return _checkpoint_tuple(_request("read", index=value,
-        agent_id=normalize_todo_claimed_by(agent_id))["checkpoint"])

tests/control_plane/test_frontier_revision_scope.py

@@ -5,11 +5,12 @@
 import pytest
 
 from loopx.control_plane.todos import frontier_revision
+from loopx.control_plane.goals.goal_frontier.long_todo_chain import (
+    long_todo_chain_successor_checkpoints,
+)
 
 from loopx.control_plane.todos.frontier_revision import (
-    advancement_frontier_revision_from_index,
     build_advancement_frontier_revision_index,
-    selectable_advancement_frontier_revision,
 )
 
 
@@ -36,31 +37,29 @@ def test_excluded_unclaimed_work_does_not_rearm_this_agents_frontier():
     after = deepcopy(before)
     after[1]["priority"] = "P0"
     after[1]["updated_at"] = "2026-09-02T00:00:00Z"
-    for source in (before, after):
-        direct = selectable_advancement_frontier_revision(source, agent_id="worker-a")
-        indexed = advancement_frontier_revision_from_index(
-            build_advancement_frontier_revision_index(source), agent_id="worker-a",
-        )
-        assert direct == indexed
-    assert selectable_advancement_frontier_revision(before, agent_id="worker-a") == (
-        selectable_advancement_frontier_revision(after, agent_id="worker-a")
-    )
-    assert selectable_advancement_frontier_revision(before, agent_id="worker-b") != (
-        selectable_advancement_frontier_revision(after, agent_id="worker-b")
-    )
+    before_index = build_advancement_frontier_revision_index(before)
+    after_index = build_advancement_frontier_revision_index(after)
+    assert before_index["by_agent"] == after_index["by_agent"]
+    assert before_index["unclaimed"] != after_index["unclaimed"]
+    # The excluded-only lane must remain explicit even without claimed work.
+    assert before_index["by_agent"][0]["agent_id"] == "worker-a"
+    assert before_index["by_agent"][0]["complete"] is True
 
 
 def test_duplicate_identity_cannot_be_a_complete_frontier():
     source = rows()
     source[1]["todo_id"] = source[0]["todo_id"]
-    assert selectable_advancement_frontier_revision(source, agent_id=None) == (None, None, False)
+    index = build_advancement_frontier_revision_index(source)
+    assert index["all"] == index["unclaimed"] == {"complete": False}
 
 
 def test_removing_exclusion_rearms_newly_available_work():
     source = rows()
-    before = selectable_advancement_frontier_revision(source, agent_id="worker-a")
+    before = build_advancement_frontier_revision_index(source)
     source[1].pop("excluded_agents")
-    assert selectable_advancement_frontier_revision(source, agent_id="worker-a") != before
+    after = build_advancement_frontier_revision_index(source)
+    assert after["by_agent"] == []
+    assert before["by_agent"][0]["frontier_revision"] != after["unclaimed"]["frontier_revision"]
 
 
 def test_v0_codec_preserves_unicode_hash_and_microsecond_ordering():
@@ -72,17 +71,23 @@ def test_v0_codec_preserves_unicode_hash_and_microsecond_ordering():
     expected = "todo_frontier_revision_v0:" + sha256(encoded.encode()).hexdigest()[:24]
     source = [{**material[1], "completed_at": "2026-09-01T08:00:00.000001+08:00"},
               {**material[0], "updated_at": "2026-09-01T00:00:00.000002Z"}]
-    assert selectable_advancement_frontier_revision(source, agent_id=None) == (
-        expected, "2026-09-01T00:00:00.000002Z", True)
+    checkpoint = build_advancement_frontier_revision_index(source)["all"]
+    assert checkpoint["complete"] is True
+    assert checkpoint["frontier_revision"] == expected
+    assert checkpoint["frontier_updated_at"] == "2026-09-01T00:00:00.000002Z"
 
 
 def test_legacy_agent_spelling_in_index_remains_readable():
     source = rows()[:1]
     source[0]["claimed_by"] = "Worker A"
     index = build_advancement_frontier_revision_index(source)
     index["by_agent"][0]["agent_id"] = " Worker\u0085A "
-    assert advancement_frontier_revision_from_index(index, agent_id="worker-a") == (
-        selectable_advancement_frontier_revision(source, agent_id="Worker A"))
+    result = long_todo_chain_successor_checkpoints(
+        source, agent_id="worker-a", triggers=[], obligation_id="replan-test",
+        candidates=[], frontier_revision_index=index,
+    )
+    assert result is not None
+    assert result["trigger_checkpoints"][0]["frontier_revision"] == index["by_agent"][0]["frontier_revision"]
 
 
 def test_large_frontier_transport_preserves_exact_v0_identity_and_tail_edits():
@@ -92,10 +97,9 @@ def test_large_frontier_transport_preserves_exact_v0_identity_and_tail_edits():
     assert len(encoded.encode()) > 2 * 1024 * 1024
     expected = "todo_frontier_revision_v0:" + sha256(encoded.encode()).hexdigest()[:24]
     source = [{**item, "updated_at": "2026-09-01T00:00:00Z"} for item in material]
-    assert selectable_advancement_frontier_revision(source, agent_id=None) == (
-        expected, "2026-09-01T00:00:00Z", True)
-    assert advancement_frontier_revision_from_index(
-        build_advancement_frontier_revision_index(source), agent_id=None,
-    ) == (expected, "2026-09-01T00:00:00Z", True)
+    checkpoint = build_advancement_frontier_revision_index(source)["all"]
+    assert checkpoint["complete"] is True
+    assert checkpoint["frontier_revision"] == expected
+    assert checkpoint["frontier_updated_at"] == "2026-09-01T00:00:00Z"
     source[-1]["text"] += " Material edit at the tail."
-    assert selectable_advancement_frontier_revision(source, agent_id=None)[0] != expected
+    assert build_advancement_frontier_revision_index(source)["all"]["frontier_revision"] != expected

tests/control_plane/test_goal_frontier_replan_rules.py

@@ -19,9 +19,11 @@
     select_goal_frontier_replan_rule,
 )
 from loopx.control_plane.todos.addition import require_replan_successor_scope
+from loopx.control_plane.goals.goal_frontier.long_todo_chain import (
+    long_todo_chain_successor_checkpoints,
+)
 from loopx.control_plane.todos.frontier_revision import (
     TODO_FRONTIER_REVISION_INDEX_SCHEMA_VERSION,
-    advancement_frontier_revision_from_index,
     build_advancement_frontier_revision_index,
 )
 from loopx.control_plane.todos.summary_item import compact_todo_summary_item
@@ -337,58 +339,38 @@ def test_frontier_revision_index_preserves_complete_agent_lane_semantics() -> No
         },
     ]
     original = build_advancement_frontier_revision_index(source_items)
-    current_revision = advancement_frontier_revision_from_index(
-        original,
-        agent_id="current-agent",
-    )
-    unclaimed_revision = advancement_frontier_revision_from_index(
-        original,
-        agent_id="new-agent",
-    )
-    all_revision = advancement_frontier_revision_from_index(original, agent_id=None)
-    assert current_revision is not None and current_revision[2] is True
-    assert unclaimed_revision is not None and unclaimed_revision[2] is True
-    assert all_revision is not None and all_revision[2] is True
+    current_revision = original["by_agent"][0]
+    assert current_revision["agent_id"] == "current-agent"
+    unclaimed_revision = original["unclaimed"]
+    all_revision = original["all"]
+    assert current_revision["complete"] is True
+    assert unclaimed_revision["complete"] is True
+    assert all_revision["complete"] is True
 
     other_agent_change = deepcopy(source_items)
     other_agent_change[1]["priority"] = "P0"
     changed_other = build_advancement_frontier_revision_index(other_agent_change)
-    assert advancement_frontier_revision_from_index(
-        changed_other,
-        agent_id="current-agent",
-    ) == current_revision
-    assert advancement_frontier_revision_from_index(
-        changed_other,
-        agent_id="new-agent",
-    ) == unclaimed_revision
-    assert advancement_frontier_revision_from_index(
-        changed_other,
-        agent_id=None,
-    ) != all_revision
+    assert changed_other["by_agent"][0] == current_revision
+    assert changed_other["unclaimed"] == unclaimed_revision
+    assert changed_other["all"] != all_revision
 
     unclaimed_change = deepcopy(source_items)
     unclaimed_change[2]["priority"] = "P0"
     changed_unclaimed = build_advancement_frontier_revision_index(unclaimed_change)
-    assert advancement_frontier_revision_from_index(
-        changed_unclaimed,
-        agent_id="current-agent",
-    ) != current_revision
-    assert advancement_frontier_revision_from_index(
-        changed_unclaimed,
-        agent_id="new-agent",
-    ) != unclaimed_revision
+    assert changed_unclaimed["by_agent"][0] != current_revision
+    assert changed_unclaimed["unclaimed"] != unclaimed_revision
 
 
 def test_frontier_revision_index_rejects_malformed_agent_rows() -> None:
-    assert advancement_frontier_revision_from_index(
-        {
+    assert long_todo_chain_successor_checkpoints(
+        _long_chain_source_items(), agent_id="current-agent", triggers=[],
+        obligation_id="replan-test", candidates=[], frontier_revision_index={
             "schema_version": TODO_FRONTIER_REVISION_INDEX_SCHEMA_VERSION,
             "all": {"complete": False},
             "unclaimed": {"complete": False},
             "by_agent": "not-a-list",
         },
-        agent_id="current-agent",
-    ) == (None, None, False)
+    ) is None
 
 
 def test_todo_succession_gap_prefers_exact_lifecycle_settlement() -> None: