Repository navigation
Commit 292b85e
authored
docs(host-mode): define the declared host and assert the transition policy (#4462)
Three follow-ups from the review of #4456.
`turn_mapping.host` (`generic-cli`) sat next to `host_resolution: resolved`
and the new `host_selection: resolved_default` while `plan_command` pinned no
host, so a consumer that read only `host`/`host_resolution` could still
conclude that the concrete host had resolved to the compatibility adapter.
The protocol doc now defines the field as the mode's *declared* host and
scheduler context and states that the concrete host is resolved when
`plan_command` runs; it also documents `host_selection` and
`plan_command_rollback`.
The RFC recorded the unattended mapping as an open decision between three
options. The shipped behavior is one of them, so the paragraph now records the
decision (write out the resolved default, label the pinned compatibility
variant as the rollback path) instead of contradicting the code; the Chinese
mirror is updated with it.
The transition policy at `host_mode_planner.py` target commands had no
assertion: `examples/host-mode-plan-smoke.py` only checked
`preserves_agent_id`, `spends_quota` and the guard command. It now asserts that
targets which resolve their host pin no `--host`, and that targets needing a
visible identity still pin `--host codex-cli` with
`--execution-mode interactive-visible`. This also supersedes the merged PR
description, which described the affected transitions as hybrid-handoff
although no transition targets that mode.
Validation: `examples/host-mode-plan-smoke.py` ok,
`examples/project/host-mode-plan-cli-smoke.py` ok,
`pytest tests/test_host_mode_planner.py -q` 2 passed, `ruff check` clean, and
`loopx canary premerge --from-git-diff --timeout-seconds 300` gate=passed with
11 executed checks and 0 failures.
Signed-off-by: huangruiteng <14976749+huangruiteng@users.noreply.github.com>
Co-authored-by: huangruiteng <14976749+huangruiteng@users.noreply.github.com>1 parent f22879d commit 292b85e
4 files changed
Lines changed: 60 additions & 16 deletions
File tree
- docs
- architecture/rfcs
- reference/protocols
- examples
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
131 | 136 | | |
132 | 137 | | |
133 | 138 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
| 100 | + | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
107 | 111 | | |
108 | 112 | | |
109 | 113 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
145 | 162 | | |
146 | 163 | | |
147 | 164 | | |
| |||
150 | 167 | | |
151 | 168 | | |
152 | 169 | | |
153 | | - | |
| 170 | + | |
| 171 | + | |
154 | 172 | | |
155 | 173 | | |
156 | 174 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
348 | 348 | | |
349 | 349 | | |
350 | 350 | | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
351 | 368 | | |
352 | 369 | | |
353 | 370 | | |
| |||
0 commit comments