From 389af3397110aad204c8303654430850b821e30d Mon Sep 17 00:00:00 2001
From: 123digits <22726303+123digits@users.noreply.github.com>
Date: Thu, 6 Aug 2026 11:19:16 +0000
Subject: [PATCH] feat: add S3 partition storage profile field

---
 openapi/management-open-api.yaml      |  4 +++
 package-lock.json                     |  4 +--
 package.json                          |  2 +-
 src/components/WarehouseStorageS3.vue | 38 ++++++++++++++++++++++++++-
 src/gen/management/types.gen.ts       |  4 +++
 5 files changed, 48 insertions(+), 4 deletions(-)

diff --git a/openapi/management-open-api.yaml b/openapi/management-open-api.yaml
index 9a8d4cbc..a364985f 100644
--- a/openapi/management-open-api.yaml
+++ b/openapi/management-open-api.yaml
@@ -10240,6 +10240,10 @@ components:
         bucket:
           type: string
           description: Name of the S3 bucket
+        partition:
+          type: string
+          default: aws
+          description: AWS partition used when constructing S3 ARNs for vended-credential policies.
         endpoint:
           type:
             - string
diff --git a/package-lock.json b/package-lock.json
index cc76b257..406dc5de 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,12 +1,12 @@
 {
   "name": "@lakekeeper/console-components",
-  "version": "0.20.0",
+  "version": "0.21.0",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@lakekeeper/console-components",
-      "version": "0.20.0",
+      "version": "0.21.0",
       "license": "Apache-2.0",
       "dependencies": {
         "@codemirror/commands": "^6.10.3",
diff --git a/package.json b/package.json
index 1dd46af9..36ceb8af 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@lakekeeper/console-components",
-  "version": "0.20.0",
+  "version": "0.21.0",
   "description": "A library of Vue components for Lakekeeper console applications",
   "type": "module",
   "main": "dist/console-components.umd.js",
diff --git a/src/components/WarehouseStorageS3.vue b/src/components/WarehouseStorageS3.vue
index 1604fb85..461c058b 100644
--- a/src/components/WarehouseStorageS3.vue
+++ b/src/components/WarehouseStorageS3.vue
@@ -261,6 +261,17 @@
               </template>
             </v-select>
           </v-col>
+          <v-col>
+            <v-combobox
+              v-model="warehouseObjectData['storage-profile']['partition']"
+              :items="s3Partitions"
+              label="Bucket Partition *"
+              placeholder="aws"
+              :rules="[rules.required]"
+              :error="isPartitionInvalid"
+              :color="isPartitionInvalid ? 'error' : 'primary'"
+              :style="isPartitionInvalid ? 'color: rgb(var(--v-theme-error));' : ''"></v-combobox>
+          </v-col>
           <v-col>
             <v-combobox
               v-model="warehouseObjectData['storage-profile'].region"
@@ -714,6 +725,7 @@
             type="submit"
             :disabled="
               isAccessKeyMissing ||
+              isPartitionInvalid ||
               !warehouseObjectData['storage-profile'].bucket ||
               isRegionInvalid ||
               isStsArnMissing
@@ -730,6 +742,7 @@
                 size="small"
                 :disabled="
                   isAccessKeyMissing ||
+                  isPartitionInvalid ||
                   !warehouseObjectData['storage-profile'].bucket ||
                   isRegionInvalid ||
                   isStsArnMissing
@@ -757,6 +770,7 @@
           variant="flat"
           :disabled="
             isAccessKeyMissing ||
+            isPartitionInvalid ||
             !warehouseObjectData['storage-profile'].bucket ||
             isRegionInvalid ||
             isStsArnMissing
@@ -787,6 +801,16 @@ import cfIcon from '@/assets/cf.svg';
 
 const showPassword = ref(false);
 
+const s3Partitions = [
+  'aws',
+  'aws-cn',
+  'aws-us-gov',
+  'aws-iso',
+  'aws-iso-b',
+  'aws-iso-e',
+  'aws-iso-f',
+];
+
 const s3UrlDetectionModes = [
   { name: 'Path', code: 'path' },
   { name: 'Virtual Host', code: 'virtual_host' },
@@ -823,6 +847,7 @@ const warehouseObjectData = reactive<{
   'storage-profile': {
     type: 's3',
     bucket: '',
+    partition: 'aws',
     region: '',
     'remote-signing-enabled': true,
     'sts-enabled': false,
@@ -1047,6 +1072,10 @@ const isBucketInvalid = computed(() => {
   return !warehouseObjectData['storage-profile'].bucket;
 });
 
+const isPartitionInvalid = computed(() => {
+  return !warehouseObjectData['storage-profile']['partition'];
+});
+
 const isRegionInvalid = computed(
   () => isRegionRequired.value && !warehouseObjectData['storage-profile'].region,
 );
@@ -1184,7 +1213,14 @@ const emitNewProfile = () => {
 
 onMounted(() => {
   if (props.warehouseObject) {
-    Object.assign(warehouseObjectData, props.warehouseObject);
+    // Clone the nested objects so local edits (and the partition default below)
+    // never write back into the parent-owned prop.
+    Object.assign(warehouseObjectData, {
+      ...props.warehouseObject,
+      'storage-profile': { ...props.warehouseObject['storage-profile'] },
+      'storage-credential': { ...props.warehouseObject['storage-credential'] },
+    });
+    warehouseObjectData['storage-profile']['partition'] ??= 'aws';
 
     // Initialize storage layout from existing data
     const existingLayout = warehouseObjectData['storage-profile']['storage-layout'];
diff --git a/src/gen/management/types.gen.ts b/src/gen/management/types.gen.ts
index 2313b11e..622464ab 100644
--- a/src/gen/management/types.gen.ts
+++ b/src/gen/management/types.gen.ts
@@ -2151,6 +2151,10 @@ export type S3Profile = {
      * Name of the S3 bucket
      */
     bucket: string;
+    /**
+     * AWS partition used when constructing S3 ARNs for vended-credential policies.
+     */
+    partition?: string;
     /**
      * Optional endpoint to use for S3 requests, if not provided
      * the region will be used to determine the endpoint.