diff --git a/pkg/scalers/aws/aws_config_cache.go b/pkg/scalers/aws/aws_config_cache.go index cbc1cf3d08a..a92218f0816 100644 --- a/pkg/scalers/aws/aws_config_cache.go +++ b/pkg/scalers/aws/aws_config_cache.go @@ -137,7 +137,7 @@ func (a *sharedConfigCache) RemoveCachedEntry(awsAuthorization AuthorizationMeta if len(cachedEntry.usages) == 0 { delete(a.items, key) } else { - a.items[awsAuthorization.AwsRoleArn] = cachedEntry + a.items[key] = cachedEntry } } } diff --git a/pkg/scalers/aws/aws_config_cache_test.go b/pkg/scalers/aws/aws_config_cache_test.go index 81abbdca6c7..c0b7fccf1bd 100644 --- a/pkg/scalers/aws/aws_config_cache_test.go +++ b/pkg/scalers/aws/aws_config_cache_test.go @@ -79,6 +79,7 @@ func TestRemoveCachedEntryRemovesCachedItemIfNotUsages(t *testing.T) { } cache.RemoveCachedEntry(awsAuthorization) assert.NotContains(t, cache.items, cacheKey) + assert.Len(t, cache.items, 0) } func TestRemoveCachedEntryNotRemoveCachedItemIfUsages(t *testing.T) { @@ -99,7 +100,8 @@ func TestRemoveCachedEntryNotRemoveCachedItemIfUsages(t *testing.T) { }, } cache.RemoveCachedEntry(awsAuthorization) - assert.Contains(t, cache.items, cacheKey) + assert.Len(t, cache.items, 1) + assert.Len(t, cache.items[cacheKey].usages, 1) } func TestCredentialsShouldBeCachedPerRegion(t *testing.T) {