Skip to content

fix: Modify scope to always include profile for Google OAuth #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smaudd wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Modify scope to always include profile for Google OAuth #1725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/oauth-providers/src/providers/google/googleAuth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@
login_hint: options.login_hint,
prompt: options.prompt,
access_type: options.access_type,
scope: options.scope,
// profile scope is always mandatory because https://www.googleapis.com/oauth2/v2/userinfo needs it
scope: options.includes("profile") ? options.scope : ["profile", ...options.scope],

Check failure on line 30 in packages/oauth-providers/src/providers/google/googleAuth.ts

View workflow job for this annotation

GitHub Actions / build 

Property 'includes' does not exist on type '{ scope: string[]; login_hint?: string | undefined; prompt?: "consent" | "none" | "select_account" | undefined; access_type?: "offline" | "online" | undefined; client_id?: string | undefined; client_secret?: string | undefined; state?: string | undefined; redirect_uri?: string | undefined; }'.

Check failure on line 30 in packages/oauth-providers/src/providers/google/googleAuth.ts

View workflow job for this annotation

GitHub Actions / build 

Property 'includes' does not exist on type '{ scope: string[]; login_hint?: string | undefined; prompt?: "consent" | "none" | "select_account" | undefined; access_type?: "offline" | "online" | undefined; client_id?: string | undefined; client_secret?: string | undefined; state?: string | undefined; redirect_uri?: string | undefined; }'.

Check failure on line 30 in packages/oauth-providers/src/providers/google/googleAuth.ts

View workflow job for this annotation

GitHub Actions / autofix 

Unsafe call of a type that could not be resolved
state: newState,
code: c.req.query('code'),
token: {
Expand Down
Loading