Windows/macOS: Re-register global shortcuts on keyboard layout change#3536
Draft
hluk wants to merge 1 commit into
Draft
Windows/macOS: Re-register global shortcuts on keyboard layout change#3536hluk wants to merge 1 commit into
hluk wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (47.05%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #3536 +/- ##
==========================================
+ Coverage 81.00% 81.05% +0.04%
==========================================
Files 246 246
Lines 31612 31627 +15
==========================================
+ Hits 25607 25634 +27
+ Misses 6005 5993 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hluk
force-pushed
the
fix-windows-shortcut-layout
branch
2 times, most recently
from
7e1183b to
5891dc8
Compare
When the keyboard layout changes, the native keycodes for registered shortcuts may change. Re-register all shortcuts with updated native codes to keep them working. Windows: Handle WM_INPUTLANGCHANGE message in the native event filter. macOS: Observe kTISNotifySelectedKeyboardInputSourceChanged via the CF distributed notification center, which is the correct mechanism for detecting input source changes (polling TISCopyCurrentKeyboardInputSource does not work reliably as it requires the event loop to run). Fixes #1323 Assisted-by: Opus 4.6 (Anthropic)
hluk
force-pushed
the
fix-windows-shortcut-layout
branch
from
5891dc8 to
919dd91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the keyboard layout changes, the native keycodes for registered shortcuts may change. Re-register all shortcuts with updated native codes to keep them working.
Windows: Handle WM_INPUTLANGCHANGE message in the native event filter.
macOS: Observe kTISNotifySelectedKeyboardInputSourceChanged via the CF distributed notification center, which is the correct mechanism for detecting input source changes (polling TISCopyCurrentKeyboardInputSource does not work reliably as it requires the event loop to run).
Fixes #1323
Assisted-by: Opus 4.6 (Anthropic)