Skip to content

Follow hlint suggestion: use void#11849

Open
philderbeast wants to merge 1 commit into
haskell:masterfrom
cabalism:hlint/use-void
Open

Follow hlint suggestion: use void#11849
philderbeast wants to merge 1 commit into
haskell:masterfrom
cabalism:hlint/use-void

Conversation

@philderbeast
Copy link
Copy Markdown
Collaborator

See #9110. Discharges and no longer ignores HLint's "use void" suggestion so that these will be suggested by our CI linting.

I'll squash commits before applying the merge label if this pull request is approved. The first commit resets the # count comments in .hlint.yaml.


  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Comment thread Cabal/src/Distribution/Backpack/ReadyComponent.hs Outdated
Comment thread cabal-install/src/Distribution/Deprecated/ReadP.hs
@philderbeast philderbeast force-pushed the hlint/use-void branch 3 times, most recently from 4cde689 to aec6323 Compare May 21, 2026 18:33
@philderbeast philderbeast added merge me Tell Mergify Bot to merge and removed attention: needs-review labels May 21, 2026
@mergify mergify Bot added the ready and waiting Mergify is waiting out the cooldown period label May 21, 2026
- Redo counts
- Minimize diffs
- Inline monitorReason' = void monitorReason
- One more application of void
- Use $ and not parentheses
- Use -XLambdaCase for instantiate unitId work
@philderbeast
Copy link
Copy Markdown
Collaborator Author

@mergify queue

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 24, 2026

Merge Queue Status

This pull request spent 1 hour 23 minutes 54 seconds in the queue, including 1 hour 13 minutes 35 seconds running CI.

Waiting for any of
  • check-neutral = Validate post job
  • check-skipped = Validate post job
  • check-success = Validate post job
All conditions
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Validate post job
    • check-skipped = Validate post job
    • check-success = Validate post job
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

@mergify mergify Bot added the queued label May 24, 2026
mergify Bot added a commit that referenced this pull request May 24, 2026
@mergify mergify Bot added dequeued and removed queued labels May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dequeued merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants