Skip to content

Newly introduced dependency on hijri-converter prevents WebJar deployment #2914

@jgosmann

Description

@jgosmann

To reproduce

We consume react-day-picker as WebJar. Version 9.14.0 can no longer consumed this way because the dependency @tabby_ai/hijri-converter fails to deploy and is thus not available afterwards. This can be easily reproduced by clicking the "Add a WebJar" button on the WebJar website and choosing:

  • WebJar Type: NPM
  • Package Name: react-day-picker
  • Version: 9.14.0

Then click "Deploy!" and wait for while. Eventually you'll get this error (more stuff will be printed afterwards):

Deploying Dependency: NPM @tabby_ai/hijri-converter 1.0.5
 
The metadata was missing a required field: /repository/url

Actual Behavior

Dependency @tabby_ai/hijri-converter is not deployed and react-day-picker can thus not be consumed as WebJar.

Expected Behavior

One of:

  • @tabby_ai/hijri-converter deploys correctly as WebJar. Of course, this would not be a react-day-picker issue, but an upstream issue. It actually happens to have been fixed and would just require a new release. Unfortunately, I did not receive a reaction on my request to do such a release. Apparently, also a manual deploy with overridden repository URL would be possible on the WebJar side, but that request didn't receive any reaction either.
  • Make the @tabby_ai/hijri-converter dependency optional in react-day-picker. We don't need hijri support and given the rise in supply chain attack, I would be quite happy to cut unnecessary dependencies.

Screenshots

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions