No module named 'pysc2.env.converter'

[KotlinIsland]

it looks like the sdist doesn't include these packages

[Kaszanas]

From what I know the converter should be compiled by Bazel.
I was trying to do that but some of the packages used changed, and the compilation does not work.
First of all:

1. pybind dependency changed, it does not have the python_configure file, last version that did was pybind11_bazel-2.11.1.bzl.1

Bazel itself deprecated the WORKSPACE file and moved towards MODULE.bazel.

[KotlinIsland]

@Kaszanas I'm actually working on a fork of this project to make it work again and be usable with current python versions

[Kaszanas]

@Kaszanas I'm actually working on a fork of this project to make it work again and be usable with current python versions

Same here, I have a fork called pysc2_evolved with type annotations, 4 space indentations, no absl package causing issues on imports etc. compiling with Bazel is the biggest issue.

Unfortunately I work on Windows these are the Bazel issues that I have uncovered:

1. Compilation apparently is only meant/tested for Linux.
2. No specific versions of packages are pinned which means that if any file was moved the build will fail.

Using only headless builds for Linux is another thing. I'm working on newer replays so I'm forced to use Windows or try to dabble with emulations like wine.

[KotlinIsland]

that's awesomet that you are working on this, i also had to fork s2clientprotocol and s2protocol because they don't work with modern stuff

why did you remove absl specifically? i haven't run into any issues yet with it

my fork is currently compiling on macos and linux. i suspect that windows might have more issues, but i'm planning on getting to it.

hopefully we will be able to share knowledge on this

[Kaszanas]

Importing any function from a file that used absl was impossible, flags were used as global values instead of being passed to specific functions. That's the worst thing for reusability that can be done. Had to change it to make my code work.

[Balxkodehodet]

from absl import flags
FLAGS = flags.FLAGS
FLAGS(['customCNN_ppo_x10default.py']) <------------------------------------- inside there use your filename

Not sure how relevant it is, but I saw you talked about absl and flags.
I also got an absl error when trying to use pysc2 generally... after awhile I eventually vibe coded the right solution (shown above)

It should fix every absl flag error

[Balxkodehodet]

but you have to call the FLAGS and rewrite the filename on each file that you have a absl error

[Kaszanas]

I have fixed the error by forking and not using any global variables in any files that may be imported.

Didn't have to vibecode 😅

[Balxkodehodet]

ok! Glad you fixed it :-)

[Kaszanas]

that's awesomet that you are working on this, i also had to fork s2clientprotocol and s2protocol because they don't work with modern stuff

why did you remove absl specifically? i haven't run into any issues yet with it

my fork is currently compiling on macos and linux. i suspect that windows might have more issues, but i'm planning on getting to it.

hopefully we will be able to share knowledge on this

@KotlinIsland do you have any new developments?
Would love to know if you were able to run Bazel on Windows and compile the converter.

[KotlinIsland]

I kinda gave up and am working with other stuff. there was just so many things broken here it was a massive uphill battle

[Kaszanas]

I kinda gave up and am working with other stuff. there was just so many things broken here it was a massive uphill battle

Thanks for a quick response, I can say I fully understand. If you have/had any working improvements around the converter and its compilation please let me know. I'd be happy to introduce them to my patched version of pysc2.