Skip to content

Commit 1fb62a2

Browse files
Vasilii IakliushinWarheadsSE
authored andcommitted
Merge branch 'labkit-1-64-10-fips-native' into 'main'
Update module gitlab.com/gitlab-org/labkit to v1.64.11 See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/1523 Merged-by: Vasilii Iakliushin <viakliushin@gitlab.com> Approved-by: James Liu <jliu@gitlab.com> Approved-by: Vasilii Iakliushin <viakliushin@gitlab.com> Reviewed-by: GitLab Duo <gitlab-duo@gitlab.com> Co-authored-by: Jason Plum <jplum@gitlab.com>
2 parents 9d895ff + 893f832 commit 1fb62a2

3 files changed

Lines changed: 12 additions & 3 deletions

File tree

‎go.mod‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ require (
1919
github.com/stretchr/testify v1.11.1
2020
gitlab.com/gitlab-org/cells/topology-service v0.0.0-20260522095121-2c761c2e9850
2121
gitlab.com/gitlab-org/gitaly/v18 v18.9.0-rc4
22-
gitlab.com/gitlab-org/labkit v1.64.8
22+
gitlab.com/gitlab-org/labkit v1.64.11
2323
gitlab.com/gitlab-org/labkit/v2 v2.3.0
2424
golang.org/x/crypto v0.54.0
2525
golang.org/x/sync v0.22.0

‎go.sum‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -528,8 +528,8 @@ gitlab.com/gitlab-org/gitaly/v18 v18.9.0-rc4 h1:2PQlCQF5ioVdmcjY6Ut8zxwFY2TIgHWn
528528
gitlab.com/gitlab-org/gitaly/v18 v18.9.0-rc4/go.mod h1:ijDPC9GyV3UdmrZG4LiBQJyMjOuzLcbH5AuQ8GpSSIk=
529529
gitlab.com/gitlab-org/go/reopen v1.0.0 h1:6BujZ0lkkjGIejTUJdNO1w56mN1SI10qcVQyQlOPM+8=
530530
gitlab.com/gitlab-org/go/reopen v1.0.0/go.mod h1:D6OID8YJDzEVZNYW02R/Pkj0v8gYFSIhXFTArAsBQw8=
531-
gitlab.com/gitlab-org/labkit v1.64.8 h1:YyYvCGf1Drkf4V+9b5hjLtOM2pOxnwDueOgR1g2/mfs=
532-
gitlab.com/gitlab-org/labkit v1.64.8/go.mod h1:ARZnzZ49zdjPQfoyaW8sEpZz2EDFXN4NKNblste8nhc=
531+
gitlab.com/gitlab-org/labkit v1.64.11 h1:DaFI+CU2IcILZ6tULuCOOHbjEh1R+orOrkdbWCgdiyw=
532+
gitlab.com/gitlab-org/labkit v1.64.11/go.mod h1:ARZnzZ49zdjPQfoyaW8sEpZz2EDFXN4NKNblste8nhc=
533533
gitlab.com/gitlab-org/labkit/v2 v2.3.0 h1:N8ULmZ9WoFOqs4dFKu8ENfN/MPgMFtZu7/qFsIBk1d0=
534534
gitlab.com/gitlab-org/labkit/v2 v2.3.0/go.mod h1:oeJFqS+ECV8nD+Iye0o4rDKJPS+4rVFvVzBmb+7DcxM=
535535
go.etcd.io/raft/v3 v3.6.0 h1:5NtvbDVYpnfZWcIHgGRk9DyzkBIXOi8j+DDp1IcnUWQ=

‎internal/sshd/server_config_test.go‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -372,6 +372,15 @@ func TestNonFipsDefaultAlgorithms(t *testing.T) {
372372
}
373373

374374
func TestCustomAlgorithms(t *testing.T) {
375+
if fips.Enabled() {
376+
// Under the native Go FIPS 140-3 module, x/crypto's ssh package
377+
// registers only FIPS-approved algorithms, and SetDefaults()
378+
// silently drops non-approved custom choices (curve25519 kex,
379+
// chacha20 ciphers, ...). Skip under any FIPS backend for
380+
// consistency with the other tests in this file.
381+
t.Skip("FIPS mode restricts SSH algorithms; custom non-approved algorithms are filtered by x/crypto")
382+
}
383+
375384
customMACs := []string{"hmac-sha2-512-etm@openssh.com"}
376385
customKexAlgos := []string{"curve25519-sha256", "curve25519-sha256@libssh.org"}
377386
customCiphers := []string{"aes256-gcm@openssh.com"}

0 commit comments

Comments
 (0)