ref(lint): Enable no-unnecessary-template-expression (#2126)

Turns on `typescript/no-unnecessary-template-expression` and unwraps the
template literals that only wrapped a single string.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>

Author: 3 people

.oxlintrc.json

@@ -37,6 +37,7 @@
         "allow": ["URL", "URLSearchParams"]
       }
     ],
+    "typescript/no-unnecessary-template-expression": "error",
     "typescript/no-unnecessary-type-assertion": "error",
     "typescript/no-unnecessary-type-parameters": "error",
     "typescript/no-useless-default-assignment": "error",

packages/cli/src/commands/issue/resolve-commit-spec.ts

@@ -161,7 +161,7 @@ export async function resolveCommitSpec(
   if (!match) {
     throw new ValidationError(
       `--in @commit:${spec.repository}@${spec.commit}: no Sentry repository named '${spec.repository}' in organization '${orgSlug}'.\n\n` +
-        `${formatAvailableRepos(sentryRepos)}`,
+        formatAvailableRepos(sentryRepos),
       "in",
     );
   }

packages/cli/src/lib/db/pagination.ts

@@ -518,7 +518,7 @@ export function buildMultiTargetContextKey(
     ? escapeContextKeyValue(filters.query)
     : undefined;
   return (
-    `${base}` +
+    base +
     (escapedSort ? `|sort:${escapedSort}` : "") +
     `|period:${escapedPeriod}` +
     (escapedQuery ? `|q:${escapedQuery}` : "") +

packages/cli/src/lib/formatters/human.ts

@@ -2422,9 +2422,7 @@ export function formatUpgradeResult(data: UpgradeResult): string {
     default: {
       // Exhaustive check — all action types should be handled above
       const _: never = data.action;
-      lines.push(
-        `${ACTION_DESCRIPTIONS[_ as UpgradeResult["action"]] ?? "Done"}`,
-      );
+      lines.push(ACTION_DESCRIPTIONS[_ as UpgradeResult["action"]] ?? "Done");
     }
   }
 

packages/cli/test/lib/command.test.ts

@@ -1213,7 +1213,7 @@ describe("buildCommand return-based output", () => {
       auth: false,
       docs: { brief: "Test" },
       output: {
-        human: (d: { id: number; name: string; role: string }) => `${d.name}`,
+        human: (d: { id: number; name: string; role: string }) => d.name,
       },
       parameters: {},
       async *func(this: TestContext) {

packages/cli/test/lib/delta-upgrade.mocked.test.ts

@@ -227,7 +227,7 @@ describe("resolveNightlyDelta", () => {
                 mediaType: "application/octet-stream",
                 size: 1000,
                 annotations: {
-                  "org.opencontainers.image.title": `${BINARY_NAME}`,
+                  "org.opencontainers.image.title": BINARY_NAME,
                 },
               },
             ],

packages/cli/test/lib/formatters/output.test.ts

@@ -66,7 +66,7 @@ describe("renderCommandOutput", () => {
   test("renders JSON when json=true", () => {
     const w = createTestWriter();
     const config: OutputConfig<{ id: number; name: string }> = {
-      human: (d) => `${d.name}`,
+      human: (d) => d.name,
     };
     render(w, { id: 1, name: "Alice" }, config, { json: true });
     expect(JSON.parse(w.output)).toEqual({ id: 1, name: "Alice" });

packages/cli/test/lib/formatters/text-table.test.ts

@@ -376,7 +376,9 @@ describe("truncate option", () => {
   });
 
   test("ellipsis inherits ANSI color from surrounding text", () => {
-    const colored = `${chalk.hex("#898294")("A very long colored text that will be truncated at the boundary")}`;
+    const colored = chalk.hex("#898294")(
+      "A very long colored text that will be truncated at the boundary",
+    );
     const out = renderTextTable(["VAL"], [[colored]], {
       maxWidth: 30,
       truncate: true,

packages/cli/test/lib/hex-id.test.ts

@@ -202,7 +202,7 @@ describe("validateHexId", () => {
   });
 
   test("throws for newline-separated IDs (not a single valid ID)", () => {
-    const multiLine = `${VALID_ID}\n${"bbbb1111cccc2222dddd3333eeee4444"}`;
+    const multiLine = `${VALID_ID}\nbbbb1111cccc2222dddd3333eeee4444`;
     expect(() => validateHexId(multiLine, "test ID")).toThrow(ValidationError);
   });
 

packages/cli/test/lib/sentry-client.test.ts

@@ -643,7 +643,7 @@ describe("fetchWithTimeout internal timeout classification", () => {
     const authFetch = getSdkConfig(REGION_URL, {
       idempotent: true,
       timeoutMs: 50,
-    }).fetch as typeof fetch;
+    }).fetch;
     const error = await authFetch(`${REGION_URL}/api/0/chunk-upload/`, {
       method: "POST",
       body: "{}",