Skip to content

Commit 2dbab9b

Browse files
ref(aci): Remove feedback button from metric issue triggered condition (#130549)
Removes the "Give Feedback" button from the Triggered Condition section on metric issue details. Sentry already has a global feedback button, so the one in this section isn't needed. The section's actions now show only the "Open in" destination button, and they still wait for the open period to finish loading. The wrapping `Flex` was only there to space out the two buttons, so it's gone too. <!-- junior-request-attribution:start --> via @mrduncan. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:slack%3AC0C8Z02BG5Q%3A1794267384.030619 --> -- [View Session](https://junior-prod.sentry.dev/conversations/slack%3AC0C8Z02BG5Q%3A1794267384.030619) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AC0C8Z02BG5Q%3A1794267384.030619/?project=4510944073809921) <!-- junior-session-footer:end --> Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Matt Duncan <14761+mrduncan@users.noreply.github.com>
1 parent 81dfa7b commit 2dbab9b

1 file changed

Lines changed: 7 additions & 22 deletions

File tree

‎static/app/views/issueDetails/sidebar/metricDetectorTriggeredSection.tsx‎

Lines changed: 7 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import {toast} from '@sentry/scraps/toast';
2323
import {Feature} from 'sentry/components/acl/feature';
2424
import {ErrorBoundary} from 'sentry/components/errorBoundary';
2525
import {AnnotatedText} from 'sentry/components/events/meta/annotatedText';
26-
import {FeedbackButton} from 'sentry/components/feedbackButton/feedbackButton';
2726
import {GroupList} from 'sentry/components/issues/groupList';
2827
import {Placeholder} from 'sentry/components/placeholder';
2928
import {ProvidedFormattedQuery} from 'sentry/components/searchQueryBuilder/formattedQuery';
@@ -459,28 +458,14 @@ function TriggeredConditionDetails({
459458
title="Triggered Condition"
460459
sectionKey="triggered_condition"
461460
actions={
462-
<Flex gap="xs">
463-
<FeedbackButton
464-
variant="secondary"
465-
aria-label={t('Give feedback on metric issues')}
466-
size="xs"
467-
feedbackOptions={{
468-
messagePlaceholder: t('Tell us what you think about this metric issue.'),
469-
tags: {
470-
'feedback.source': 'metric_issue_details',
471-
'feedback.owner': 'aci',
472-
},
473-
}}
461+
isOpenPeriodLoading ? null : (
462+
<OpenInDestinationButton
463+
snubaQuery={snubaQuery}
464+
projectId={projectId}
465+
start={startDate}
466+
end={endDate}
474467
/>
475-
{!isOpenPeriodLoading && (
476-
<OpenInDestinationButton
477-
snubaQuery={snubaQuery}
478-
projectId={projectId}
479-
start={startDate}
480-
end={endDate}
481-
/>
482-
)}
483-
</Flex>
468+
)
484469
}
485470
>
486471
<KeyValueTableCard

0 commit comments

Comments
 (0)