Skip to content

[handoff] fix(staking): follow the CON-471 ValidatorStake.live -> hasUnclaimedRewards rename - #116

Merged
ci-core-e2e-runner[bot] merged 1 commit into
v0.19-devfrom
con-471-rename-live-hasunclaimedrewards
Sep 23, 2026
Merged

ci-core-e2e-runner[bot] merged 1 commit into
v0.19-devfrom
con-471-rename-live-hasunclaimedrewards

Conversation

@cgmello

@cgmello cgmello commented Sep 8, 2026 •

Copy link
Copy Markdown

Delivery context

Handoff from the consensus team. Requested owner: genlayer-py maintainers.

Problem and outcome

genlayer-consensus#1403 renames the ValidatorStake.live tuple component to hasUnclaimedRewards (the flag marks unclaimed inflation rewards, not node liveness). The staking ABI shipped here still names the component live, so named decoding exposes the wrong key after the contracts upgrade.

This PR renames the three ValidatorStake tuple components in genlayer_py/staking/abi/staking_abi.json. No Python code in this repo reads the field.

Implementation and validation

  • ABI JSON parses (346 entries). No behavior change.
  • Coordinate delivery with the consensus rename in genlayer-consensus#1595; the selected consensus cut owns the cross-repository dependency edge.

🤖 Generated with Claude Code

https://claude.ai/code/session_01KVkzRWuHBntyhom3xqHEAG

Integration-cut relationship

The selected M2 landing cut, genlayerlabs/genlayer-consensus#1595, will include this consumer as a dependency. The rename is already in that owner composition. This PR has no reverse consensus dependency, avoiding two competing consensus refs in one resolved E2E closure. No final delivery is authorized by this metadata update.

@cgmello cgmello self-assigned this Sep 8, 2026
@coderabbitai

coderabbitai Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: ee5e1af5-4d67-4f3b-856b-88108ac54ad0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cgmello cgmello removed their assignment Sep 8, 2026
…ewards rename

genlayer-consensus renames `ValidatorStake.live` to `hasUnclaimedRewards`
(the flag marks unclaimed inflation rewards, not node liveness). Update
the three ValidatorStake tuple components in the staking ABI so named
decoding exposes the new key.

Depends-On: genlayerlabs/genlayer-consensus#1403

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KVkzRWuHBntyhom3xqHEAG
@cgmello
cgmello force-pushed the con-471-rename-live-hasunclaimedrewards branch from 1ff94d2 to 29609f7 Compare September 8, 2026 23:33
@kirilaa
kirilaa marked this pull request as ready for review September 23, 2026 14:05
@kirilaa
kirilaa self-requested a review September 23, 2026 14:05
@ci-core-e2e-runner
ci-core-e2e-runner Bot merged commit fd8a931 into v0.19-dev Sep 23, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants