fix: simplify PAT modal state cleanup

Replace the wasOpen render-time tracking with explicit cleanup
at the two exit points: setPat('') after successful connect,
and a handleClose callback that clears pat and error on cancel
or dismiss.

Addresses review feedback from PR #24.

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Co-Authored-By: Claude <noreply@anthropic.com>

Author: matejvasek

src/components/UserAvatar.tsx

@@ -90,10 +90,13 @@ interface PatModalProps {
 
 function PatModal({ isOpen, onClose, onConnect }: PatModalProps) {
   const { t } = useTranslation('plugin__console-functions-plugin');
-  const { pat, isValidating, error, setPat, handleConnect } = usePatModal(isOpen, onConnect);
+  const { pat, isValidating, error, setPat, handleConnect, handleClose } = usePatModal(
+    onClose,
+    onConnect,
+  );
 
   return (
-    <Modal isOpen={isOpen} onClose={isValidating ? undefined : onClose} variant="small">
+    <Modal isOpen={isOpen} onClose={isValidating ? undefined : handleClose} variant="small">
       <ModalHeader title={t('Connect to GitHub')} />
       <ModalBody>
         {error && (
@@ -120,39 +123,37 @@ function PatModal({ isOpen, onClose, onConnect }: PatModalProps) {
         >
           {t('Connect')}
         </Button>
-        <Button variant="link" onClick={onClose} isDisabled={isValidating}>
+        <Button variant="link" onClick={handleClose} isDisabled={isValidating}>
           {t('Cancel')}
         </Button>
       </ModalFooter>
     </Modal>
   );
 }
 
-function usePatModal(isOpen: boolean, onConnect: (pat: string) => Promise<void>) {
+function usePatModal(onClose: () => void, onConnect: (pat: string) => Promise<void>) {
   const [pat, setPat] = useState('');
   const [isValidating, setIsValidating] = useState(false);
   const [error, setError] = useState<string | null>(null);
-  const [wasOpen, setWasOpen] = useState(false);
-
-  if (isOpen && !wasOpen) {
-    setWasOpen(true);
-    setPat('');
-    setError(null);
-  } else if (!isOpen && wasOpen) {
-    setWasOpen(false);
-  }
 
   const handleConnect = async () => {
     setIsValidating(true);
     setError(null);
     try {
       await onConnect(pat);
+      setPat('');
     } catch (err) {
       setError(errorMessage(err));
     } finally {
       setIsValidating(false);
     }
   };
 
-  return { pat, isValidating, error, setPat, handleConnect };
+  const handleClose = () => {
+    setPat('');
+    setError(null);
+    onClose();
+  };
+
+  return { pat, isValidating, error, setPat, handleConnect, handleClose };
 }