Skip to content

Commit 6d04c30

Browse files
boubakerclaude
andauthored
fix: The administration declaration's comment describes the overwrite reload EXO-91183 (#233)
**Symptom**: the comment on the `administration` declaration of `portal-configuration.xml` says that reloading only the exo part of the site makes the `PageImporter` remove Meeds' administration pages, and recommends `io.meeds.administration.portalConfig.metadata.importmode=overwrite` to reload either part. With Meeds-io/portal#1338 the first is false, and the recommended property also reloads the `global` site, which the comment doesn't say. **Cause**: with Meeds-io/portal#1338, a startup that runs an `overwrite` declaration of a site imports the pages and the navigation of every declaration of that site, and removes the pages and nodes none of them defines. The `io.meeds.administration` properties also set the mode of this file's `global` declaration. **Fix**: the comment says that, with `overwrite`, either property reloads the pages and the navigation of all the administration declarations, Meeds' included, and removes the pages and nodes none of them defines, and that the `io.meeds.administration` property reloads `global` as well. Comment only; `xmllint --noout` on the file at `943e39f`: no output (well-formed). **Release order**: merge with or after Meeds-io/portal#1338, whose behaviour the comment describes. Knowledge: Meeds-io/eng-standards#409, #560, #586, #587 This change is classified N3: no REST/DAO/schema/ACL surface touched (a comment in a configuration file). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 786ee63 commit 6d04c30

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

‎digital-workplace-webapps/src/main/webapp/WEB-INF/conf/digital-workplace/portal-configuration.xml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -100,11 +100,11 @@
100100
<boolean>${exo.administration.portalConfig.metadata.override:true}</boolean>
101101
</field>
102102
<!--
103-
we create here a different property from io.meeds.administration.portalConfig.metadata.importmode
104-
If you need to reload exo part of administration configuration, you need to reload all the administration configuration.
105-
Else, the PageImporter will REMOVE meeds administration pages.
106-
So, to reload administration portal (meeds part or exo part), use
107-
io.meeds.administration.portalConfig.metadata.importmode=overwrite
103+
A property distinct from io.meeds.administration.portalConfig.metadata.importmode.
104+
With overwrite, either property reloads the pages and the navigation of all the administration
105+
declarations, Meeds' included, and removes the pages and nodes none of them defines.
106+
io.meeds.administration.portalConfig.metadata.importmode also sets the mode of the global
107+
declaration below, so it reloads global as well.
108108
-->
109109
<field name="importMode">
110110
<string>${exo.administration.portalConfig.metadata.importmode:insert}</string>

0 commit comments

Comments
 (0)