From ea9c7469bc6523c6d108b0da98aa327ec2d21f13 Mon Sep 17 00:00:00 2001 From: Mustafa Date: Wed, 22 Apr 2026 12:50:34 +0300 Subject: [PATCH 1/2] Change log level from warn to debug for successfully created missing block entities This message spams the logs in Hypixel. The else case already logs at error level; so logging it for the successful case would only bury the error case in the logs. I feel like debug log level would be apporiate here, which won't be logged by default at least on Fabric. I'm not sure if Forge still enables debug log level by default, please let me know. --- .../mixin/bugfix/missing_block_entities/LevelChunkMixin.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/embeddedt/modernfix/common/mixin/bugfix/missing_block_entities/LevelChunkMixin.java b/src/main/java/org/embeddedt/modernfix/common/mixin/bugfix/missing_block_entities/LevelChunkMixin.java index cbf784aa..82ce81a5 100644 --- a/src/main/java/org/embeddedt/modernfix/common/mixin/bugfix/missing_block_entities/LevelChunkMixin.java +++ b/src/main/java/org/embeddedt/modernfix/common/mixin/bugfix/missing_block_entities/LevelChunkMixin.java @@ -87,7 +87,7 @@ private void makeBlockEntityIfNotExists(BlockState state, BlockPos.MutableBlockP BlockEntity blockEntity = this.getBlockEntity(pos.immutable(), LevelChunk.EntityCreationType.IMMEDIATE); String blockName = state.getBlock().toString(); if (blockEntity != null) { - ModernFix.LOGGER.warn("Created missing block entity for {} at {}", blockName, pos.toShortString()); + ModernFix.LOGGER.debug("Created missing block entity for {} at {}", blockName, pos.toShortString()); } else { ModernFix.LOGGER.error("Block entity is missing for {} at {}, but could not be created", blockName, pos.toShortString()); } From 29fc4b3ac8aeb3cbbbf9a9b0da09201db9ffecfa Mon Sep 17 00:00:00 2001 From: Mustafa Date: Wed, 22 Apr 2026 12:57:32 +0300 Subject: [PATCH 2/2] Add isDebugEnabled check to not evaluate toShortString Slightly more performant if debug logging not enabled. Could also use a Supplier taking overload of the .debug method, but that incurs additional lambda object creation that would most likely neglect any performance gains from not evaluating the toShortString method. --- .../mixin/bugfix/missing_block_entities/LevelChunkMixin.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/embeddedt/modernfix/common/mixin/bugfix/missing_block_entities/LevelChunkMixin.java b/src/main/java/org/embeddedt/modernfix/common/mixin/bugfix/missing_block_entities/LevelChunkMixin.java index 82ce81a5..d35e0bbe 100644 --- a/src/main/java/org/embeddedt/modernfix/common/mixin/bugfix/missing_block_entities/LevelChunkMixin.java +++ b/src/main/java/org/embeddedt/modernfix/common/mixin/bugfix/missing_block_entities/LevelChunkMixin.java @@ -87,7 +87,9 @@ private void makeBlockEntityIfNotExists(BlockState state, BlockPos.MutableBlockP BlockEntity blockEntity = this.getBlockEntity(pos.immutable(), LevelChunk.EntityCreationType.IMMEDIATE); String blockName = state.getBlock().toString(); if (blockEntity != null) { - ModernFix.LOGGER.debug("Created missing block entity for {} at {}", blockName, pos.toShortString()); + if (ModernFix.LOGGER.isDebugEnabled()) { + ModernFix.LOGGER.debug("Created missing block entity for {} at {}", blockName, pos.toShortString()); + } } else { ModernFix.LOGGER.error("Block entity is missing for {} at {}, but could not be created", blockName, pos.toShortString()); }