Skip to content

Copilot/update dotnet10 skill requirements - #1357

Closed
alexjuv wants to merge 2 commits into
dotnet:mainfrom
alexjuv:copilot/update-dotnet10-skill-requirements
Closed

alexjuv wants to merge 2 commits into
dotnet:mainfrom
alexjuv:copilot/update-dotnet10-skill-requirements

Conversation

@alexjuv

@alexjuv alexjuv commented Oct 27, 2026 •

Copy link
Copy Markdown

Summary

Related issue

Validation

Checklist

  • I searched existing issues and pull requests to avoid duplicates.
  • I kept this pull request focused and avoided unrelated refactors.
  • I added or updated tests, evals, or documentation when changing skill or agent behavior.
  • I updated CODEOWNERS when adding or moving owned content.
  • I updated all marketplace manifests when plugin metadata changed.
  • I updated eng/known-domains.txt for any new external domains referenced by skill content.
Evaluation changes only

For every eval-related change, including a new eval:

  • Scenarios are necessary, distinct, and use natural prompts.
  • Graders cover the full result, accept the golden result, and reject a realistic mutation.
  • No-op, dormancy, and statistical power are covered where needed.
  • I ran the applicable production evaluation path and recorded the result above.
  • If this fixes a failed eval, I classified the failure before editing skill content.
  • If this broadly changes routing or behavior, I checked separate model-family evidence.

Copilot AI and others added 2 commits October 27, 2026 08:02
Co-authored-by: alexjuv <5081929+alexjuv@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 27, 2026 08:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused documentation changes are internally consistent and have no identified blocking issues.

No open issues 🎉

What changed in this PR

This PR clarifies Visual Studio requirements in the .NET 9-to-.NET 10 migration skill, distinguishing supported IDE builds from command-line builds.

Changes:

  • Adds Visual Studio 2026 (18.0+) compatibility checks to project assessment and build guidance.
  • Documents SDK loading versus supported framework targeting, command-line alternatives, and SLNX compatibility.
  • Clarifies that C# diagnostic version annotations do not define the IDE requirements for .NET 10.
File Description
plugins/​dotnet-upgrade/​skills/​migrate-dotnet9-to-dotnet10/​SKILL.md Adds IDE compatibility checks for developer and CI environments.
plugins/​dotnet-upgrade/​skills/​migrate-dotnet9-to-dotnet10/​references/​sdk-msbuild-dotnet9to10.md Explains Visual Studio support requirements and command-line alternatives.
plugins/​dotnet-upgrade/​skills/​migrate-dotnet9-to-dotnet10/​references/​csharp-compiler-dotnet9to10.md Distinguishes diagnostic versions from .NET 10 IDE requirements.

Review effort: Balanced

@alexjuv

alexjuv commented Oct 27, 2026

Copy link
Copy Markdown
Author

checked " Scenarios are necessary, distinct, and use natural prompts."

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused guidance changes consistently distinguish SDK and IDE support, with no unresolved review findings.

No open issues 🎉

Review effort: Balanced

@alexjuv

alexjuv commented Oct 27, 2026

Copy link
Copy Markdown
Author

@alexjuv alexjuv closed this Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants