Repository navigation
refactor: delete the old pr-triage, pr-workflow and standalone code review workflows - #647
Merged
Merged
Conversation
TheGreatAxios
marked this pull request as ready for review
October 26, 2026 22:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of CL-11525
Closes CL-11535
Why
Every pull request now runs through a host's listener and the managers it deploys, so the old pr-triage, pr-workflow and standalone code review workflows, and the tarball path that deployed them, are never used. This removes them, and the code that only existed to carry judge answers from one pr-triage run to the next.
What changed
pr-triage-github,pr-triage-bitbucket-datacenterandpr-triage-historicalentries, the standalonepr-code-review-githubandpr-code-review-bitbucket-datacenterentries, and the wholepr-workflow-anthropicpackage.pr-triagestays as a local definition: the policy check action, the evals, the extension and the tests run it. Thepr-code-review-reviewer-*workflows andtriage-judgeare unchanged.decide(), which only the PR workflow ran.judgedinput, the carried-answer lookup,reusable,MAX_JUDGED_BYTES,JudgedandjudgeKey.POST /api/integrations/workflow-deployroute and its OpenAPI entry, the package-registry asset it used, and the native-module fetch andpackages/index.jsonin the portal build.e2e/workflow-registry.tscheck andinstall-from-registry.tswent with it.TRIAGE_WORKFLOWS,CODE_REVIEW_WORKFLOWS,triageWorkflowOf,entrySource,PR_WORKFLOW_VARIANTS, the worker marker andworkerkind, andsameSource. The reconcilers now run per host.PrTriageRow.workflowVersion; a stored row that still has one loads without it. RemovedcreateVerdictRecordStore().record; tests seed rows throughreplaceVerdict.REPLACEDinapps/web/src/lib/triage-upgrade.tsstays, so Upgrade still cancels any old deployment that is live. A follow-up removes it once nothing old can still be running.tarballFilenamemoved from the contracts intotooling/pack-tarball.ts, its only user, andtriage-workflowsno longer declares an Interchange workflow entry.triage-runs.tsstays: held Dos and the audit log still read a run's verdict and approval from it.Verified
bun run checkclean.bun run linthas no new warnings; the one inmanifest.test.tsis an existing line this PR does not touch.origin/main: everything that runs locally passes exceptmax-files-changed, because the PR deletes whole packages (94 files, max 30).eval:hidden-content): 187/187 before, 187/187 after.bun run test: 1356 pass, 2 fail. Both came from one hook timeout inapps/hub/src/server.test.tswhile the machine was under heavy load; the file passes 11/11 on its own.bun run test:chain: 7/7.bun run check: no tsconfig covers them, and adding one surfaces 27 existing type errors across eight test files, so that is left for its own change.