refactor: drop the leftovers of the old workflow packages

Author: TheGreatAxios

apps/hub/src/audit-log.ts

@@ -35,10 +35,10 @@ const DO_OUTCOMES: Record<string, string> = { done: "Ran", satisfied: "Found don
 
 type Entry = Omit<AuditEntry, "time"> & { at: Date };
 
-/** `people` is whether the caller may read the workspace's principals, which emails and members need. */
 /** The reason the hub gave when it replaced a busy deployment with a fresh copy, which earlier entries carry. */
 export const ROTATION_REASON = "Replaced by a fresh deployment of the same workflow";
 
+/** `people` is whether the caller may read the workspace's principals, which emails and members need. */
 type Window = { tenantId: string; repo?: string; since?: Date; limit: number; people: boolean };
 
 export type AuditLogDeps = {

apps/hub/src/integrations/app.ts

@@ -636,7 +636,7 @@ export function createIntegrationsApp(guards: IntegrationGuards, handlers: Integ
     `${WORKFLOW_VERSIONS_PATH}/:tenantId`,
     describeRoute({
       summary: "Package versions of the workspace's live workflow deployments",
-      description: "Each live deployment, newest first, with the workflow package it pinned and the packages its frozen closure carries. `package` is null for a deployment not pinned from a package registry; `source` is the asset and commit a source-format deployment runs, else null.",
+      description: "Each live deployment, newest first, with the workflow package it pinned and the packages its frozen closure carries. `package` is null for a deployment without a frozen closure; `source` is the asset and commit a source-format deployment runs, else null.",
       tags: TAGS,
       responses: { 200: json("Live deployments and their versions", DeployedVersions), 401: failures[401], 403: failures[403] },
     }),

apps/web/src/components/settings/SupportVersions.tsx

@@ -12,7 +12,7 @@ function versionLine(deployments: readonly DeployedWorkflow[], sources: readonly
       parts.push(`${workflow} not deployed`);
       continue;
     }
-    parts.push(`${workflow} ${deployment.package?.version ?? "not from the package registry"}${deployment.live ? "" : " (not running)"}`);
+    parts.push(`${workflow} ${deployment.package?.version ?? "version unknown"}${deployment.live ? "" : " (not running)"}`);
     if (deployment.tools) for (const tool of deployment.tools) tools.add(`${tool.name} ${tool.version}`);
   }
   return [...parts, ...tools].join(" · ");

packages/triage-contracts/src/index.ts

@@ -21,7 +21,6 @@ export * from "./rule-prose.js";
 export * from "./step-when.js";
 export * from "./policy-rules.js";
 export { BLOCK_KINDS, blockCleanSchema, decideOf, kindsOf, policyWorkflowSchema, SEVERITIES, type BlockKind, type DecideRule, type PolicyWorkflow } from "./policy-workflow.js";
-export * from "./tarball.js";
 export * from "./code-review-models.js";
 export * from "./code-review.js";
 export * from "./stage-result.js";

packages/triage-contracts/src/policy-workflow.test.ts

@@ -1,7 +1,6 @@
 import { describe, expect, test } from "bun:test";
 import type { Type } from "arktype";
 import { readCheckPack } from "./check-pack.ts";
-import { decide } from "./decide.ts";
 import { exportPolicyFile, policyDifferences } from "./policy-export.ts";
 import { checkPolicyFile, readPolicyFile } from "./policy-file.ts";
 import { policyWorkflowSchema } from "./policy-workflow.ts";
@@ -95,11 +94,17 @@ describe("policy file v4", () => {
     });
   });
 
-  test("schema 3 actions beside a block that is on never approve or merge when every block was skipped", () => {
-    const checked = checkPolicyFile(`${RULES}code-review: { on: true }\nactions:\n  pass: [{ do: approve }, { do: merge }]\n`, REPO);
-    if (!checked.ok) throw new Error("the policy file must read");
-    const input = { triage: "pass", events: ["opened"], on: ["code-review"], outcomes: { "code-review": { outcome: "skipped" } }, author: ["everyone"] } as const;
-    expect(decide(checked.workflow!.decide!, input)).toEqual({ do: [{ do: "nothing" }, { do: "nothing" }], rule: 1 });
+  test("schema 3 actions beside a block that is on approve or merge only when every block is clean", () => {
+    expect(checkPolicyFile(`${RULES}code-review: { on: true }\nactions:\n  pass: [{ do: approve }, { do: merge }]\n`, REPO)).toMatchObject({
+      ok: true,
+      workflow: {
+        decide: [
+          { if: { triage: "pass", all: "clean" }, do: [{ do: "approve" }, { do: "merge" }] },
+          { if: { triage: "pass" }, do: [{ do: "nothing" }, { do: "nothing" }] },
+          { if: { triage: "fail" }, do: "nothing" },
+        ],
+      },
+    });
   });
 
   test("a file that extends another holds no v4 key, and reads with no decide", () => {

packages/triage-contracts/src/tarball.ts

@@ -7,11 +7,6 @@
     "./*": "./src/*.ts",
     "./evals/*": "./evals/*.ts"
   },
-  "interchange": {
-    "workflow": "./src/pr-triage.ts",
-    "directors": "./src/directors.ts",
-    "actions": "./src/actions/index.ts"
-  },
   "scripts": {
     "eval": "bun --conditions=intx-src evals/judge.eval.ts",
     "eval:scan": "bun --conditions=intx-src evals/scan.eval.ts",

packages/triage-workflows/package.json

@@ -81,7 +81,7 @@ interface Stamp {
   source?: PolicySource;
   repoSource: RepoSource;
   noWait: boolean;
-  /** The policy turns a block on, so `decide` chooses the Dos once the blocks have run. */
+  /** The mail names blocks, so the comment lists no Dos and approve and merge wait in Needs you. */
   blocksOn: boolean;
   /** The head the mail names for each pull request. */
   heads: Map<number, string>;

packages/triage-workflows/src/actions/facts.ts

@@ -20,7 +20,7 @@ export interface Item {
   repoSource?: RepoSource;
   /** The hub waits no longer for the host's checks. */
   noWait?: true;
-  /** The policy turns a block on, so `decide` chooses the Dos once the blocks have run and the comment names none. */
+  /** The mail names blocks, so the comment lists no Dos and approve and merge wait in Needs you. */
   blocksOn?: true;
   /** The App's bot account on GitHub, whose comments and reviews are triage's own. */
   appLogin?: string;

packages/triage-workflows/src/logic/item.ts

@@ -3,14 +3,18 @@ import { promises as fs } from "node:fs";
 import { tmpdir } from "node:os";
 import path from "node:path";
 import * as tar from "tar";
-import { tarballFilename } from "../packages/triage-contracts/src/tarball.js";
 
 // npm tarballs root every file under this directory.
 const STAGE = "package";
 
 type PackageManifest = { name: string; version: string } & Record<string, unknown>;
 export type PackedTarball = { name: string; version: string; filename: string; path: string; integrity: string };
 
+/** The file name `npm pack` gives a package version. */
+function tarballFilename(pkg: { name: string; version: string }): string {
+  return `${pkg.name.replace("/", "-")}-${pkg.version}.tgz`;
+}
+
 function byName(a: { name: string }, b: { name: string }): number {
   if (a.name < b.name) return -1;
   if (a.name > b.name) return 1;