Fix gutter failure dim, runner cycle, and stale row updates

Author: TheGreatAxios

scripts/budgets.json

@@ -272,5 +272,7 @@
   "src/tui/width-contract.ts": 71,
   "src/tui/workflow-controller.ts": 271,
   "src/tui/workspace-watch.test.ts": 101,
-  "src/tui/workspace-watch.ts": 62
+  "src/tui/workspace-watch.ts": 62,
+  "src/tui/row-retext.test.ts": 76,
+  "src/tui/runner/send-failure-message.ts": 38
 }

src/tui/row-retext.test.ts

@@ -0,0 +1,75 @@
+/**
+ * In-place retext keeps a row's paint node when only its state flips — most
+ * importantly the gutter voice: a tool row that fails after being painted
+ * pending must dim its gutter on the same node, not keep the live bronze.
+ */
+import { describe, expect, test } from "bun:test";
+import {
+  BoxRenderable,
+  TextRenderable,
+  parseColor,
+  rgbToHex,
+  type ColorInput,
+} from "@opentui/core";
+import { withTestRenderer } from "./harness";
+import { appendStreamRow, replaceStreamRowAt } from "./shell/chrome";
+import { createAppShell } from "./shell/index";
+import { transcriptRowChildren } from "./shell/transcript";
+import { UI } from "./theme";
+import { pushToolCall, pushToolResult } from "./tool-rows";
+import type { StreamRow } from "./stream";
+
+const SHELL_OPTS = {
+  terminal: { columns: 100, rows: 24 },
+  wireKeys: false,
+  run: "idle",
+} as const;
+
+const gutterOf = (node: unknown): TextRenderable => {
+  if (!(node instanceof BoxRenderable)) throw new Error("row node is not a wrapper");
+  const [gutter] = node.getChildren();
+  if (!(gutter instanceof TextRenderable)) throw new Error("first child is not the gutter");
+  return gutter;
+};
+
+/** The node normalizes fg to an RGBA; compare it to the hex token exactly. */
+const fgIs = (gutter: TextRenderable, hex: string): boolean =>
+  rgbToHex(parseColor(gutter.fg as ColorInput)) === hex;
+
+describe("retext gutter voice", () => {
+  test("a tool row that fails after being painted pending dims its gutter in place", async () => {
+    await withTestRenderer(
+      async (h) => {
+        const shell = createAppShell(h.renderer, SHELL_OPTS);
+        try {
+          const rows: StreamRow[] = [];
+          pushToolCall(rows, {
+            name: "fetch",
+            arguments: JSON.stringify({ url: "https://x.dev" }),
+          });
+          const pending = rows[0]!;
+          expect(pending.pending).toBe(true);
+          appendStreamRow(shell, pending);
+          await h.renderOnce();
+          const wrapper = transcriptRowChildren(shell)[0];
+          const gutter = gutterOf(wrapper);
+          const fgToken = `${gutter.fg}`;
+          expect(fgToken).not.toBe(UI.textDim);
+          expect(fgIs(gutter, UI.textDim)).toBe(false);
+
+          pushToolResult(rows, { name: "fetch", content: "", isError: true });
+          const failed = rows[0]!;
+          expect(failed.failed).toBe(true);
+          replaceStreamRowAt(shell, 0, failed);
+          // Same paint node, same shape: the flip retexted rather than rebuilt.
+          expect(transcriptRowChildren(shell)[0]).toBe(wrapper);
+          expect(fgIs(gutter, UI.textDim)).toBe(true);
+          await h.renderOnce();
+        } finally {
+          shell.dispose();
+        }
+      },
+      { width: 100, height: 24 },
+    );
+  });
+});

src/tui/runner/commands.ts

@@ -1,7 +1,6 @@
 /**
  * Command layer for the TUI runner: slash-command registry population, the
- * command context the handlers run against, result surfacing, and the
- * inference-failure message contract shared by the submit path.
+ * command context the handlers run against, and result surfacing.
  */
 
 import { getLogger } from "@intx/log";
@@ -34,43 +33,14 @@ import { renameSession } from "../../session/index.js";
 import { truncateSessionLabel } from "../../session/session-label.js";
 import { surfaceSystemNotice, attachClipboardImage } from "../shell/prompt.js";
 import type { InferenceErrorLike } from "../../inference-gateway-error.js";
-import {
-  CREDENTIAL_FAILURE_USER_MESSAGE,
-  isResolvedProviderFailureError,
-  terminalProviderFailureMessage,
-} from "../../inference-error-message.js";
+import { terminalProviderFailureMessage } from "../../inference-error-message.js";
 import type { InferenceAttemptIdentity } from "./state.js";
 import { hostOf, type RunnerServices, type RunnerState } from "./state.js";
 import { userInboundMessage } from "./submit.js";
 import { LOG_NAMESPACE_ROOT } from "../../branding.js";
 
 const tuiLogger = getLogger([LOG_NAMESPACE_ROOT, "tui"]);
 
-export function tuiSendFailureMessage(
-  error: unknown,
-  failureKind: "auth" | "error",
-  providerFailureObserved: boolean,
-  attempt: InferenceAttemptIdentity,
-  providerError?: InferenceErrorLike,
-): string {
-  if (failureKind === "auth") {
-    return CREDENTIAL_FAILURE_USER_MESSAGE;
-  }
-  if (!providerFailureObserved && !isResolvedProviderFailureError(error)) {
-    return error instanceof Error ? error.message : String(error);
-  }
-  const providerId =
-    providerError?.providerId ??
-    (isResolvedProviderFailureError(error) ? error.providerId : attempt.providerId);
-  const displayLabel = providerId === attempt.providerId ? attempt.displayLabel : undefined;
-  if (providerError === undefined && isResolvedProviderFailureError(error)) return error.message;
-  const diagnostic = providerError ?? {
-    category: "fatal",
-    message: error instanceof Error ? error.message : String(error),
-  };
-  return terminalProviderFailureMessage(providerId, diagnostic, displayLabel);
-}
-
 export function surfaceTerminalProviderFailure(
   shell: Parameters<typeof surfaceSystemNotice>[0],
   providerId: string,

src/tui/runner/send-failure-message.ts

@@ -0,0 +1,37 @@
+/**
+ * The operator-facing message for a rejected send (the inference-failure
+ * contract the submit path reports through). Lives in its own leaf so the
+ * submit and commands siblings never import each other.
+ */
+import type { InferenceErrorLike } from "../../inference-gateway-error.js";
+import {
+  CREDENTIAL_FAILURE_USER_MESSAGE,
+  isResolvedProviderFailureError,
+  terminalProviderFailureMessage,
+} from "../../inference-error-message.js";
+import type { InferenceAttemptIdentity } from "./state.js";
+
+export function tuiSendFailureMessage(
+  error: unknown,
+  failureKind: "auth" | "error",
+  providerFailureObserved: boolean,
+  attempt: InferenceAttemptIdentity,
+  providerError?: InferenceErrorLike,
+): string {
+  if (failureKind === "auth") {
+    return CREDENTIAL_FAILURE_USER_MESSAGE;
+  }
+  if (!providerFailureObserved && !isResolvedProviderFailureError(error)) {
+    return error instanceof Error ? error.message : String(error);
+  }
+  const providerId =
+    providerError?.providerId ??
+    (isResolvedProviderFailureError(error) ? error.providerId : attempt.providerId);
+  const displayLabel = providerId === attempt.providerId ? attempt.displayLabel : undefined;
+  if (providerError === undefined && isResolvedProviderFailureError(error)) return error.message;
+  const diagnostic = providerError ?? {
+    category: "fatal",
+    message: error instanceof Error ? error.message : String(error),
+  };
+  return terminalProviderFailureMessage(providerId, diagnostic, displayLabel);
+}

src/tui/runner/submit.ts

@@ -34,7 +34,7 @@ import {
   routeQueuedDelivery,
 } from "../queued-delivery.js";
 import type { InferenceAttemptIdentity } from "./state.js";
-import { tuiSendFailureMessage } from "./commands.js";
+import { tuiSendFailureMessage } from "./send-failure-message.js";
 import type { ProviderFailureAttempt } from "../provider/failure-attempt.js";
 import type { Agent } from "@intx/agent";
 import { hostOf, type RunnerServices, type RunnerState } from "./state.js";

src/tui/runtime-bridge.ts

@@ -1328,12 +1328,12 @@ export function attachSessionBridge(
     bag.turn = turnStateOnInterrupt(bag.turn, now());
     paintPhase();
   };
-
   const clearQueuedDelivery = (): void => {
     if (bag.disposed) return;
     shell.session = createSessionQueue("idle");
     bag.pendingEchoes.length = 0;
     bag.liveFleet = 0;
+    bag.pendingRowUpdates.clear();
     paintChrome(shell);
   };
 

src/tui/shell/row-retext.ts

@@ -72,9 +72,9 @@ export function retextStyledKindRow(
   return false;
 }
 
-/** Rewrite the gutter a styled-lines or structured wrapper carries. */
 function retextGutter(node: TextRenderable, gutter: PaintedStreamLine): void {
   node.content = gutter.content;
+  node.fg = gutter.fg;
   node.width = stringWidth(gutter.content);
 }
 

tests/unit/tui/runner.test.ts

@@ -8,7 +8,7 @@ import {
 } from "../../../src/tui/runner/exit.js";
 import { createTUIEventEmitter, getTUIRunSummaryStatus } from "../../../src/tui/runner/index.js";
 import { loadLocalSettingsWriteBase } from "../../../src/tui/runner/settings.js";
-import { tuiSendFailureMessage } from "../../../src/tui/runner/commands.js";
+import { tuiSendFailureMessage } from "../../../src/tui/runner/send-failure-message.js";
 import { createSessionOperationQueue } from "../../../src/tui/session-operation-queue.js";
 import { createRunSink } from "../../../src/session/run-sink.js";