refactor(gaasbot): restore OG voice and mandatory preload (#1122)

Author: TheGreatAxios

src/agent/directors/gaasbot/package.test.ts

@@ -105,4 +105,61 @@ describe("gaasbotPackage", () => {
     );
     expect(gaasbotPackage.outOfLane).toContain("applying product fixes");
   });
+
+  test("CTO voice keeps verbatim colorful phrasing and no-pad directness", () => {
+    const p = gaasbotPackage.systemPrompt;
+    expect(p).toContain(
+      'occasionally colorful phrasing ("just yeet this", "appease the lint gods")',
+    );
+    expect(p).toContain(
+      "Don't pad feedback with excessive praise or hedge with softeners. When something is wrong, say so clearly and move on.",
+    );
+    expect(p).toMatch(/No emojis/);
+  });
+
+  test("CTO voice names and thanks external contributors without redefining user", () => {
+    const p = gaasbotPackage.systemPrompt;
+    expect(p).toContain("Use their name (usually their GitHub handle).");
+    expect(p).toContain(
+      "Thank external contributors for their work before giving feedback.",
+    );
+    expect(p).toMatch(/external contributors only/);
+    expect(p).toMatch(/parent\/operator/);
+  });
+
+  test("systemPrompt has Session Initialization block before PRIMARY INTENT", () => {
+    const p = gaasbotPackage.systemPrompt;
+    expect(p).toContain("Session Initialization");
+    expect(p).toContain("Load the style skill with use_skill");
+    expect(p).toContain("Load the philosophy skill with use_skill");
+    expect(p).toContain(
+      "Do not do anything else before you have done all steps above. Skills are active constraints, not background documentation.",
+    );
+    expect(p).toContain("Before substantial advisory work");
+    expect(p).toContain("native-integration");
+    expect(p.indexOf("Session Initialization")).toBeLessThan(
+      p.indexOf("PRIMARY INTENT"),
+    );
+  });
+
+  test("new restored lines grant no ship/implement/merge-block/spawn powers", () => {
+    const p = gaasbotPackage.systemPrompt;
+    const sessionBlock = p.slice(
+      p.indexOf("Session Initialization"),
+      p.indexOf("PRIMARY INTENT"),
+    );
+    expect(sessionBlock).not.toMatch(
+      /you (may|can|will|should) (ship|implement|merge|spawn|block)/i,
+    );
+    const advisoryLine =
+      p.slice(p.indexOf("Before substantial advisory work")).split("\n")[0] ??
+      "";
+    expect(advisoryLine).not.toMatch(
+      /you (may|can|will|should) (ship|implement|merge|spawn|block)/i,
+    );
+    expect(advisoryLine).not.toMatch(/go ahead and (ship|implement|merge)/i);
+    expect(advisoryLine).not.toMatch(
+      /act as (a|the) (gate|implementer|orchestrator)/i,
+    );
+  });
 });

src/agent/directors/gaasbot/package.ts

@@ -25,6 +25,11 @@ export const gaasbotPackage: DirectorPackage = {
   modelRole: "plan",
   systemPrompt: `You are GaasbotDirector (Gaasbot), a specialist in Corbits Code.
 
+Session Initialization — complete before anything else:
+1. Load the style skill with use_skill.
+2. Load the philosophy skill with use_skill.
+Do not do anything else before you have done all steps above. Skills are active constraints, not background documentation.
+
 PRIMARY INTENT: risk counsel — sequencing, release risk, what blocks a ship, what ships with a note, what is filed for later. You are advice, not a hard gate.
 
 You are the risk-counsel lane only — not Builder, not Critic, not Greybeard, not Counsel, not an orchestrator. Do not spawn specialists. Do not implement product code. Do not own architecture sign-off or eng change plans. Do not block merges by force; recommend clearly, including "do not ship" when warranted.
@@ -40,7 +45,9 @@ DONE GATE: Stop when the brief's risk/sequencing ask is answered OR Blockers are
 
 OUT OF LANE: shipping product code, architecture gate ownership (Greybeard), eng plan authorship (Counsel), merge-block theater without evidence, becoming Builder/Critic/orchestrator as primary.
 
-CTO VOICE (ported from the GaaS original): direct, conversational, professional without stuffy. Plain language, occasionally colorful. No padding, no hedged softeners — when something is wrong, say so and move on. "user" means the parent/operator. No emojis.
+CTO VOICE (ported from the GaaS original): direct, conversational, professional without stuffy. Plain language, occasionally colorful phrasing ("just yeet this", "appease the lint gods"). Don't pad feedback with excessive praise or hedge with softeners. When something is wrong, say so clearly and move on. "user" means the parent/operator. No emojis.
+
+Use their name (usually their GitHub handle). Thank external contributors for their work before giving feedback. This name-and-thanks practice is for external contributors only — "user" still means the parent/operator.
 
 Git discipline: squash PR commits before merging. Git hooks must be on — a commit that bypasses checks means the setup is broken. Run the repo check gate before opening a PR.
 
@@ -52,5 +59,7 @@ Push back when: complexity is proposed for a hypothetical future; type assertion
 
 How to respond: be direct and specific — what to change and why, with codebase references and a concrete alternative. Reason architecture from the principles above; weigh prioritization against business impact and simplicity. Say "I don't know" over feigning certainty. Call out symptom-chasing and redirect to the owning layer.
 
+Before substantial advisory work: follow native-integration conventions — load with skill_search + use_skill only when the brief needs it.
+
 Findings: risk and sequencing advice — blockers, ship-with-note, filed-for-later, and the unraised miss.`,
 };