Add tsc --noEmit to CI; fix type errors it revealed

Adds TypeScript type-checking to CI alongside biome. Bun's test runner
is more lenient about types than tsc, so this catches issues in files
not reached by tests. Fixes the errors tsc revealed:

- config-validate.ts: remove unused DeepPartial import, delete dead
  validateToolbar/validateDrawer functions (superseded by the Overrides
  and Resolved variants)
- controls/help.ts: add noUncheckedIndexedAccess guard for groups[0]
- index.ts: remove redundant 'import type { UISlot }' — the re-export
  below handles it directly via 'from' syntax
- serve.ts: cast Uint8Array/Buffer to BodyInit via unknown for Bun
  Response constructor compatibility; same pattern as terminal.ts
- tests/e2e/smoke.test.ts: server.port is number | undefined per
  bun-types, add ?? 0 fallback
- tests/hooks.test.ts: beforeSendData handler must return
  BeforeSendDataResult | undefined, not void; add explicit return
- tests/plugins-manager.test.ts: remove unused btn helper

Also adds CI + npm + licence badges to README.

Author: connorads

.github/workflows/ci.yml

@@ -15,3 +15,4 @@ jobs:
       - run: bun install
       - run: bun test
       - run: bun run check
+      - run: bunx tsc --noEmit

README.md

@@ -1,5 +1,9 @@
 # webmux
 
+[![CI](https://github.com/connorads/webmux/actions/workflows/ci.yml/badge.svg)](https://github.com/connorads/webmux/actions/workflows/ci.yml)
+[![npm](https://img.shields.io/npm/v/webmux)](https://www.npmjs.com/package/webmux)
+[![licence](https://img.shields.io/npm/l/webmux)](LICENSE)
+
 Mobile-friendly terminal overlay for [ttyd](https://github.com/tsl0922/ttyd) + [tmux](https://github.com/tmux/tmux).
 
 Turns a ttyd web terminal into a touch-optimised tmux client with toolbar, gesture support, and a command drawer. Produces a single `index.html` for `ttyd --index`.

src/config-validate.ts

@@ -1,4 +1,4 @@
-import type { DeepPartial, WebmuxConfig, WebmuxConfigOverrides } from './types'
+import type { WebmuxConfig, WebmuxConfigOverrides } from './types'
 
 interface ValidationIssue {
 	readonly path: string
@@ -464,22 +464,6 @@ function validateFont(value: unknown, path: string, issues: ValidationIssue[]):
 	}
 }
 
-function validateToolbar(value: unknown, path: string, issues: ValidationIssue[]): void {
-	if (!isRecord(value)) {
-		pushIssue(issues, path, 'object', value)
-		return
-	}
-
-	checkUnknownKeys(value, TOOLBAR_KEYS, path, issues)
-
-	if ('row1' in value && value.row1 !== undefined) {
-		validateButtonsArray(value.row1, `${path}.row1`, issues)
-	}
-	if ('row2' in value && value.row2 !== undefined) {
-		validateButtonsArray(value.row2, `${path}.row2`, issues)
-	}
-}
-
 function validateToolbarOverrides(value: unknown, path: string, issues: ValidationIssue[]): void {
 	if (!isRecord(value)) {
 		pushIssue(issues, path, 'object', value)
@@ -538,19 +522,6 @@ function validateDrawerOverrides(value: unknown, path: string, issues: Validatio
 	}
 }
 
-function validateDrawer(value: unknown, path: string, issues: ValidationIssue[]): void {
-	if (!isRecord(value)) {
-		pushIssue(issues, path, 'object', value)
-		return
-	}
-
-	checkUnknownKeys(value, DRAWER_KEYS, path, issues)
-
-	if ('buttons' in value && value.buttons !== undefined) {
-		validateButtonsArray(value.buttons, `${path}.buttons`, issues)
-	}
-}
-
 function validateGestures(value: unknown, path: string, issues: ValidationIssue[]): void {
 	if (!isRecord(value)) {
 		pushIssue(issues, path, 'object', value)

src/controls/help.ts

@@ -85,7 +85,7 @@ function buildHelpContent(config: WebmuxConfig): string {
 
 	if (config.floatingButtons.length > 0) {
 		const groups: readonly FloatingButtonGroup[] = config.floatingButtons
-		if (groups.length === 1) {
+		if (groups.length === 1 && groups[0] !== undefined) {
 			sections.push(renderButtonTable('Floating Buttons', groups[0].buttons))
 		} else {
 			for (const group of groups) {

src/index.ts

@@ -15,7 +15,6 @@ import type { HookRegistry } from './hooks/registry'
 import { createPluginManager } from './plugins/manager'
 import type { WebmuxPlugin } from './plugins/manager'
 import { createUIContributionCollector } from './plugins/ui-contributions'
-import type { UISlot } from './plugins/ui-contributions'
 import { applyTheme } from './theme/apply'
 import { createToolbar } from './toolbar/toolbar'
 import type { WebmuxConfig } from './types'

src/serve.ts

@@ -122,19 +122,19 @@ export async function serve(
 			}
 
 			if (url.pathname === '/apple-touch-icon.png' && icon180) {
-				return new Response(icon180, {
+				return new Response(icon180 as unknown as BodyInit, {
 					headers: { 'content-type': 'image/png' },
 				})
 			}
 
 			if (url.pathname === '/icon-192.png' && icon192) {
-				return new Response(icon192, {
+				return new Response(icon192 as unknown as BodyInit, {
 					headers: { 'content-type': 'image/png' },
 				})
 			}
 
 			if (url.pathname === '/icon-512.png' && icon512) {
-				return new Response(icon512, {
+				return new Response(icon512 as unknown as BodyInit, {
 					headers: { 'content-type': 'image/png' },
 				})
 			}
@@ -181,7 +181,9 @@ export async function serve(
 				if (backend !== null && backend.readyState === WebSocket.OPEN) {
 					backend.send(data)
 				} else {
-					buffer.push(typeof data === 'string' ? data : new Uint8Array(data as ArrayBuffer))
+					buffer.push(
+						typeof data === 'string' ? data : new Uint8Array(data as unknown as ArrayBuffer),
+					)
 				}
 			},
 			close(ws) {

tests/e2e/smoke.test.ts

@@ -23,7 +23,7 @@ async function ttydAvailable(): Promise<boolean> {
 /** Find a free port in the ephemeral range */
 async function findFreePort(): Promise<number> {
 	const server = Bun.serve({ port: 0, fetch: () => new Response('') })
-	const port = server.port
+	const port = server.port ?? 0
 	await server.stop()
 	return port
 }

tests/hooks.test.ts

@@ -64,6 +64,7 @@ describe('hook registry', () => {
 		const sources: string[] = []
 		hooks.on('beforeSendData', (ctx) => {
 			sources.push(ctx.source)
+			return undefined
 		})
 
 		await hooks.runBeforeSendData({

tests/plugins-manager.test.ts

@@ -4,7 +4,7 @@ import { defaultConfig } from '../src/config'
 import { createHookRegistry } from '../src/hooks/registry'
 import { createPluginManager } from '../src/plugins/manager'
 import { createUIContributionCollector } from '../src/plugins/ui-contributions'
-import type { ControlButton, XTerminal } from '../src/types'
+import type { XTerminal } from '../src/types'
 
 function mockTerminal(): XTerminal {
 	return {
@@ -17,10 +17,6 @@ function mockTerminal(): XTerminal {
 	}
 }
 
-function btn(id: string): ControlButton {
-	return { id, label: id, description: id, action: { type: 'send', data: id } }
-}
-
 describe('createPluginManager', () => {
 	test('runs plugin setup in order', async () => {
 		const order: string[] = []