Merge #149: Clippy: Doesn't block CI runs on warnings

Approved-by: ReinierMaas
Priority: Normal
Auto-deploy: false

Author: OpsBotPrime

Cargo.toml

@@ -12,20 +12,20 @@ members = [
 version = "0.36.0"
 
 [workspace.lints.clippy]
-cargo =  { level = "warn", priority = -1 }
+cargo = { level = "deny", priority = -1 }
 cargo_common_metadata = "allow"
 
-complexity = { level = "warn", priority = -1 }
+complexity = { level = "deny", priority = -1 }
 correctness = { level = "deny", priority = -1 }
 # nursery, new untested lints
 nursery = { level = "allow", priority = -1 }
 
-pedantic = { level = "warn", priority = -1 }
-perf = { level = "warn", priority = -1 }
+pedantic = { level = "deny", priority = -1 }
+perf = { level = "deny", priority = -1 }
 # restriction, lints that can enforce a coherent code style
 restriction = { level = "allow", priority = -1 }
-style = { level = "warn", priority = -1 }
-suspicious = { level = "warn", priority = -1 }
+style = { level = "deny", priority = -1 }
+suspicious = { level = "deny", priority = -1 }
 
 # Prevent duplicate versions of crates from being used in the workspace. If an easy fix is not
 # possible, you can add the crate to the `allowed-duplicate-crates` list in `clippy.toml`.

clippy.toml

@@ -12,6 +12,8 @@ allowed-duplicate-crates = [
     "sha2",
     "syn",
     "thiserror",
+    "tokio-tungstenite",
     "tower-http",
+    "tungstenite",
     "windows-sys",
 ]

justfile

@@ -83,14 +83,19 @@ lint-light *ARGS:
 [group('lint')]
 lint-heavy: clippy mypy
 
+# Rust static analysis
+[group('lint')]
+clippy-fix:
+  # `cargo clippy --fix` caps lints to warnings internally; keep its artifacts separate.
+  CARGO_TARGET_DIR=target/clippy-fix cargo clippy --no-deps --all-targets --fix --allow-dirty --allow-staged -- -Dwarnings
+  CARGO_TARGET_DIR=target/clippy-fix cargo clippy --no-deps --all-targets --no-default-features --fix --allow-dirty --allow-staged -- -Dwarnings
+  CARGO_TARGET_DIR=target/clippy-fix cargo clippy --no-deps --all-targets --all-features --fix --allow-dirty --allow-staged -- -Dwarnings
+
 # Rust static analysis
 [group('lint')]
 clippy:
-  cargo clippy --no-deps --all-targets --fix --allow-dirty --allow-staged -- -Dwarnings
   cargo clippy --no-deps --all-targets -- -Dwarnings
-  cargo clippy --no-deps --all-targets --no-default-features --fix --allow-dirty --allow-staged -- -Dwarnings
   cargo clippy --no-deps --all-targets --no-default-features -- -Dwarnings
-  cargo clippy --no-deps --all-targets --all-features --fix --allow-dirty --allow-staged -- -Dwarnings
   cargo clippy --no-deps --all-targets --all-features -- -Dwarnings
 
 # Python static analysis type-checker