fixup! Break ties of PreferDistinct submissions with equal counts

Move check to top

Author: jerbaroo

opsqueue/src/consumer/strategy.rs

@@ -120,6 +120,9 @@ impl Strategy {
             PreferDistinct { .. } => {
                 let mut meta_keys_iter = self.meta_keys();
                 let meta_keys: Vec<&str> = meta_keys_iter.by_ref().collect();
+                if meta_keys.is_empty() {
+                    panic!("`PreferDistinct` always yields at least one meta key.")
+                }
                 let underlying = meta_keys_iter.take();
 
                 // Unique submission IDs from the underlying strategy. Note how
@@ -166,15 +169,9 @@ impl Strategy {
                     qb.push(format!("counts_{i}.count ASC NULLS FIRST"));
                 }
 
-                if meta_keys.is_empty() {
-                    panic!("`PreferDistinct` always yields at least one meta key.")
-                } else {
-                    // Ensure that submissions with equal metadata counts use the
-                    // ordering of the underlying strategy as a tie-breaker.
-                    qb.push(", inner.underlying_row ASC");
-                }
-
-                qb
+                // Ensure that submissions with equal metadata counts use the
+                // ordering of the underlying strategy as a tie-breaker.
+                qb.push(", inner.underlying_row ASC")
             }
         }
     }