From e8ad493e37c30bac9d501aa8ffd46ccb5a3475cb Mon Sep 17 00:00:00 2001 From: Lennart Oldenburg Date: Wed, 25 Feb 2026 14:32:45 +0100 Subject: [PATCH 1/3] Make mount_point argument positional in examples/simple.rs --- examples/simple.rs | 2 -- 1 file changed, 2 deletions(-) diff --git a/examples/simple.rs b/examples/simple.rs index 7e575954..3f09f5bd 100644 --- a/examples/simple.rs +++ b/examples/simple.rs @@ -73,9 +73,7 @@ struct Args { #[clap(long, default_value = "/tmp/fuser")] data_dir: String, - // TODO: make positional like other examples. /// Act as a client, and mount FUSE at given path - #[clap(long, default_value = "")] mount_point: String, /// Mount FUSE with direct IO From 3889de325d0847384c818e5a5f9d1af3535c02ce Mon Sep 17 00:00:00 2001 From: Lennart Oldenburg Date: Wed, 25 Feb 2026 15:17:21 +0100 Subject: [PATCH 2/3] Removed use of '--mount-point' argument with example 'simple' from tests. --- fuser-tests/src/commands/mount.rs | 2 +- fuser-tests/src/commands/simple.rs | 1 - fuser-tests/src/experimental.rs | 2 +- tests/bsd_pjdfs.sh | 2 +- tests/macos_pjdfs.sh | 2 +- 5 files changed, 4 insertions(+), 5 deletions(-) diff --git a/fuser-tests/src/commands/mount.rs b/fuser-tests/src/commands/mount.rs index 6bf7f6e8..8dbbec4d 100644 --- a/fuser-tests/src/commands/mount.rs +++ b/fuser-tests/src/commands/mount.rs @@ -244,7 +244,7 @@ async fn test_no_user_allow_other(features: &[Feature], libfuse: &Libfuse) -> an // Run the simple example as fusertestnoallow let run_command = format!( - "{} --auto-unmount -vvv --data-dir {} --mount-point {}", + "{} --auto-unmount -vvv --data-dir {} {}", simple_exe.display(), data_dir.path().display(), mount_dir.path().display() diff --git a/fuser-tests/src/commands/simple.rs b/fuser-tests/src/commands/simple.rs index 4cfc7514..83ecb5f4 100644 --- a/fuser-tests/src/commands/simple.rs +++ b/fuser-tests/src/commands/simple.rs @@ -32,7 +32,6 @@ pub(crate) async fn run_simple_tests() -> anyhow::Result<()> { "-vvv", "--data-dir", data_dir.path().to_str().unwrap(), - "--mount-point", mount_dir.path().to_str().unwrap(), ]) .env(Fusermount::ENV_VAR, Fusermount::False.as_path()) diff --git a/fuser-tests/src/experimental.rs b/fuser-tests/src/experimental.rs index 58f9c0de..dabc7f77 100644 --- a/fuser-tests/src/experimental.rs +++ b/fuser-tests/src/experimental.rs @@ -158,7 +158,7 @@ async fn test_no_user_allow_other(features: &[Feature], libfuse: &Libfuse) -> an // Run the simple example as fusertestnoallow let run_command = format!( - "{} --auto-unmount -vvv --data-dir {} --mount-point {}", + "{} --auto-unmount -vvv --data-dir {} {}", simple_exe.display(), data_dir.path().display(), mount_dir.path().display() diff --git a/tests/bsd_pjdfs.sh b/tests/bsd_pjdfs.sh index f60214af..8ff8f0ab 100755 --- a/tests/bsd_pjdfs.sh +++ b/tests/bsd_pjdfs.sh @@ -18,7 +18,7 @@ DATA_DIR=$(mktemp --directory) DIR=$(mktemp --directory) cargo build --release --example simple -cargo run --release --example simple -- -vvv --suid --data-dir $DATA_DIR --mount-point $DIR > /tmp/mount.log 2>&1 & +cargo run --release --example simple -- -vvv --suid --data-dir $DATA_DIR $DIR > /tmp/mount.log 2>&1 & FUSE_PID=$! sleep 0.5 diff --git a/tests/macos_pjdfs.sh b/tests/macos_pjdfs.sh index 8eb0876c..929342fa 100755 --- a/tests/macos_pjdfs.sh +++ b/tests/macos_pjdfs.sh @@ -31,7 +31,7 @@ DATA_DIR=$(mktemp --directory) DIR=$(mktemp --directory) cargo build --release --example simple -cargo run --release --example simple -- -vvv --suid --data-dir $DATA_DIR --mount-point $DIR > /tmp/mount.log 2>&1 & +cargo run --release --example simple -- -vvv --suid --data-dir $DATA_DIR $DIR > /tmp/mount.log 2>&1 & FUSE_PID=$! sleep 0.5 From 0b7c1e3b023c08cca00c696889f064563d8efaa1 Mon Sep 17 00:00:00 2001 From: Lennart Oldenburg Date: Thu, 26 Feb 2026 10:34:40 +0100 Subject: [PATCH 3/3] Make 'mount_point' argument positional for 'examples/simple.rs', adjusted scripts and tests accordingly. --- pjdfs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pjdfs.sh b/pjdfs.sh index 845355c7..3c1a4a1f 100755 --- a/pjdfs.sh +++ b/pjdfs.sh @@ -13,7 +13,7 @@ export RUST_BACKTRACE=1 DATA_DIR=$(mktemp --directory) DIR=$(mktemp --directory) -fuser -vvv --auto-unmount --suid --data-dir $DATA_DIR --mount-point $DIR > /code/logs/mount.log 2>&1 & +fuser -vvv --auto-unmount --suid --data-dir $DATA_DIR $DIR > /code/logs/mount.log 2>&1 & FUSE_PID=$! sleep 0.5