Gate on the dev build, not just the production one (#387)

* ci(website): gate on the dev build, not just the production one

Closes the follow-up left open by #385.

Every website spec runs against `next start`. A production build does not
double-invoke effects, so nothing in CI ever exercised the build a contributor
opens — which is how a homepage that rendered NO grid under StrictMode survived
from #321 to #383 with the suite 100/100 green the entire time.

The `dev-smoke` job starts a real `next dev` and runs `dev-mode.spec.ts` against
it. It builds the packages first, because the website imports them from `dist`
and a dev server is only as honest as the last build.

The spec skipped itself when `PRETABLE_DEV_URL` was unset, which is right
locally and would be a disaster as a gate: a job that reports success for
running nothing is the same silence this spec exists to end. In CI the variable
is the job's responsibility, so its absence now fails with the reason instead of
skipping. Verified both directions — `CI=1` without the URL fails, a local run
without it still skips.

On failure the job keeps the dev server's own log, not just the trace: a compile
error reaches Playwright as a blank page, and the log is where it says why.

Verified by running the job's exact sequence locally — build, start, wait, smoke
— 2 passed against a real dev server.

Note this narrows the blind spot rather than removing it: the job runs one
browser against two pages. It catches lifecycle faults of the class that hid
here, not everything a production-only suite misses.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* fix(ci): key the dev-smoke guard to the job, not to CI

The anti-vacuum guard added in the previous commit keyed on `CI`, so it fired in
every CI job that runs this directory — including the production and preview
smokes, which have no dev server by design and legitimately skip these tests. It
failed the required preview-smoke check twice on this PR's own first run.

Keyed on `PRETABLE_DEV_SMOKE` instead, which only the dev-smoke job sets. The
property that matters is unchanged: the one job whose purpose is smoking a dev
server refuses to skip its way to green.

Verified all three paths: whole-directory run under `CI` skips, dev-smoke intent
without a URL fails, dev-smoke with a URL passes.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Author: blove

.github/workflows/ci.yml

@@ -112,6 +112,64 @@ jobs:
       - run: pnpm install --frozen-lockfile
       - run: pnpm build
 
+  dev-smoke:
+    name: Dev build — grid renders under StrictMode
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v7
+      - uses: pnpm/action-setup@v6
+      - uses: actions/setup-node@v7
+        with:
+          node-version: 22
+          cache: pnpm
+      - run: pnpm install --frozen-lockfile
+      # The website imports the packages from `dist`, so a dev server is only
+      # as honest as the last build.
+      - run: pnpm build
+      - run: pnpm exec playwright install --with-deps chromium
+      # Every other website spec runs against `next start`. A production build
+      # does not double-invoke effects, which is why a homepage that rendered NO
+      # grid under StrictMode survived from #321 to #383 with the suite green.
+      # This job is the one that runs the build a contributor actually sees.
+      - name: Start the dev server
+        run: |
+          pnpm --filter @pretable/app-website exec next dev -p 3100 \
+            > /tmp/next-dev.log 2>&1 &
+          for i in $(seq 1 60); do
+            if curl -sSf -o /dev/null http://localhost:3100/; then
+              echo "dev server up after ${i}s"
+              exit 0
+            fi
+            sleep 1
+          done
+          echo "dev server never responded"
+          cat /tmp/next-dev.log
+          exit 1
+      - name: Smoke the dev build
+        env:
+          # Declares intent: with this set, the spec refuses to skip.
+          PRETABLE_DEV_SMOKE: "1"
+          PRETABLE_DEV_URL: http://localhost:3100
+        run: |
+          pnpm --filter @pretable/app-website exec playwright test \
+            e2e/dev-mode.spec.ts --project=chromium
+      # The dev server's own output carries the compile errors Playwright only
+      # sees as a blank page, so it is worth more than the trace on a failure.
+      - name: Upload dev server log on failure
+        if: failure()
+        uses: actions/upload-artifact@v7
+        with:
+          name: website-dev-server-log
+          path: /tmp/next-dev.log
+          retention-days: 7
+      - name: Upload Playwright traces on failure
+        if: failure()
+        uses: actions/upload-artifact@v7
+        with:
+          name: website-dev-smoke-traces
+          path: apps/website/test-results/
+          retention-days: 7
+
   packaging:
     name: Packaging — publint + attw
     runs-on: ubuntu-latest

apps/website/e2e/dev-mode.spec.ts

@@ -27,6 +27,24 @@ import { waitForGridReady } from "./helpers";
  */
 const devUrl = process.env.PRETABLE_DEV_URL;
 
+// Skipping is convenience everywhere except the one job whose entire purpose is
+// running this: there, skipping would report success for checking nothing — the
+// same silence this spec exists to end, since the suite was 100/100 green
+// throughout the weeks the dev grid was blank.
+//
+// Keyed on the job's declared intent, NOT on `CI`. The production and preview
+// smokes run the whole directory and have no dev server by design; a `CI` guard
+// failed them both, which is its own kind of false alarm.
+if (process.env.PRETABLE_DEV_SMOKE && !devUrl) {
+  test("the dev server URL is configured", () => {
+    throw new Error(
+      "PRETABLE_DEV_URL is unset in CI. The dev-smoke job must start a dev " +
+        "server and point this at it; without it these tests skip and the " +
+        "job goes green having checked nothing.",
+    );
+  });
+}
+
 test.describe("development build", () => {
   test.skip(
     !devUrl,