Repository navigation
Commit 70e8ac8
feat(bench): wire pretable adapter to @pretable/ui Excel theme (PR 5 of 5) (#56)
* docs(plans): wire apps/bench to @pretable/ui (PR 5 of theming plan)
3-task plan covering:
- Add @pretable/ui workspace dependency to apps/bench
- Add @import statements for excel.css + grid.css to app.css
(after cool-slate, before tailwindcss)
- NO data-theme="dark" (Excel is light-only)
- NO inspection-* slim needed — bench has zero engine-attribute
CSS to override (confirmed via grep)
- Final verification of bench + workspace tests/build/typecheck
After this PR lands, the 5-PR theming arc is complete:
- @pretable/ui ships at workspace + npm
- apps/website demos Material 3 dark theme
- apps/bench demos Excel light theme
- Engine bridge (PR 3) routes CSS variables → JS layout for headers
- 24-token contract enforced by smoke test
Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
* build(bench): add @pretable/ui workspace dependency
Restores the dependency that PR 1 removed (when @pretable/ui still
held marketing components and cool-slate tokens). The new
@pretable/ui (created in PR 2) is a public theming package with
grid.css, theme files, density helpers, and a Tailwind v4 bridge.
Adds the dep to package.json, threads the build into prepare:deps
so apps/bench builds resolve the new package's dist correctly.
Subsequent commit in this PR wires the actual CSS imports.
Part 1 of wiring apps/bench to @pretable/ui (PR 5 of theming plan).
Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
* feat(bench): wire pretable adapter grid to @pretable/ui Excel theme
Two import lines in apps/bench/src/app.css between cool-slate-tokens
and tailwindcss:
- @pretable/ui/themes/excel.css — Excel theme tokens at :root.
Light-only by design; default density compact (20px rows, 15px
Aptos Narrow font, Excel-green #107C41 accent, no row hover,
sharp 0-radius corners). Bench is a benchmarking tool — Excel's
dense/technical aesthetic suits it.
- @pretable/ui/grid.css — selector-based grid skin targeting the
engine's [data-pretable-*] data attributes. With the engine's
inline styles skin-stripped in PR 3, the grid renders unthemed
until a theme + grid.css are loaded; this commit completes the
bench's pretable adapter visual setup.
Two namespaces coexist on the page: --pt-* (cool-slate, drives
bench chrome — hero, scenario panels, telemetry surfaces),
--pretable-* (Excel, drives the embedded pretable adapter grid).
They don't conflict because they're prefix-disjoint.
No data-theme="dark" — Excel is light-only. Bench's surrounding
chrome stays cool-slate dark, the pretable adapter grid renders
Excel-light. The visual contrast advertises the per-component
theming flexibility of @pretable/ui.
The bench's other adapters (AG Grid, MUI, TanStack) are unaffected
— they use their own theming systems.
Part 2 of wiring apps/bench to @pretable/ui (PR 5 of theming plan).
This completes the 5-PR theming arc.
Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
* docs(website): refresh getting-started for new @pretable/ui exports
The previous getting-started page told consumers to import
@pretable/ui/tokens.css and @pretable/ui/components.css — paths
that PR 1 deleted (when @pretable/ui was the marketing-components
package) and PR 2 didn't recreate (the new theming package has
different exports).
Update the install + import section to:
- Pick a theme (excel.css default; material.css optional)
- Import the theme + grid.css
- Note Tailwind v4 bridge (opt-in tailwind.css)
- Note runtime light/dark via data-theme="dark"
- Note runtime density via data-density="..."
Caught by code-quality review of PR 5 — these stale paths would
have produced a Vite/webpack module-resolution error for any
consumer following the published docs.
Code-quality review follow-up to e7959d2; completes the 5-PR
theming arc.
Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4 (1M context) <noreply@anthropic.com>1 parent d66c34d commit 70e8ac8
5 files changed
Lines changed: 403 additions & 5 deletions
File tree
- apps
- bench
- src
- website/app/docs/getting-started
- docs/superpowers/plans
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
7 | 9 | | |
8 | 10 | | |
9 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
| 16 | + | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
21 | 23 | | |
22 | 24 | | |
23 | 25 | | |
| |||
0 commit comments