Repository navigation
Commit 02e73ef
fix(react): export the two types the public signatures name
CI caught what my local runs did not: `public-api-forgotten-exports` failed on
`PretableFormulaEscapeInput` and `DataHonestyInput`. Both appear in public
signatures — the first as the predicate's argument, the second dragged in by
making `resolveDataScope` public — and neither was exported, so a consumer could
name the function but not its parameter type.
Worth recording why it reached CI at all: I had been verifying with
`pnpm --filter @pretable/react test`, which does not include
`scripts/__tests__/`. That directory is where this repo keeps its packaging and
public-surface guards, and the root `pnpm test` is what runs them. `api:check`
passes either way — api-extractor emits ae-forgotten-export as a WARNING, and
the script test is the thing that fails closed.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent 3021d3e commit 02e73ef
4 files changed
Lines changed: 32 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
158 | 170 | | |
159 | 171 | | |
160 | 172 | | |
| |||
1067 | 1079 | | |
1068 | 1080 | | |
1069 | 1081 | | |
1070 | | - | |
1071 | | - | |
| 1082 | + | |
| 1083 | + | |
| 1084 | + | |
| 1085 | + | |
| 1086 | + | |
| 1087 | + | |
| 1088 | + | |
| 1089 | + | |
1072 | 1090 | | |
1073 | 1091 | | |
1074 | 1092 | | |
| |||
2364 | 2382 | | |
2365 | 2383 | | |
2366 | 2384 | | |
2367 | | - | |
2368 | | - | |
2369 | 2385 | | |
2370 | 2386 | | |
2371 | 2387 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
70 | 74 | | |
71 | 75 | | |
72 | 76 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
9 | 13 | | |
10 | 14 | | |
11 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
131 | 131 | | |
132 | 132 | | |
133 | 133 | | |
| 134 | + | |
134 | 135 | | |
135 | 136 | | |
136 | 137 | | |
137 | 138 | | |
| 139 | + | |
138 | 140 | | |
139 | 141 | | |
140 | 142 | | |
| |||
0 commit comments