Fix mvn script expanding ${...} in CLI arguments#11983
Open
ascheman wants to merge 1 commit intoapache:masterfrom
Open
Fix mvn script expanding ${...} in CLI arguments#11983ascheman wants to merge 1 commit intoapache:masterfrom
ascheman wants to merge 1 commit intoapache:masterfrom
Conversation
The eval in the mvn script causes shell expansion of ${...} patterns
in user-provided arguments. Pass user arguments directly via "$@"
instead of concatenating them into the eval string. This preserves
MAVEN_OPTS word splitting while preventing unintended shell expansion.
Fixes apache#11978
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
evalin themvnscript causes shell expansion of${...}patternsin user-provided CLI arguments, breaking any argument that contains Maven
property placeholders like
${surefire.threadNumber}or${project.basedir}.Problem
The current script concatenates user arguments into a command string and
then uses
eval execwhich re-parses the string and triggers shell variableexpansion:
Maven 3's
mvnscript usesexec ... "$@"which passes arguments verbatim.Fix
Pass user arguments directly via
"$@"instead of concatenating them intothe eval string. Only the base command (containing
$MAVEN_OPTSetc.) usesevalfor word splitting:Verification
Tested locally with Maven 4.0.0-rc-5:
${...}in-Darguments: no longer causesbad substitutionMAVEN_OPTSwith spaces: still works (word splitting viaeval)"$@"preserves quoting)bad substitutionnow run successfullyFixes #11978
Related: apache/maven-surefire#3345
Note: The same fix applies to the
maven-4.0.xbranch where themvnscript is identical.