[bug] Fails to overwrite existing artifact when `archive` is false

[kazutoiris]

What happened?

When configuring the action with archive: false and overwrite: true, the action fails to correctly delete the existing artifact before uploading the new one.

Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

What did you expect to happen?

When archive: false, the artifact name is derived from the file's name. The name parameter should be completely ignored during the deletion phases.

How can we reproduce it?

name: Test

on:
  workflow_dispatch:

jobs:
  test1:
    name: Test 1
    runs-on: ubuntu-latest
    steps:
      - name: Run
        run: |
          echo "123" > 1.txt

      - name: Upload Artifact
        uses: actions/upload-artifact@v7
        with:
          archive: false
          overwrite: true
          path: 1.txt

  test2:
    name: Test 2
    needs: test1
    runs-on: ubuntu-latest
    steps:
      - name: Run
        run: |
          echo "456" > 1.txt

      - name: Upload Artifact
        uses: actions/upload-artifact@v7
        with:
          archive: false
          overwrite: true
          path: 1.txt

Or in kazutoiris/NW.js-Build/actions/runs/22487854021

Anything else we need to know?

No response

What version of the action are you using?

v7

What are your runner environments?

linux

Are you on GitHub Enterprise Server? If so, what version?

No response

[vvb2060]

I believe the correct solution is to ignore the original filename and use the name parameter specified in yml. #766

jobs:
  build:
    name: Build on ${{ matrix.os }}
    runs-on: ${{ matrix.os }}
    strategy:
      fail-fast: false
      matrix:
        os: [ ubuntu-latest, windows-latest, macOS-latest ]

    steps:
      - name: Check out
        uses: actions/checkout@v6
      - name: Set up JDK 21
        uses: actions/setup-java@v5
        with:
          distribution: 'temurin'
          java-version: '21'
      - name: Build with Gradle
        run: ./gradlew assembleRelease
      - name: Upload
        uses: actions/upload-artifact@v7
        with:
          name: ${{ matrix.os }}-app.apk
          archive: false
          path: app/build/outputs/apk/release/app-release.apk

[kazutoiris]

I believe the correct solution is to ignore the original filename and use the name parameter specified in yml. #766

jobs:
build:
name: Build on ${{ matrix.os }}
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ ubuntu-latest, windows-latest, macOS-latest ]

steps:
  - name: Check out
    uses: actions/checkout@v6
  - name: Set up JDK 21
    uses: actions/setup-java@v5
    with:
      distribution: 'temurin'
      java-version: '21'
  - name: Build with Gradle
    run: ./gradlew assembleRelease
  - name: Upload
    uses: actions/upload-artifact@v7
    with:
      name: ${{ matrix.os }}-app.apk
      archive: false
      path: app/build/outputs/apk/release/app-release.apk

According to action.yml:

upload-artifact/action.yml

Line 52 in bbbca2d

When `archive` is `false`, only a single file can be uploaded. The name of the file will be used as the artifact name (ignoring the `name` parameter).

This action uses the filename as the artifact name, rather than uses the name input parameter (which is ignored).

[vvb2060]

What I mean is, this design is flawed; filename shouldn't be used.
For matrix build, name conflicts will always occur.

[kazutoiris]

What I mean is, this design is flawed; filename shouldn't be used.
For matrix build, name conflicts will always occur.

Renaming files manually? This is designed for when you don't know the exact name (like in glob matches) or are too lazy to provide one, and just want to upload.

[vvb2060]

glob pattern cannot guarantee that only one file will be matched, and it is impossible to upload just one file without knowing the filename, so I believe the current design is flawed.

[kazutoiris]

glob pattern cannot guarantee that only one file will be matched, and it is impossible to upload just one file without knowing the filename, so I believe the current design is flawed.

From a certain perspective, the current design does indeed have some flaws. However, since the specified path already includes the filename, requiring it to be specified again in the name field would lead to redundancy.

We could consider automatically renaming the file when the name field is explicitly provided 🤔