Skip to content

Merging objects might leave data in a unexpected state #968

Description

@robbevp

When merging objects, we could end up with data in an expected state: We call update and destroy on a bunch of objects, but don't handle the failure mode.

For example, if we can't save an album_artist, we would just end up just dropping this. (I'm not sure if there is an easy way to recreate the problem currently)

We should make sure we either apply all changes of the merge, or none. For example by:

  • Using the bang variants of these method to raise an exception if something goes wrong
  • Wrapping the whole merge method in a transaction so all the changes roll back if something went wrong

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions