Reamed the OutputReport method to WriteContents to match the action it is performing as FileWriter

asos-gurpreetsingh · asos-gurpreetsingh · commit 7fb47a6fe61d · 2026-06-06T22:48:58.000+01:00
Fixed and issue when batch remaning processors wont execute if any one fails
diff --git a/src/TestStack.BDDfy.Tests/Configuration/BatchProcessorsTests.cs b/src/TestStack.BDDfy.Tests/Configuration/BatchProcessorsTests.cs
@@ -103,12 +103,9 @@ public void ReturnsAdditionalBatchProcessorsWhenAdded()
             processors.ShouldContain(p => p is FooBatchProcessor, 1);
         }
 
-        private class FooBatchProcessor : IBatchProcessor
+        private class FooBatchProcessor: IBatchProcessor
         {
-            public void Process(IEnumerable<Story> stories)
-            {
-                throw new System.NotImplementedException();
-            }
+            public void Process(IEnumerable<Story> stories) { }
         }
     }
 }
diff --git a/src/TestStack.BDDfy.Tests/FileWriterShould.cs b/src/TestStack.BDDfy.Tests/FileWriterShould.cs
@@ -18,7 +18,7 @@ public void CreatePathIfItDoesNotExist(string reportName, string? outputDirector
         {
             var fileWriter = new FileWriter();
             outputDirectory = outputDirectory is null ? null : System.IO.Path.Combine(System.IO.Path.GetTempPath(), Guid.NewGuid().ToString(), $"{outputDirectory}");
-            fileWriter.OutputReport("Test content", reportName, outputDirectory);
+            fileWriter.WriteContents("Test content", reportName, outputDirectory);
             var expectedPath = System.IO.Path.Combine(outputDirectory ?? string.Empty, reportName);
             System.IO.File.Exists(expectedPath).ShouldBeTrue();
             System.IO.File.ReadAllText(expectedPath).ShouldBe("Test content");
diff --git a/src/TestStack.BDDfy.Tests/Reporters/Diagnostics/DiagnosticsReporterTests.cs b/src/TestStack.BDDfy.Tests/Reporters/Diagnostics/DiagnosticsReporterTests.cs
@@ -20,7 +20,7 @@ public void ShouldCreateReportIfProcessingSucceeds()
 
             sut.Process([]);
 
-            _writer.Received().OutputReport("Report Data", Arg.Any<string>(), Arg.Any<string>());
+            _writer.Received().WriteContents("Report Data", Arg.Any<string>(), Arg.Any<string>());
         }
 
         [Fact]
@@ -31,7 +31,7 @@ public void ShouldPrintErrorInReportIfProcessingFails()
 
             sut.Process([]);
 
-            _writer.Received().OutputReport(
+            _writer.Received().WriteContents(
                 Arg.Is<string>(s => s.StartsWith("Error occurred.")),
                 Arg.Any<string>(),
                 Arg.Any<string>());
diff --git a/src/TestStack.BDDfy.Tests/Reporters/Html/HtmlReporterTests.cs b/src/TestStack.BDDfy.Tests/Reporters/Html/HtmlReporterTests.cs
@@ -35,7 +35,7 @@ public void ShouldCreateReportIfProcessingSucceeds()
 
             _sut.Process([]);
 
-            _sut.Configuration.FileWriter.Received().OutputReport(ReportData, Arg.Any<string>(), Arg.Any<string>());
+            _sut.Configuration.FileWriter.Received().WriteContents(ReportData, Arg.Any<string>(), Arg.Any<string>());
         }
 
         [Fact]
@@ -45,7 +45,7 @@ public void ShouldPrintErrorInReportIfProcessingFails()
 
             _sut.Process(new ReportTestData().CreateTwoStoriesEachWithOneFailingScenarioAndOnePassingScenarioWithThreeStepsOfFiveMilliseconds());
 
-            _sut.Configuration.FileWriter.Received().OutputReport(
+            _sut.Configuration.FileWriter.Received().WriteContents(
                 Arg.Is<string>(s => s.StartsWith(ErrorMessage)),
                 Arg.Any<string>(),
                 Arg.Any<string>());
diff --git a/src/TestStack.BDDfy.Tests/Reporters/MarkDown/MarkDownReporterTests.cs b/src/TestStack.BDDfy.Tests/Reporters/MarkDown/MarkDownReporterTests.cs
@@ -21,7 +21,7 @@ public void ShouldCreateReportIfProcessingSucceeds()
 
             sut.Process([]);
 
-            _writer.Received().OutputReport("Report Data", Arg.Any<string>(), Arg.Any<string>());
+            _writer.Received().WriteContents("Report Data", Arg.Any<string>(), Arg.Any<string>());
         }
 
         [Fact]
@@ -32,7 +32,7 @@ public void ShouldPrintErrorInReportIfProcessingFails()
 
             sut.Process([]);
 
-            _writer.Received().OutputReport(
+            _writer.Received().WriteContents(
                 Arg.Is<string>(s => s.StartsWith("Error occurred.")), 
                 Arg.Any<string>(), 
                 Arg.Any<string>());
diff --git a/src/TestStack.BDDfy.Tests/Scanner/FluentScanner/AmbiguousHeaderMatchTests.cs b/src/TestStack.BDDfy.Tests/Scanner/FluentScanner/AmbiguousHeaderMatchTests.cs
@@ -22,7 +22,7 @@ public void ThrowsWhenMultipleHeadersMatchParameterName()
                     .BDDfy();
             });
 
-            exception.Message.ShouldBe("More than one headers for examples, match the parameter 'count' provided for 'GivenInput'");
+            exception.Message.ShouldBe("Duplicate headers detected. count, Count");
         }
 
         private void GivenInput(int count)
diff --git a/src/TestStack.BDDfy/Engine.cs b/src/TestStack.BDDfy/Engine.cs
@@ -1,5 +1,7 @@
-﻿using TestStack.BDDfy.Configuration;
+﻿using System.Text;
+using TestStack.BDDfy.Configuration;
 using TestStack.BDDfy.Processors;
+using TestStack.BDDfy.Reporters.Writers;
 
 namespace TestStack.BDDfy
 {
@@ -15,9 +17,19 @@ static Engine()
 
         static void InvokeBatchProcessors()
         {
+            var finalErrors = new StringBuilder();
             foreach (var batchProcessor in Configurator.BatchProcessors.GetProcessors())
             {
-                batchProcessor.Process(StoryCache.Stories);
+                try { batchProcessor.Process(StoryCache.Stories); }
+                catch (Exception ex)
+                {
+                    finalErrors.AppendLine($"Error processing batch processor {batchProcessor.GetType().FullName}: {ex}");
+                }
+            }
+
+            if (finalErrors.Length > 0)
+            {
+                FileWriter.Singleton.WriteContents(finalErrors.ToString(), "errors.log");
             }
         }
 
diff --git a/src/TestStack.BDDfy/Reporters/Diagnostics/GenericReporter.cs b/src/TestStack.BDDfy/Reporters/Diagnostics/GenericReporter.cs
@@ -21,7 +21,7 @@ public virtual void Process(IEnumerable<Story> stories)
                 report = ex.Message + ex.StackTrace;
             }
 
-            _configuration.FileWriter.OutputReport(report, _configuration.OutputFileName);
+            _configuration.FileWriter.WriteContents(report, _configuration.OutputFileName);
         }
     }
 }
diff --git a/src/TestStack.BDDfy/Reporters/Diagnostics/JsonDataFileReporter.cs b/src/TestStack.BDDfy/Reporters/Diagnostics/JsonDataFileReporter.cs
@@ -22,7 +22,7 @@ public void Process(IEnumerable<Story> stories)
                 filename = filename.Replace(".json", ".js");
             }
 
-            reportConfiguration.FileWriter.OutputReport(content, filename);
+            reportConfiguration.FileWriter.WriteContents(content, filename);
         }
 
         private static ReportConfiguration DefaultReportConfiguration => new(DefaultOutputFileName);
diff --git a/src/TestStack.BDDfy/Reporters/Html/HtmlReporter.cs b/src/TestStack.BDDfy/Reporters/Html/HtmlReporter.cs
@@ -29,7 +29,7 @@ void WriteOutHtmlReport()
                 report = ex.Message + ex.StackTrace;
             }
 
-            Configuration.FileWriter.OutputReport(report, Configuration.OutputFileName, Configuration.OutputPath);
+            Configuration.FileWriter.WriteContents(report, Configuration.OutputFileName, Configuration.OutputPath);
         }
 
         private void LoadCustomScripts()
diff --git a/src/TestStack.BDDfy/Reporters/Writers/FileWriter.cs b/src/TestStack.BDDfy/Reporters/Writers/FileWriter.cs
@@ -2,14 +2,16 @@ namespace TestStack.BDDfy.Reporters.Writers
 {
     public class FileWriter : IFileWriter
     {
-        public void OutputReport(string reportData, string reportName, string? outputDirectory = null)
+        public static readonly FileWriter Singleton = new();
+
+        public void WriteContents(string contents, string fileName, string? outputDirectory = null)
         {
-            var filePath = FileHelpers.ResolvePath(outputDirectory, reportName);
+            var filePath = FileHelpers.ResolvePath(outputDirectory, fileName);
             string directory = Path.GetDirectoryName(filePath) ?? throw new InvalidOperationException("Unable to determine directory.");
 
             Directory.CreateDirectory(directory);
 
-            File.WriteAllText(filePath, reportData);
+            File.WriteAllText(filePath, contents);
         }
     }
 }
diff --git a/src/TestStack.BDDfy/Reporters/Writers/IFileWriter.cs b/src/TestStack.BDDfy/Reporters/Writers/IFileWriter.cs
@@ -2,6 +2,6 @@ namespace TestStack.BDDfy.Reporters.Writers
 {
     public interface IFileWriter
     {
-        void OutputReport(string reportData, string reportName, string? outputDirectory = null);
+        void WriteContents(string reportData, string reportName, string? outputDirectory = null);
     }
 }
diff --git a/src/TestStack.BDDfy/Scanners/StepScanners/Examples/ExampleTable.cs b/src/TestStack.BDDfy/Scanners/StepScanners/Examples/ExampleTable.cs
@@ -1,4 +1,5 @@
 using System.Collections;
+using System.Reflection;
 using System.Text;
 
 namespace TestStack.BDDfy
@@ -15,6 +16,9 @@ public class ExampleTable(params string[] headers): ICollection<Example>
 
         public void Add(params object?[] items)
         {
+            if (Headers.Distinct(StringComparer.OrdinalIgnoreCase).Count() != Headers.Length)
+                throw new AmbiguousMatchException($"Duplicate headers detected. {string.Join(", ", Headers)}");
+
             if (items.Length != Headers.Length)
                 throw new ArgumentException(string.Format("Number of column values does not match number of headers, got {0}, expected {1}", items.Length, Headers.Length));
 

Original file line number	Diff line number	Diff line change
`@@ -103,12 +103,9 @@ public void ReturnsAdditionalBatchProcessorsWhenAdded()`
`103`	`103`	`processors.ShouldContain(p => p is FooBatchProcessor, 1);`
`104`	`104`	`}`
`105`	`105`
`106`		`- private class FooBatchProcessor : IBatchProcessor`
	`106`	`+ private class FooBatchProcessor: IBatchProcessor`
`107`	`107`	`{`
`108`		`- public void Process(IEnumerable<Story> stories)`
`109`		`- {`
`110`		`- throw new System.NotImplementedException();`
`111`		`- }`
	`108`	`+ public void Process(IEnumerable<Story> stories) { }`
`112`	`109`	`}`
`113`	`110`	`}`
`114`	`111`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ public void CreatePathIfItDoesNotExist(string reportName, string? outputDirector`
`18`	`18`	`{`
`19`	`19`	`var fileWriter = new FileWriter();`
`20`	`20`	`outputDirectory = outputDirectory is null ? null : System.IO.Path.Combine(System.IO.Path.GetTempPath(), Guid.NewGuid().ToString(), $"{outputDirectory}");`
`21`		`- fileWriter.OutputReport("Test content", reportName, outputDirectory);`
	`21`	`+ fileWriter.WriteContents("Test content", reportName, outputDirectory);`
`22`	`22`	`var expectedPath = System.IO.Path.Combine(outputDirectory ?? string.Empty, reportName);`
`23`	`23`	`System.IO.File.Exists(expectedPath).ShouldBeTrue();`
`24`	`24`	`System.IO.File.ReadAllText(expectedPath).ShouldBe("Test content");`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ public void ThrowsWhenMultipleHeadersMatchParameterName()`
`22`	`22`	`.BDDfy();`
`23`	`23`	`});`
`24`	`24`
`25`		`- exception.Message.ShouldBe("More than one headers for examples, match the parameter 'count' provided for 'GivenInput'");`
	`25`	`+ exception.Message.ShouldBe("Duplicate headers detected. count, Count");`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`private void GivenInput(int count)`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,7 @@`
`1`		`-using TestStack.BDDfy.Configuration;`
	`1`	`+using System.Text;`
	`2`	`+using TestStack.BDDfy.Configuration;`
`2`	`3`	`using TestStack.BDDfy.Processors;`
	`4`	`+using TestStack.BDDfy.Reporters.Writers;`
`3`	`5`
`4`	`6`	`namespace TestStack.BDDfy`
`5`	`7`	`{`
`@@ -15,9 +17,19 @@ static Engine()`
`15`	`17`
`16`	`18`	`static void InvokeBatchProcessors()`
`17`	`19`	`{`
	`20`	`+ var finalErrors = new StringBuilder();`
`18`	`21`	`foreach (var batchProcessor in Configurator.BatchProcessors.GetProcessors())`
`19`	`22`	`{`
`20`		`- batchProcessor.Process(StoryCache.Stories);`
	`23`	`+ try { batchProcessor.Process(StoryCache.Stories); }`
	`24`	`+ catch (Exception ex)`
	`25`	`+ {`
	`26`	`+ finalErrors.AppendLine($"Error processing batch processor {batchProcessor.GetType().FullName}: {ex}");`
	`27`	`+ }`
	`28`	`+ }`
	`29`	`+`
	`30`	`+ if (finalErrors.Length > 0)`
	`31`	`+ {`
	`32`	`+ FileWriter.Singleton.WriteContents(finalErrors.ToString(), "errors.log");`
`21`	`33`	`}`
`22`	`34`	`}`
`23`	`35`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ public virtual void Process(IEnumerable<Story> stories)`
`21`	`21`	`report = ex.Message + ex.StackTrace;`
`22`	`22`	`}`
`23`	`23`
`24`		`- _configuration.FileWriter.OutputReport(report, _configuration.OutputFileName);`
	`24`	`+ _configuration.FileWriter.WriteContents(report, _configuration.OutputFileName);`
`25`	`25`	`}`
`26`	`26`	`}`
`27`	`27`	`}`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ public void Process(IEnumerable<Story> stories)`
`22`	`22`	`filename = filename.Replace(".json", ".js");`
`23`	`23`	`}`
`24`	`24`
`25`		`- reportConfiguration.FileWriter.OutputReport(content, filename);`
	`25`	`+ reportConfiguration.FileWriter.WriteContents(content, filename);`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`private static ReportConfiguration DefaultReportConfiguration => new(DefaultOutputFileName);`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ void WriteOutHtmlReport()`
`29`	`29`	`report = ex.Message + ex.StackTrace;`
`30`	`30`	`}`
`31`	`31`
`32`		`- Configuration.FileWriter.OutputReport(report, Configuration.OutputFileName, Configuration.OutputPath);`
	`32`	`+ Configuration.FileWriter.WriteContents(report, Configuration.OutputFileName, Configuration.OutputPath);`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`private void LoadCustomScripts()`