[ngan-giang-phan]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

Fixes NetworkOnMainThreadException crash when rotating on a Bandcamp artist page, or when pressing system back from an album to the artist page. This is because handleResult() calls fromQuery() which makes a network request on main thread.

• Added a lightweightTabHandler field to hold the replacement link handler, so it can be built on a background thread and passed to the main thread
• Moved the existing logic in handleResult to a createLightweightTabHandler helper, to be called on the background thread
• handleResult no longer calls fromQuery and swaps in the prepared handler
• loadResult makes sure network requests are called on the background thread via doOnSuccess

Before/After Screenshots/Screen Record

• Before:
  before_back.webm
  before_rotate.webm

• After:
  after_back.webm
  after_rotate.webm

Fixes the following issue(s)

• Fixes [Bandcamp] NetworkOnMainThreadException when rotating screen on artist/channel page #11183

Testing/QA

Devices

• Tested on Android 13 (API 33) emulator

Steps for testing

• Switch service to Bandcamp (service list -> Bandcamp)
• Search up any artist on Bandcamp
• Click on the artist page
• Rotate the screen
• Click on any album
• Click on system back (at the bottom of the screen on Android devices) or swipe from the left edge
• Verify that a crash didn't happen and the app still runs normally

APK for testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• I read the contribution guidelines.
• The proposed changes follow the AI policy.
• I tested the changes using an emulator or a physical device.

[TobiGr]

Thank you for the contribution! Is it part of the yearly ANU assignement? I'll review this PR in the next few days.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[ngan-giang-phan]

Is it part of the yearly ANU assignement?

Yes, it is. Thanks for taking the time to review it!