Merge pull request #263 from SuffolkLITLab/fix/251-checklist-guidance

Hide document checklist guidance when no checklist is available

Author: nonprofittechy

efile_app/efile/templates/efile/document_checklist.html

@@ -11,21 +11,17 @@ <h1>{% translate "Check your documents" %}</h1>
         <p class="workflow-lede">
             {% translate "Review the files below. Add anything else you want the court to get with this filing." %}
         </p>
-        <div class="checklist-guidance" role="note">
-            <i class="fa-solid fa-circle-info" aria-hidden="true"></i>
-            <div>
-                <strong>{% translate "This list is a guide" %}</strong>
-                {% if checklist_groups %}
+        {% if checklist_groups %}
+            <div class="checklist-guidance" role="note">
+                <i class="fa-solid fa-circle-info" aria-hidden="true"></i>
+                <div>
+                    <strong>{% translate "This list is a guide" %}</strong>
                     <p>
                         {% blocktranslate with court=plan.court_name|default:filing_draft.court_name %}Some filings like yours at {{ court }} include the documents below. Depending on your situation, other documents may be needed, or some of these may not apply. You do not have to check anything off to continue.{% endblocktranslate %}
                     </p>
-                {% else %}
-                    <p>
-                        {% translate "Include every completed court form, exhibit, translation, or proposed order that belongs with this filing. This list cannot tell you which legal forms your case needs." %}
-                    </p>
-                {% endif %}
+                </div>
             </div>
-        </div>
+        {% endif %}
         {% if choosing_filer_role %}
             <section class="document-plan filer-role" aria-labelledby="filer-role-heading">
                 <h2 id="filer-role-heading">{% translate "Which side of this case are you on?" %}</h2>

efile_app/efile/tests/test_document_prep.py

@@ -100,6 +100,7 @@ def test_document_checklist_shows_configured_guidance(client, planned_draft):
     page = response.content.decode()
     assert response.status_code == 200
     assert "Your document plan" in page
+    assert "This list is a guide" in page
     assert "Commonly included" in page
     assert "Always needed" not in page
     assert "Depending on your situation, other documents may be needed" in page
@@ -109,13 +110,14 @@ def test_document_checklist_shows_configured_guidance(client, planned_draft):
 
 
 @pytest.mark.django_db
-def test_document_checklist_keeps_its_disclaimer_without_configured_guidance(client, document_draft):
+def test_document_checklist_hides_its_disclaimer_without_configured_guidance(client, document_draft):
     response = client.get(reverse("document_checklist", kwargs={"jurisdiction": "illinois"}))
 
     document_draft.refresh_from_db()
     page = response.content.decode()
     assert "Your document plan" not in page
-    assert "cannot tell you which legal forms your case needs" in page
+    assert "This list is a guide" not in page
+    assert "cannot tell you which legal forms your case needs" not in page
     assert document_draft.plan_id is None