Skip to content

Commit 3d2093c

Browse files
committed
Fix #1055, address #1088, action outputs and pipeline issues
Fixes #1055, restore custom artifacts path argument to allow environments like action.yml to make and reuse their own artifacts path value in environments where it's hard to pass around return values. Closes [#1055](#1055). Addresses #1088, new issues with puppeteer installs in GitHub actions being unable to find Chrome executables.
1 parent e1651b2 commit 3d2093c

5 files changed

Lines changed: 20 additions & 5 deletions

File tree

‎.npmrc‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
ignore-scripts=true
2+
min-release-age=7

‎CHANGELOG.md‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,16 @@ Format:
4343
-
4444
-->
4545

46+
## [Unreleased]
47+
48+
### Fixed
49+
50+
- Restore custom artifacts path argument to allow environments like action.yml to make and reuse their own artifacts path value in environments where it's hard to pass around return values. Closes [#1055](https://github.com/suffolkLITLab/aLKiln/issues/1055).
51+
52+
### Security
53+
54+
- Moved responsibility for security measures to ALKiln internal development by automating internal security measures with `.npmrc`. Closes [#1088](https://github.com/suffolkLITLab/aLKiln/issues/1088).
55+
4656
## [5.16.0] - 2026-05-14
4757

4858
### Added

‎action.yml‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,9 +120,7 @@ runs:
120120
run: |
121121
log="💡 ALK0026 INFO: Install ALKiln directly from npm"
122122
echo -e "\n$log" >> "${{ env.DEBUG_PATH }}"
123-
npm install --ignore-scripts --min-release-age=7 -g "@suffolklitlab/alkiln@$ALKILN_VERSION"
124-
npm rebuild -g puppeteer --update-binary
125-
123+
npm install -g "@suffolklitlab/alkiln@$ALKILN_VERSION"
126124
127125
# Files prep
128126
- shell: bash

‎lib/setup/artifacts.js‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,12 @@ const Log = require(`../utils/Log.js`);
1111

1212
session_vars.delete_artifacts_path_name();
1313

14-
const artifacts_path = files.make_artifacts_folder();
14+
// process.argv is a list of strings of commands and args.
15+
// If using `npm run artifacts` (as opposed to the bin commands),
16+
// use `--` before, for example, `--sources=./foo`
17+
// Envs like action.yml reuse their own .path when return vals are hard to get
18+
const forced_path = require(`minimist`)( process.argv.slice(2) )?.path;
19+
const artifacts_path = files.make_artifacts_folder( forced_path );
1520
session_vars.save_artifacts_path_name( artifacts_path );
1621

1722
const log = new Log({ path: artifacts_path, context: `artifacts` });

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@suffolklitlab/alkiln",
3-
"version": "5.16.0",
3+
"version": "5.16.0-fix-artifacts-n-pipeline",
44
"description": "Integrated automated end-to-end testing with docassemble, puppeteer, and cucumber.",
55
"main": "lib/index.js",
66
"scripts": {

0 commit comments

Comments
 (0)