From 0f2da219ffa0882501cfcec6142579f4b6caa695 Mon Sep 17 00:00:00 2001 From: ChrisRackauckas-Claude Date: Thu, 8 Oct 2026 00:15:14 -0400 Subject: [PATCH] Import alg_adaptive_order / alg_can_repeat_jac in Feagin and StabilizedIRK The Feagin10/14 alg_adaptive_order and IRKC alg_can_repeat_jac methods were defined without importing the names, so they created local functions that OrdinaryDiffEqCore never dispatches to. Import them, and drop IRKC's alg_adaptive_order, which equals Core's fallback. Fixes #4811 Co-Authored-By: Chris Rackauckas Co-Authored-By: Devin Co-Authored-By: Claude Opus 5.5 (1M context) Agent-Harness: Devin CLI devin 3000.11.3 (9c803229faa4) (source edits) / Claude Code (tests, verification) Agent-Model: swe-2-high / claude-opus-5-5[1m] Agent-Session: https://claude.ai/code/session_015tNYhuzygK9z8yhh6MNCAz ; Devin local log ~/.local/share/devin/cli/logs/devin_20261007-230500_3918525.log --- lib/OrdinaryDiffEqFeagin/src/OrdinaryDiffEqFeagin.jl | 2 +- lib/OrdinaryDiffEqFeagin/test/ode_feagin_tests.jl | 5 +++++ .../src/OrdinaryDiffEqStabilizedIRK.jl | 1 + lib/OrdinaryDiffEqStabilizedIRK/src/alg_utils.jl | 1 - lib/OrdinaryDiffEqStabilizedIRK/test/irkc_tests.jl | 5 +++++ 5 files changed, 12 insertions(+), 2 deletions(-) diff --git a/lib/OrdinaryDiffEqFeagin/src/OrdinaryDiffEqFeagin.jl b/lib/OrdinaryDiffEqFeagin/src/OrdinaryDiffEqFeagin.jl index b3bec282b79..a8dd3c75c94 100644 --- a/lib/OrdinaryDiffEqFeagin/src/OrdinaryDiffEqFeagin.jl +++ b/lib/OrdinaryDiffEqFeagin/src/OrdinaryDiffEqFeagin.jl @@ -3,7 +3,7 @@ module OrdinaryDiffEqFeagin import OrdinaryDiffEqCore: perform_step!, OrdinaryDiffEqMutableCache, OrdinaryDiffEqConstantCache, OrdinaryDiffEqAdaptiveAlgorithm, CompiledFloats, - alg_cache, @cache, + alg_adaptive_order, alg_cache, @cache, constvalue, get_fsalfirstlast, trivial_limiter! import SciMLBase: alg_order diff --git a/lib/OrdinaryDiffEqFeagin/test/ode_feagin_tests.jl b/lib/OrdinaryDiffEqFeagin/test/ode_feagin_tests.jl index 5ed2e82598b..bf81a6918e0 100644 --- a/lib/OrdinaryDiffEqFeagin/test/ode_feagin_tests.jl +++ b/lib/OrdinaryDiffEqFeagin/test/ode_feagin_tests.jl @@ -6,6 +6,11 @@ import ODEProblemLibrary: prob_ode_bigfloatlinear, prob_ode_bigfloat2Dlinear, prob_ode_2Dlinear +@testset "alg_adaptive_order extends OrdinaryDiffEqCore" begin + @test OrdinaryDiffEqFeagin.OrdinaryDiffEqCore.alg_adaptive_order(Feagin10()) == 8 + @test OrdinaryDiffEqFeagin.OrdinaryDiffEqCore.alg_adaptive_order(Feagin14()) == 12 +end + ## Convergence Testing println("Convergence Test on Linear") diff --git a/lib/OrdinaryDiffEqStabilizedIRK/src/OrdinaryDiffEqStabilizedIRK.jl b/lib/OrdinaryDiffEqStabilizedIRK/src/OrdinaryDiffEqStabilizedIRK.jl index b9f8a148431..5c152c99a3b 100644 --- a/lib/OrdinaryDiffEqStabilizedIRK/src/OrdinaryDiffEqStabilizedIRK.jl +++ b/lib/OrdinaryDiffEqStabilizedIRK/src/OrdinaryDiffEqStabilizedIRK.jl @@ -6,6 +6,7 @@ import OrdinaryDiffEqCore: default_controller, IController, OrdinaryDiffEqNewtonAdaptiveAlgorithm, OrdinaryDiffEqMutableCache, OrdinaryDiffEqConstantCache, alg_cache, @cache, + alg_can_repeat_jac, get_fsalfirstlast, increment_nf!, set_EEst!, generic_solver_docstring, _fixup_ad, get_W, isnewton diff --git a/lib/OrdinaryDiffEqStabilizedIRK/src/alg_utils.jl b/lib/OrdinaryDiffEqStabilizedIRK/src/alg_utils.jl index 7e0a9a1c406..689b4a2af74 100644 --- a/lib/OrdinaryDiffEqStabilizedIRK/src/alg_utils.jl +++ b/lib/OrdinaryDiffEqStabilizedIRK/src/alg_utils.jl @@ -1,5 +1,4 @@ alg_order(alg::IRKC) = 2 -alg_adaptive_order(alg::IRKC) = 1 gamma_default(alg::IRKC) = 8 // 10 alg_can_repeat_jac(alg::IRKC) = false issplit(alg::IRKC) = true diff --git a/lib/OrdinaryDiffEqStabilizedIRK/test/irkc_tests.jl b/lib/OrdinaryDiffEqStabilizedIRK/test/irkc_tests.jl index 26c37752db6..07c4c7e084b 100644 --- a/lib/OrdinaryDiffEqStabilizedIRK/test/irkc_tests.jl +++ b/lib/OrdinaryDiffEqStabilizedIRK/test/irkc_tests.jl @@ -1,5 +1,10 @@ using OrdinaryDiffEqStabilizedIRK, Test, LinearAlgebra, Random using OrdinaryDiffEqStabilizedIRK: maxeig! +import OrdinaryDiffEqCore + +@testset "alg_can_repeat_jac extends OrdinaryDiffEqCore" begin + @test OrdinaryDiffEqCore.alg_can_repeat_jac(IRKC()) == false +end @testset "Power Iteration of Runge-Kutta-Chebyshev Tests" begin Random.seed!(123)