Repository navigation
Fix Feagin12 tableau: c[2] should be 0.2, not 2 - #5002
bobby404-K wants to merge 4 commits into
Conversation
@bobby404-K, thanks for the Feagin12 fix.
No CI has run on this head yet. Maintainers decide when workflows are approved for outside contributions, so nothing here depends on you. 🤖 Posted by an AI agent — harness: Claude Code 2.1.325 · model: claude-sonnet-5-5 |
|
Thanks for the review! Addressed all three:
|
PR: #5002 Reviewed head: a978d1c Risk assessment
Review reportVERDICT: MERGE
Riskmedium-low (ML2: fixes peripheral ExplicitRK tableau OrdinaryDiffEqExplicitTableaus.Feagin12 node c[2] from 2 to 0.2; main OrdinaryDiffEq lanes and OrdinaryDiffEqFeagin.Feagin12 are untouched, autonomous trajectories are bit-for-bit unchanged, and non-autonomous analytic convergence fails before and passes after) Blocking findingsNone. Non-blocking findings
What I ran
What I did not verify
AUTHOR_GRADE: {"task": "bugfix", "score": 5, "difficulty": 2, "rounds": 1, "author_harness": "unknown", "author_model": "unknown", "note": "Fixes an unambiguous decimal-point typo (c[2] = 2 -> 0.2) in OrdinaryDiffEqExplicitTableaus.Feagin12, restores accidental Project.toml churn, formats cleanly with Runic, and adds both a row-sum consistency check and an analytic non-autonomous BigFloat convergence test that fails before (order 1.05) and passes after (order 11.85)."} Head link: a978d1c 🤖 Posted by an AI agent — harness: Antigravity CLI 1.5.10 · model: gemini-4-carbon-high |
|
@ChrisRackauckas this is ready for a human review when you have time. It fixes the The remaining failing CI jobs look unrelated to the DiffEqDevTools downgrade failure is |
|
LGTM, Feagin12 goes from order ~1.1 to ~11.6 on u' = u cos(t) with this. Runic still flags the trailing spaces on the blank line at test/core_tests.jl:214. |
|
@singhharsh1708! Thanks! Fixed the trailing whitespace on core_tests.jl:214; Runic is clean now. |
|
@singhharsh1708 Thanks! for reviewing it. |
Fixes #5001
ET.Feagin12hadc[2] = 2, a dropped decimal point. It should be0.2,consistent with
A[2,1] = 0.2and with the nativeFeagin12()solver(
c1 = 1//5).Because
cis only used to evaluatef(u, p, t + c[i]*dt), this only affectednon-autonomous problems solved through
ExplicitRK(tableau = ET.Feagin12());all existing tests used autonomous problems, so it went unnoticed.
The native
Feagin12()solver is unaffected.Changes:
c[2]inFeagin12.c == sum(A, dims = 2)for the high-order tableaus.u' = u*cos(t)) for Feagin12/14.Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Reported by @rcgiri-physics in #5001. A scan of the other explicit tableaus in
OrdinaryDiffEqExplicitTableausfound no othercvs. row-sum mismatchesamong the entries written as plain
convert(T, big"...")values. The newconsistency test covers Feagin12, Feagin14 and Ono12.
I used Claude (AI) for some assistance with this PR; I reviewed all changes myself and ran the tests locally.