Repository navigation
Require OrdinaryDiffEqCore 4.18.1 for adaptive reference tests - #591
ChrisRackauckas wants to merge 1 commit into
Conversation
The Float32 Vern9 reference needs the adaptive clock-rounding fix first released in OrdinaryDiffEqCore 4.18.1. On a Zen 3 target, Core 4.18.0 fails the existing GPUVern9 comparison at 0.0010757452; 4.18.1 passes at 0.0007073194 with an identical GPUVern9 result. An isolated clock-only control reproduces the pass. Keep the existing assertions and tolerances. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Codex <noreply@openai.com> Agent-Harness: Codex CLI 0.164.0 Agent-Model: gpt-6-astra Agent-Session: local job diffeqgpu-downgrade-vern9 (no session URL)
Fresh read-only review completed by Codex CLI 0.164.0 / gpt-6.1-sol, session VERDICT: MERGE-WITH-ISSUES No blocking correctness findings. The reviewer verified that the adjacent 4.18.0/4.18.1 environments differ only in OrdinaryDiffEqCore, the original CI discrepancy is reproduced exactly, and the isolated upstream clock fix produces the same passing result as 4.18.1. The two-line change constrains only test dependency resolution; solver code, assertions and tolerances are unchanged. No commits follow this review. The reviewer inspected the saved full CPU and QA results; it did not run new Julia tests. Final local QA passed 25/25 quality checks and 75/75 JET checks after dependency precompilation, with Aqua's timeout unchanged. Cold-cache QA success and local GPU execution are not established. Exact-head CI was still running at review time; this verdict is not a GitHub approval or a merge waiver. Risk assessment
Links:
🤖 Posted by an AI agent — harness: Codex CLI 0.164.0 · model: gpt-6-astra |
A second independent review was done in a fresh gpt-6.1-sol session (01a1aaa5-1546-7233-adb6-244faf9a3b30), against head
With this, the PR has two counted medium-low ratings from separate sessions (the first was in 01a1aa8e…). 🤖 Posted by an AI agent — harness: Claude Code 2.1.301 · model: claude-opus-5-5 |
Buildkite 1869 has two red jobs on this head (90a1cbc). Neither is caused by this PR:
All other checks are green except CUDA, which has the existing failure tracked in #546. 🤖 Posted by an AI agent — harness: Claude Code 2.1.301 · model: claude-opus-5-5 |
Require OrdinaryDiffEqCore 4.18.1 in the test environment so the adaptive Float32 reference solves use the upstream clock-rounding fix. The existing GPUVern9 regression fails with the older reference solver because its state advances by a step length that differs from the rounded floating-point time increment. This changes only the test dependency floor; OrdinaryDiffEqCore is an existing transitive test dependency licensed under MIT.
Please leave this draft pending review by @ChrisRackauckas.
Reproduction and version boundary
The failure in https://github.com/SciML/DiffEqGPU.jl/actions/runs/41962545816 reproduces exactly on Julia 1.10.13 with
-C znver3, the CI package versions, and the unchanged assertion intest/gpu_kernel_de/gpu_ode_regression.jl:46:The workflow's matrix label says
alldeps, but it passes no mode to the reusable workflow, which usesdeps. Reproduced the exact action at julia-actions/julia-downgrade-compat@30b83cf with merged root/test resolution, stdlib exclusions, removal of the secondary test manifest, andPkg.test(allow_reresolve=false)environment construction. Every registry package version matched the failing CI log.The adjacent-version pair differs only in Core. DiffEqBase 7.21.2 is required by both versions. The clock-only control isolates SciML/OrdinaryDiffEq.jl@498c765. GPUVern9's endpoint is bitwise unchanged across the pair. Against a Float64 Vern9 reference at
abstol=reltol=1e-13, the CPU reference error falls from 4.36616e-4 to 7.05399e-5, while GPUVern9's error stays 6.44729e-4. The test tolerance and assertions remain unchanged.The original environment passes on native Zen 5 and generic targets, so
-C znver3is necessary to reproduce this exact failure locally.Validation
All numerical tests use the repository's existing assertions. CPU groups ran through the official
test/runtests.jlin Pkg.test-captured environments, with--startup-file=no --compiled-modules=noandGROUP=CPU:-C znver3: full CPU group passed; affected testset 50/50.-C znver3: full CPU group passed; affected testset 50/50.julia +release --project=<Runic environment> -m Runic --check src ext test: passed.typos --config .typos.toml <git diff>andgit diff --check: passed.JULIA_NUM_THREADS=2 JULIA_NUM_PRECOMPILE_TASKS=2 GROUP=QA julia +lts --startup-file=no --project -e 'using Pkg; Pkg.test(; julia_args=["--check-bounds=auto"])': passed, Quality Assurance 25/25 and JET static analysis 75/75 (exit 0).QA required completing cold dependency precompilation first. An initial four-task attempt was OOM-killed. Two-task attempts reported 24 passes and one Aqua persistent-task timeout while ModelingToolkitBase was still compiling.
Pkg.precompile(["ModelingToolkitBase", "DiffEqGPU"]; strict=true)completed the three pending dependencies in 89 seconds (ModelingToolkitBase alone: 83.5 seconds). The unchanged full QA rerun then passed with normal compiled modules; Aqua's 60-second limit and all assertions remain unchanged.The CPU-only scope does not exercise GPU hardware. Documentation building is not applicable to this test-environment metadata change. The numerical test processes used
--compiled-modules=no; QA also runs its explicit persistent-task precompilation check. Assertions were neither skipped nor weakened.Risk assessment
90a1cbc61d1e36e6636e1ee440c40a20fa61820d: no blocking correctness findings; CI and cold-cache QA remain validation limits. The reviewer recorded its rating before reading the author's. Review summary. No commits follow the review.🤖 Posted by an AI agent — harness: Codex CLI 0.164.0 · model: gpt-6-astra
Conversation: local job diffeqgpu-downgrade-vern9 (no session URL)