Repository navigation
fix: exported types for conditional exports - #1526
Closed
Suneil Nyamathi (snyamathi) wants to merge 6 commits into
Closed
Suneil Nyamathi (snyamathi) wants to merge 6 commits into
Suneil Nyamathi (snyamathi) wants to merge 6 commits into
Conversation
❌ Deploy Preview for astro-preview failed. Why did it fail? →
|
🦋 Changeset detectedLatest commit: 163694e The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
❌ Deploy Preview for astro-stencil failed. Why did it fail? →
|
Contributor
Author
|
Let me test this a bit more - not ready yet, will re-open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Description
https://nodejs.org/api/packages.html#conditional-exports the
exportstakes precedence over the top leveltypesfield - as a result, typescript types are broken in v8 due to the changes in fecfc74#diff-7298512f791c54d2827facfc8d26ae8a5db2ac960e464e30953ccaab05dd412eR10JIRA Link
Related Issue
#1500 pretty sure the regression was introduced here
General Notes
I've tested this locally using
patch-packagebut I'm not sure how else to add a test for thisMotivation and Context
Issues and Limitations
Types of changes
Checklist