Skip to content

Returning false in #save on a server error. #46

Description

@swilliams

Right now Arkenstone::Document returns self at the end of #save. If the server returns a 500, there isn't an easy way to discover this. I hacked in a server_errors property real quick to get something done, but this should be addressed better.

I did create a branch to demonstrate this, and all of the tests pass, but I don't know if there is other code out there depending on the old behavior.

Thoughts before I make a PR?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions