fix: remove stray breakpoint() from _procrastinate (code review #13)

Postponing a task that has parents could drop the user straight into
pdb:

    import inspect
    stack_depth = len(inspect.stack())
    if stack_depth > 13:
        breakpoint()

This is item #13 of docs/code-review-2026-06-12.md, the one correctness
bug from that review left on hold.  It is reachable in normal use - the
guard sits in the recursive "postpone the parent too" path, entered from
`interactive check-due` and `dismiss-panic`, and a plain `edit --postpone`
already sits at ~12 frames, so a couple of levels of recursion crosses the
threshold.  With no tty attached it does not even look like a debugger,
just a hang.

The stack-depth probe was a debugging aid for the recursion, not a
feature; drop the whole block.  Marked fixed in the review document, and
covered by a test asserting the function stays free of breakpoint() and
inspect.stack().

Prompt: /review-and-push create a pull request from this branch [review-and-push skill; the branch already had draft PR #43, so the skill ran its full review procedure over the branch instead of opening a new PR]
Followup-Prompt: (answer to a clarifying question) A1-A5 plus CHANGELOG and the timespec tests [= fix all five confirmed bugs from the clean-context code review, add the missing CHANGELOG entries, and add regression tests for the timespec fixes]

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>

Author: tobixen

docs/code-review-2026-06-12.md

@@ -391,7 +391,7 @@ then the remaining crash-on-edge-case items **#6-#15**. The duplication of
 | 10 | `timeline_suggestion` crashes on all-day / DTEND-less events | ✅ Fixed | `panic_planning.py:112` |
 | 11 | `interactive check-due --limit` is a string, not int | ✅ Fixed | `cli.py:519` — added `type=int` |
 | 12 | `obj.icalendar_component_UID` crashes in inconsistency-log path | ✅ Fixed | `lib.py:355` |
-| 13 | Leftover `breakpoint()` in `_procrastinate` | ⏸ On hold | `lib.py:241-244` |
+| 13 | Leftover `breakpoint()` in `_procrastinate` | ✅ Fixed | `lib.py:241-244` |
 | 14 | `time_tracking` string iterated char-by-char | ✅ Fixed | `lib.py:165` — wrap scalar in list |
 | 15 | `dismiss-panic` double-prefixes lookahead (`++60d`) | ✅ Fixed | `cli.py:538` + `commands.py:466` |
 | C1 | `_interactive_edit` duplicated in `commands.py` (stale copy) | ✅ Fixed | Deleted copy, import canonical from `interactive` |

plann/lib.py

@@ -329,10 +329,6 @@ def _procrastinate(objs, delay, check_dependent="error", with_children=False, wi
                     else:
                         err_callback(f"{summary} could not be postponed due to parent {_summary(p)} with due {_ensure_ts(p['DUE'])} and priority {p.get('priority', 0)}")
                     if p_postponable and (p_auto_postponable or confirm_callback("procrastinate parent?")):
-                        import inspect
-                        stack_depth = len(inspect.stack())
-                        if stack_depth > 13:
-                            breakpoint()
                         _procrastinate([parent], new_due+max(parent.get_duration()+x.get_duration()+datetime.timedelta(minutes=1), datetime.timedelta(minutes=1)), check_dependent=check_dependent, err_callback=err_callback, confirm_callback=confirm_callback, recursivity=recursivity+1)
                         _procrastinate([x], new_due, check_dependent=check_dependent, err_callback=err_callback, confirm_callback=confirm_callback, recursivity=recursivity+1)
             elif check_dependent == "return":

tests/test_lib.py

@@ -479,3 +479,15 @@ def test_list_top_down_caches_relative_fetches():
     ## without caching, p is fetched once per child (and more via recursion)
     assert cal.fetch_counts['p'] == 1, dict(cal.fetch_counts)
     assert all(count <= 1 for count in cal.fetch_counts.values()), dict(cal.fetch_counts)
+
+
+def test_procrastinate_has_no_breakpoint():
+    """A stray breakpoint() drops the user into pdb (or appears to hang when
+    there is no tty).  Code review item #13 - the recursive postpone-parent
+    path in _procrastinate had one guarded by an inspect.stack() depth check,
+    which is reachable from `interactive check-due` / `dismiss-panic`."""
+    import inspect as _inspect
+
+    source = _inspect.getsource(_procrastinate)
+    assert 'breakpoint()' not in source
+    assert 'inspect.stack()' not in source