Repository navigation
Update CI to Node 24 - #29
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The registryEntryHolder write handler in minecraft-protocol has a bug where it does `offset += 1` instead of writing a 0x00 varint byte for inline sound data. Combined with protodef using Buffer.allocUnsafe, this leaves uninitialized memory in the serialized buffer, causing non-deterministic round-trip failures for sound_effect packets in versions 1.19.3+. Node 24 exposes this more frequently. Workaround: replace Buffer.allocUnsafe with Buffer.alloc during tests to ensure zeroed buffers, neutralizing the upstream bug. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
/makerelease |
1 similar comment
Member
Author
|
/makerelease |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Claude Code