Add DataOverrides layer to keep corrected values stable across regenerations

[AnonymoDGH]

What

Adds a small override layer (DataOverrides) applied by the shared DataGenerators pipeline right before each generated JSON file is written out. It guarantees that a handful of values the community-verified minecraft-data dataset expects stay correct no matter how often a version is regenerated — this fixes the situation where manual data fixes to generated versions silently revert to the previous state (see the note on PrismarineJS/minecraft-data#1234).

Overrides included

• items.json — warped_fungus_on_a_stick stackSize forced to 1 for 1.16–1.18 (fixes Wrong stack size for Warped Fungus on a Stick minecraft-data#569)
• blocks.json — copper_ore hardness/resistance forced to 3 for 1.18 (fixes Hardness and Resistance 0 for copper_ore in 1.18 minecraft-data#538)
• blocks.json — water/lava marked non-diggable for 1.17+ (fixes Why is water diggable? minecraft-data#926)
• effects.json — for 1.14.4–1.16.1, effect ids 28–32 (SlowFalling…HeroOfTheVillage) are asserted to their canonical values and duplicate entries are dropped (fixes Two dolphins grace effects in mcdata? minecraft-data#529)

Each override is version-gated and only writes the corrected value, so it is a no-op when the game already reports the expected value.

Notes

• The overrides live in common post-processing, so every mc/<version> module picks them up automatically, including future versions.
• CI regenerates data for all 28 versions on this PR, validating the overrides end-to-end.

[extremeheat]

Why is the data returned by the actual Minecraft code wrong ?

[extremeheat]

Injecting a bunch of hard coded (likely wrong) things here when whole point is to get the proper data from the source doesn't seem to make sense

[Copilot]

Pull request overview

Adds a shared post-processing override layer in common so a small set of community-verified corrections stay stable across regenerations for all supported Minecraft versions.

Changes:

• Thread versionName into the shared generation pipeline so overrides can be version-gated.
• Apply DataOverrides to selected generated datasets (items, blocks, effects) immediately before writing JSON.
• Introduce DataOverrides with targeted, version-scoped corrections for known minecraft-data inconsistencies.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
common/src/main/java/dev/u9g/minecraftdatagenerator/MinecraftDataGenerator.java	Passes versionName into the shared generator pipeline so post-processing can be version-aware.
common/src/main/java/dev/u9g/minecraftdatagenerator/generators/DataGenerators.java	Invokes DataOverrides.apply(...) right before each generated JSON file is written.
common/src/main/java/dev/u9g/minecraftdatagenerator/generators/DataOverrides.java	New centralized override layer implementing the version-gated corrections.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[AnonymoDGH]

Closing this in favor of a more targeted approach — @extremeheat's point is well taken.

I compared the generator's actual output on main (CI artifacts, no overrides) against minecraft-data master:

case	generator main	minecraft-data master	verdict
warped_fungus_on_a_stick stackSize	1 (correct)	64	master is stale
copper_ore hardness/resistance	3/3 (correct)	0/0	master is stale
effects ids 28-32	correct, no dupes	BadOmen=32 + duplicate DolphinsGrace	master is stale
water/lava diggable	true (wrong)	true	real generator bug

So 3 of the 4 overrides here were redundant — the generator already returns the right values and the committed minecraft-data files are simply stale (a regeneration would fix them). Hardcoding those was the wrong call.

The one genuine bug is diggable for fluids: the logic hardness != -1.0f && !(block instanceof AirBlock) marks water/lava diggable because their hardness is 100, not -1. That's wrong in all 27 versions that have fluid blocks. I'll open a focused PR that fixes just that by detecting fluid blocks from the code instead of hardcoding names.