add sidebar nav and customize dialog tests

Author: charlesvien

packages/ui/src/features/sidebar/components/CustomizeSidebarDialog.test.tsx

@@ -0,0 +1,55 @@
+import { ANALYTICS_EVENTS } from "@posthog/shared/analytics-events";
+import { Theme } from "@radix-ui/themes";
+import { render, screen } from "@testing-library/react";
+import userEvent from "@testing-library/user-event";
+import { beforeEach, describe, expect, it, vi } from "vitest";
+
+const { track } = vi.hoisted(() => ({ track: vi.fn() }));
+
+vi.mock("@posthog/ui/shell/analytics", () => ({ track }));
+
+import { useSidebarStore } from "@posthog/ui/features/sidebar/sidebarStore";
+import { CustomizeSidebarDialog } from "./CustomizeSidebarDialog";
+
+function renderDialog() {
+  return render(
+    <Theme>
+      <CustomizeSidebarDialog open onOpenChange={vi.fn()} />
+    </Theme>,
+  );
+}
+
+describe("CustomizeSidebarDialog", () => {
+  beforeEach(() => {
+    track.mockReset();
+    useSidebarStore.setState({ navItemOverrides: {} });
+  });
+
+  it("unchecking a visible item demotes it and tracks the change", async () => {
+    const user = userEvent.setup();
+    renderDialog();
+
+    await user.click(screen.getByRole("checkbox", { name: "MCP servers" }));
+
+    expect(useSidebarStore.getState().navItemOverrides["mcp-servers"]).toBe(
+      false,
+    );
+    expect(track).toHaveBeenCalledWith(ANALYTICS_EVENTS.SIDEBAR_CUSTOMIZED, {
+      item: "mcp_servers",
+      visible: false,
+    });
+  });
+
+  it("checking a hidden item promotes it and tracks the change", async () => {
+    const user = userEvent.setup();
+    renderDialog();
+
+    await user.click(screen.getByRole("checkbox", { name: "Search" }));
+
+    expect(useSidebarStore.getState().navItemOverrides.search).toBe(true);
+    expect(track).toHaveBeenCalledWith(ANALYTICS_EVENTS.SIDEBAR_CUSTOMIZED, {
+      item: "search",
+      visible: true,
+    });
+  });
+});

packages/ui/src/features/sidebar/components/SidebarNavSection.test.tsx

@@ -0,0 +1,208 @@
+import { ANALYTICS_EVENTS } from "@posthog/shared/analytics-events";
+import { Theme } from "@radix-ui/themes";
+import { render, screen } from "@testing-library/react";
+import userEvent from "@testing-library/user-event";
+import { beforeEach, describe, expect, it, vi } from "vitest";
+
+if (typeof globalThis.ResizeObserver === "undefined") {
+  globalThis.ResizeObserver = class {
+    observe() {}
+    unobserve() {}
+    disconnect() {}
+  } as unknown as typeof ResizeObserver;
+}
+
+const {
+  track,
+  useAppView,
+  navigateToInbox,
+  navigateToAgents,
+  navigateToSkills,
+  navigateToMcpServers,
+  navigateToCommandCenter,
+  navigateToActivity,
+  openCommandMenu,
+} = vi.hoisted(() => ({
+  track: vi.fn(),
+  useAppView: vi.fn(),
+  navigateToInbox: vi.fn(),
+  navigateToAgents: vi.fn(),
+  navigateToSkills: vi.fn(),
+  navigateToMcpServers: vi.fn(),
+  navigateToCommandCenter: vi.fn(),
+  navigateToActivity: vi.fn(),
+  openCommandMenu: vi.fn(),
+}));
+
+vi.mock("@posthog/ui/shell/analytics", () => ({ track }));
+vi.mock("@posthog/ui/router/useAppView", () => ({ useAppView }));
+vi.mock("@posthog/ui/features/feature-flags/useFeatureFlag", () => ({
+  useFeatureFlag: () => true,
+}));
+vi.mock("@posthog/ui/router/navigationBridge", () => ({
+  navigateToActivity,
+  navigateToAgents,
+  navigateToCommandCenter,
+  navigateToHome: vi.fn(),
+  navigateToInbox,
+  navigateToMcpServers,
+  navigateToSkills,
+  navigateToWebsiteCommandCenter: vi.fn(),
+  navigateToWebsiteHome: vi.fn(),
+  navigateToWebsiteMcpServers: vi.fn(),
+  navigateToWebsiteSkills: vi.fn(),
+}));
+vi.mock("@posthog/ui/router/useOpenTask", () => ({ openTaskInput: vi.fn() }));
+vi.mock("@posthog/ui/shell/commandMenuStore", () => ({
+  useCommandMenuStore: (selector: (s: { open: () => void }) => unknown) =>
+    selector({ open: openCommandMenu }),
+}));
+vi.mock("@posthog/ui/features/command-center/commandCenterStore", () => ({
+  useCommandCenterStore: (
+    selector: (s: { cells: (string | null)[] }) => unknown,
+  ) => selector({ cells: [] }),
+}));
+vi.mock("@posthog/ui/features/inbox/hooks/useInboxAllReports", () => ({
+  useInboxAllReports: () => ({ counts: { pulls: 0 } }),
+}));
+vi.mock("@posthog/ui/features/tasks/useTasks", () => ({
+  useTasks: () => ({ data: [] }),
+}));
+vi.mock("@posthog/ui/features/canvas/hooks/useMentionActivity", () => ({
+  useMentionActivity: () => ({ items: [] }),
+}));
+vi.mock("@posthog/ui/features/canvas/stores/activitySeenStore", () => ({
+  useActivitySeenStore: (
+    selector: (s: { lastSeenAt: number | null }) => unknown,
+  ) => selector({ lastSeenAt: null }),
+}));
+vi.mock("@tanstack/react-router", () => ({
+  useRouterState: () => false,
+}));
+
+import { useSidebarStore } from "@posthog/ui/features/sidebar/sidebarStore";
+import { SidebarNavSection } from "./SidebarNavSection";
+
+function renderNav() {
+  return render(
+    <Theme>
+      <SidebarNavSection />
+    </Theme>,
+  );
+}
+
+describe("SidebarNavSection", () => {
+  beforeEach(() => {
+    vi.clearAllMocks();
+    useAppView.mockReturnValue({ type: "home" });
+    useSidebarStore.setState({ navItemOverrides: {}, channelsEnabled: true });
+  });
+
+  it.each([
+    ["search", "Search"],
+    ["inbox", "Inbox"],
+    ["agents", "Agents"],
+    ["skills", "Skills"],
+    ["mcp-servers", "MCP servers"],
+    ["command-center", "Command Center"],
+    ["contexts", "Contexts"],
+    ["activity", "Activity"],
+  ] as const)(
+    "moves %s from the top level into More when hidden",
+    async (id, label) => {
+      const user = userEvent.setup();
+      useSidebarStore.setState({ navItemOverrides: { [id]: false } });
+      renderNav();
+
+      expect(screen.queryByText(label)).not.toBeInTheDocument();
+
+      await user.click(screen.getByRole("button", { name: "More" }));
+
+      expect(screen.getByText(label)).toBeInTheDocument();
+    },
+  );
+
+  it.each([
+    ["inbox", "inbox", "Inbox"],
+    ["agents", "agents", "Agents"],
+    ["skills", "skills", "Skills"],
+    ["mcp-servers", "mcp-servers", "MCP servers"],
+    ["command-center", "command-center", "Command Center"],
+    ["activity", "activity", "Activity"],
+  ] as const)(
+    "active hidden %s takes over the collapsed More row",
+    (id, viewType, label) => {
+      useAppView.mockReturnValue({ type: viewType });
+      useSidebarStore.setState({ navItemOverrides: { [id]: false } });
+      renderNav();
+
+      expect(
+        screen.queryByRole("button", { name: "More" }),
+      ).not.toBeInTheDocument();
+      expect(screen.getByRole("button", { name: label })).toBeInTheDocument();
+    },
+  );
+
+  it("never lets hidden search take over the More row", () => {
+    useSidebarStore.setState({ navItemOverrides: { search: false } });
+    renderNav();
+
+    expect(screen.getByRole("button", { name: "More" })).toBeInTheDocument();
+  });
+
+  it("tracks top-level clicks with in_more false", async () => {
+    const user = userEvent.setup();
+    renderNav();
+
+    await user.click(screen.getByRole("button", { name: /Inbox/ }));
+
+    expect(navigateToInbox).toHaveBeenCalledTimes(1);
+    expect(track).toHaveBeenCalledWith(
+      ANALYTICS_EVENTS.SIDEBAR_NAV_ITEM_CLICKED,
+      { item: "inbox", in_more: false },
+    );
+  });
+
+  it("tracks clicks inside the expanded More section with in_more true", async () => {
+    const user = userEvent.setup();
+    useSidebarStore.setState({ navItemOverrides: { inbox: false } });
+    renderNav();
+
+    await user.click(screen.getByRole("button", { name: "More" }));
+    await user.click(screen.getByRole("button", { name: /Inbox/ }));
+
+    expect(navigateToInbox).toHaveBeenCalledTimes(1);
+    expect(track).toHaveBeenCalledWith(
+      ANALYTICS_EVENTS.SIDEBAR_NAV_ITEM_CLICKED,
+      { item: "inbox", in_more: true },
+    );
+  });
+
+  it.each([
+    [false, true, "enter_space"],
+    [true, false, "leave_space"],
+  ] as const)(
+    "toggling contexts from %s tracks the toggle and %s",
+    async (initial, expected, spaceAction) => {
+      const user = userEvent.setup();
+      useSidebarStore.setState({ channelsEnabled: initial });
+      renderNav();
+
+      await user.click(screen.getByRole("switch"));
+
+      expect(useSidebarStore.getState().channelsEnabled).toBe(expected);
+      expect(track).toHaveBeenCalledWith(
+        ANALYTICS_EVENTS.SIDEBAR_NAV_ITEM_CLICKED,
+        { item: "contexts", in_more: false },
+      );
+      expect(track).toHaveBeenCalledWith(ANALYTICS_EVENTS.CHANNEL_ACTION, {
+        action_type: "toggle_channels",
+        surface: "nav",
+      });
+      expect(track).toHaveBeenCalledWith(ANALYTICS_EVENTS.CHANNEL_ACTION, {
+        action_type: spaceAction,
+        surface: "nav",
+      });
+    },
+  );
+});

packages/ui/src/features/sidebar/sidebarStore.test.ts

@@ -61,6 +61,18 @@ describe("sidebarStore navItemOverrides", () => {
     },
   );
 
+  it("rehydration falls back to defaults when persisted state predates overrides", async () => {
+    localStorage.setItem(
+      "sidebar-storage",
+      JSON.stringify({ state: { open: true }, version: 0 }),
+    );
+
+    await useSidebarStore.persist.rehydrate();
+
+    expect(useSidebarStore.getState().navItemOverrides).toEqual({});
+    localStorage.removeItem("sidebar-storage");
+  });
+
   it("rehydration drops unknown ids and non-boolean values", async () => {
     localStorage.setItem(
       "sidebar-storage",