refactor(core): own composer model policy

Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22

Author: richardsolomou

apps/mobile/src/app/task/index.tsx

@@ -3,6 +3,7 @@ import {
   DEFAULT_CLAUDE_EXECUTION_MODE,
   getAvailableModes,
 } from "@posthog/core/sessions/executionModes";
+import { resolveCloudComposerModelChange } from "@posthog/core/task-detail/composerModelPolicy";
 import {
   DEFAULT_GATEWAY_MODEL,
   DEFAULT_REASONING_EFFORT,
@@ -60,7 +61,6 @@ import {
   getComposerModelOptions,
   getConfigOptionLabel,
   getModelConfigOption,
-  resolveComposerModelChange,
 } from "@/features/tasks/composer/options";
 import { Pill } from "@/features/tasks/composer/Pill";
 import { RepositoryPickerInline } from "@/features/tasks/composer/RepositoryPickerInline";
@@ -216,7 +216,7 @@ export default function NewTaskScreen() {
 
   useEffect(() => {
     if (!hasLiveConfig) return;
-    const next = resolveComposerModelChange({
+    const next = resolveCloudComposerModelChange({
       adapter: "claude",
       modelOption: modelConfigOption,
       requestedModel: model,
@@ -778,7 +778,7 @@ export default function NewTaskScreen() {
         title="Model"
         value={model}
         onChange={(value) => {
-          const next = resolveComposerModelChange({
+          const next = resolveCloudComposerModelChange({
             adapter: "claude",
             modelOption: modelConfigOption,
             requestedModel: value,

apps/mobile/src/features/tasks/composer/TaskChatComposer.tsx

@@ -3,6 +3,7 @@ import {
   DEFAULT_CLAUDE_EXECUTION_MODE,
   getAvailableModes,
 } from "@posthog/core/sessions/executionModes";
+import { resolveCloudComposerModelChange } from "@posthog/core/task-detail/composerModelPolicy";
 import {
   DEFAULT_GATEWAY_MODEL,
   DEFAULT_REASONING_EFFORT,
@@ -60,7 +61,6 @@ import {
   getComposerModelOptions,
   getConfigOptionLabel,
   getModelConfigOption,
-  resolveComposerModelChange,
   resolveComposerPrimaryAction,
 } from "./options";
 import { Pill } from "./Pill";
@@ -207,7 +207,7 @@ export function TaskChatComposer({
 
   useEffect(() => {
     if (!hasLiveConfig) return;
-    const next = resolveComposerModelChange({
+    const next = resolveCloudComposerModelChange({
       adapter: "claude",
       modelOption: modelConfigOption,
       requestedModel: model,
@@ -499,7 +499,7 @@ export function TaskChatComposer({
         title="Model"
         value={model}
         onChange={(v) => {
-          const next = resolveComposerModelChange({
+          const next = resolveCloudComposerModelChange({
             adapter: "claude",
             modelOption: modelConfigOption,
             requestedModel: v,

apps/mobile/src/features/tasks/composer/options.ts

@@ -1,11 +1,7 @@
 import type { ModeInfo } from "@posthog/core/sessions/executionModes";
 import {
-  type Adapter,
   type CloudTaskConfigOption,
-  DEFAULT_REASONING_EFFORT,
   isRestrictedModelOption,
-  isSupportedReasoningEffort,
-  type SupportedReasoningEffort,
 } from "@posthog/shared";
 
 export interface MobileModelOption {
@@ -49,32 +45,6 @@ export function getConfigOptionLabel(
   return options.find((option) => option.value === value)?.name ?? value;
 }
 
-export function resolveComposerModelChange({
-  adapter,
-  modelOption,
-  requestedModel,
-  reasoning,
-}: {
-  adapter: Adapter;
-  modelOption: CloudTaskConfigOption;
-  requestedModel: string;
-  reasoning: SupportedReasoningEffort;
-}): { model: string; reasoning: SupportedReasoningEffort } {
-  const selected = modelOption.options.find(
-    (option) => option.value === requestedModel,
-  );
-  const model =
-    selected && !isRestrictedModelOption(selected._meta)
-      ? requestedModel
-      : modelOption.currentValue;
-  return {
-    model,
-    reasoning: isSupportedReasoningEffort(adapter, model, reasoning)
-      ? reasoning
-      : DEFAULT_REASONING_EFFORT,
-  };
-}
-
 export type ComposerPrimaryAction =
   | "send"
   | "stop"

packages/core/src/task-detail/composerModelPolicy.test.ts

@@ -0,0 +1,42 @@
+import {
+  type Adapter,
+  type CloudTaskConfigOption,
+  DEFAULT_GATEWAY_MODEL,
+  restrictedModelMeta,
+  type SupportedReasoningEffort,
+} from "@posthog/shared";
+import { expect, it } from "vitest";
+import { resolveCloudComposerModelChange } from "./composerModelPolicy";
+
+const modelOption: CloudTaskConfigOption = {
+  id: "model",
+  name: "Model",
+  type: "select",
+  currentValue: DEFAULT_GATEWAY_MODEL,
+  options: [
+    { value: DEFAULT_GATEWAY_MODEL, name: "Claude" },
+    { value: "restricted", name: "Restricted", _meta: restrictedModelMeta() },
+    { value: "gpt-5.3-codex", name: "Codex" },
+  ],
+  category: "model",
+  description: "Choose a model",
+};
+
+it.each([
+  ["claude", DEFAULT_GATEWAY_MODEL, "high", DEFAULT_GATEWAY_MODEL, "high"],
+  ["claude", "restricted", "high", DEFAULT_GATEWAY_MODEL, "high"],
+  ["claude", "missing", "high", DEFAULT_GATEWAY_MODEL, "high"],
+  ["codex", "gpt-5.3-codex", "xhigh", "gpt-5.3-codex", "high"],
+] as const)(
+  "resolves %s model %s with %s reasoning",
+  (adapter, requestedModel, reasoning, expectedModel, expectedReasoning) => {
+    expect(
+      resolveCloudComposerModelChange({
+        adapter: adapter as Adapter,
+        modelOption,
+        requestedModel,
+        reasoning: reasoning as SupportedReasoningEffort,
+      }),
+    ).toEqual({ model: expectedModel, reasoning: expectedReasoning });
+  },
+);

packages/core/src/task-detail/composerModelPolicy.ts

@@ -0,0 +1,35 @@
+import {
+  type Adapter,
+  type CloudTaskConfigOption,
+  DEFAULT_REASONING_EFFORT,
+  isRestrictedModelOption,
+  isSupportedReasoningEffort,
+  type SupportedReasoningEffort,
+} from "@posthog/shared";
+
+export function resolveCloudComposerModelChange({
+  adapter,
+  modelOption,
+  requestedModel,
+  reasoning,
+}: {
+  adapter: Adapter;
+  modelOption: CloudTaskConfigOption;
+  requestedModel: string;
+  reasoning: SupportedReasoningEffort;
+}): { model: string; reasoning: SupportedReasoningEffort } {
+  const selected = modelOption.options.find(
+    (option) => option.value === requestedModel,
+  );
+  const model =
+    selected && !isRestrictedModelOption(selected._meta)
+      ? requestedModel
+      : modelOption.currentValue;
+
+  return {
+    model,
+    reasoning: isSupportedReasoningEffort(adapter, model, reasoning)
+      ? reasoning
+      : DEFAULT_REASONING_EFFORT,
+  };
+}