Merge branch 'main' into posthog-code/skip-clean-jsonl-sanitize

Picks up the vr-cli install fix from #4029 so the visual-regression check passes.

Generated-By: PostHog Code
Task-Id: 58678630-1e4b-4565-9de0-c74c91b9d995

Author: arnohillen

.claude/skills/merging-prs/SKILL.md

@@ -12,7 +12,7 @@ To merge, you enqueue the PR with a comment, then watch it until Trunk lands it.
 
 When a developer says "merge this PR", "merge it when it's ready", "land it",
 "ship it", or "babysit this PR", do the full loop below — enqueue **and** watch
-to completion, reporting the outcome. See also [docs/merge-queue.md](../../../docs/merge-queue.md).
+to completion, reporting the outcome.
 
 `<n>` below is the PR number. Resolve the repo slug once if you need it:
 `REPO=$(gh repo view --json nameWithOwner -q .nameWithOwner)`.
@@ -29,8 +29,21 @@ gh pr view <n> --json state,isDraft,mergeable,reviewDecision,statusCheckRollup
 - **Failing required checks** (`statusCheckRollup`) → the queue will just reject
   it. Report which checks are red and stop; fix them first. **Pending** checks
   are fine — the queue waits for them.
+- **Not yet approved** (`reviewDecision` empty or `REVIEW_REQUIRED`) → fine,
+  enqueue anyway. See below.
 - **Merge conflicts** (`mergeable == "CONFLICTING"`) → report and stop; rebase first.
 
+Enqueueing before approval is safe, and is the closest thing this repo has to
+auto-merge. A submitted PR sits in Trunk's `Queued` state until GitHub's branch
+protection on `main` is satisfied — one approving review, code-owner review, and
+the required checks (`build`, `quality`, `unit-test`, `integration-test`,
+`typecheck`) — and Trunk merges it once they land. Trunk is not a bypass actor on
+those rules, so it cannot merge an unapproved or red PR.
+
+The catch: **pushing new commits drops the PR from the queue.** If review
+feedback is likely, either wait for approval before enqueueing, or re-enqueue
+with `/trunk merge` after each push.
+
 ## 2. Enqueue
 
 ```bash
@@ -68,7 +81,10 @@ sleep 60
 - Watch the **check run + PR state**, not `gh pr checks --watch`: the queue runs
   CI on Trunk's own draft/`trunk-merge/**` branch, so this PR's own checks don't
   reflect the queue's testing.
-- Stop at the timeout with a status summary rather than looping forever.
+- If it's parked in `Queued` waiting on a human review, say so once and slow the
+  cadence to ~5 minutes. Keep watching — the merge still has to be reported.
+- Stop at the timeout with a status summary rather than looping forever. If it
+  was still waiting on review, say that's why and offer to keep watching.
 
 ## 4. Handle failure
 

.github/workflows/code-storybook.yml

@@ -169,7 +169,7 @@ jobs:
 
       - name: Install Visual Review CLI
         if: github.event.pull_request.head.repo.full_name == github.repository || github.event_name == 'push'
-        run: cd vr-cli/products/visual_review/cli && npm ci && npm run build && npm link
+        run: cd vr-cli/products/visual_review/cli && (npm ci || npm install) && npm run build && npm link
 
       - name: Submit snapshots to Visual Review
         # Fork PRs can't read the token; their captures still ran above, so a

README.md

@@ -1,9 +1,5 @@
 > [!IMPORTANT]
-> Interested in the PostHog desktop app? [Join the waitlist](https://posthog.com/code) or hop into our [Discord](https://discord.gg/aSrHKVNVdR).
-
-**[Download the latest version](https://github.com/PostHog/code/releases/latest)**
-
-Found a bug or have feedback? [Open an issue](https://github.com/PostHog/code/issues/new) on GitHub.
+> This repository has migrated to the [PostHog monorepo](https://github.com/PostHog/posthog/tree/master/products/desktop). Development, issues and pull requests now live there.
 
 # PostHog
 

apps/code/snapshots.yml

@@ -537,21 +537,17 @@ snapshots:
     git-dialogs--sync-success--light:
         hash: v1.k4693efd2.8d79d77c9338aeaa73734836f0e17fde987f6d3239914f4013889d3110e5088d.Rq-w2o1uhes_a5hUWqMXeiDkfnoPCZPt932LkEQXCco
     loops-loopslistview--comprehensive--dark:
-        hash: v1.k4693efd2.c128012b7f910839e65e8eaf14d5456c93f90d77747d0625ca35fddd8d5adf7a.fuugB5Ov6boP7fg6fWP7A7IG2yYnPUAAWLKZLuV8rZ0
+        hash: v1.k4693efd2.25744a9471ec664c70e346ac5cb330c025a031626bc486abe8820b7b6dbc1a19.Shh8Yl7SdombnNc4-uJjlIbx-n4C0MGXxtOGB1bjJTY
     loops-loopslistview--comprehensive--light:
-        hash: v1.k4693efd2.4d25a48e0bd7e60d3bbb433e246486e4c9ac95979db86e20eb8bf5cb119d1eb2.EzrENjVHwVMyV00pEA-71TeVomJtchiym5DqWFkujlA
+        hash: v1.k4693efd2.ef8e012cc506a0bf5e761ec8e89943820d4b391f7023f506da7d79586b49a356.ATiN8Y0hUmfGvr0rUytYWX-fITyHRTgeN1i_HOOGZuc
     loops-loopslistview--long-mixed-list--dark:
-        hash: v1.k4693efd2.fdbf0c24cb386c4345279db3e648efe72aa8a2a984d491361522f62074a771c9.2QmRxRMWYFFfBFrbMm0Dm9rWcvd1lfRbc0egfzoESnY
+        hash: v1.k4693efd2.c9915e22655fe1f6b77eabaf11d8876648c387ceebac6cd8be1880e7255bd7a5.y-gyTKSp7wYbuS57TABRbEyMSL9_U1wvHYvbyCeAbiQ
     loops-loopslistview--long-mixed-list--light:
-        hash: v1.k4693efd2.aa17d9b6f40fbd3914bd742951db9f90add0bd233c54170803c8483aeb45b43b.yXpqqGczOq1uW5k4Ie7ddNTnne-cFTglZ9cL800pXB4
-    loops-loopslistview--shared-page-header--dark:
-        hash: v1.k4693efd2.14ab860dcb0df51b4019f012288e45f3a2c4c23fa08e809efef8c04b5687fe36.qoMLHprZmV2wON156NBbl3sqP84a4nXgdYm1H6WpTVM
-    loops-loopslistview--shared-page-header--light:
-        hash: v1.k4693efd2.23be5408ff3b4a912a0ce0457af8638124b99a01c88a499d0f4204cee2c62487.dGBP1K08MA2Fvhml-BPl5eFra8U83JXmy04NK9wOQnM
+        hash: v1.k4693efd2.5fec9e1a3c14f1bc319cd7e5abc24b3d66ed787986a103b5330f49341d4983ad.mpD-eTS6vkSbsJdOYaHXASHQd5IiJGWRCb6uDGlzhpk
     loops-loopslistview--with-builder-sessions--dark:
-        hash: v1.k4693efd2.df4a1a4764e1de7b69905814b09c30d9b43f705f5e66c7ad83829c567d4faa1a.jthufoX_KPbbxScjj3pPBA4lEtT9Ym6zUCH-v1759GM
+        hash: v1.k4693efd2.06b404e4016ba0eb86769331a574bc640be1ad26ebf3a04d0256334d1da041a3.fPfF8c2wNFREfy8dVRdsw7W9Fpqj7HEtuaERMroNHMA
     loops-loopslistview--with-builder-sessions--light:
-        hash: v1.k4693efd2.eb65c38bb0de7efedbc0d7a6c27a6695528e2e6b60949617e7d22335b1e68c8b.fJr9uykvc8S7LI_ASXk5KRqxXCwIqh6ld9zfzs4shP0
+        hash: v1.k4693efd2.30f89915a12cadf313216403fb0f3e221f3c33cee763f0692ae2b96b4332e2b9.j00vexnH4QS0wJAHn7pQNpeITYYRtOxlvB2ngyzqU0c
     primitives-pageheader--title-only--dark:
         hash: v1.k4693efd2.f7f8c560b1e5cf20050189e10fc0f129e555ba672300a7a09bef5827c171a743.yP9Pp_k51agu_9Ri55Y7uCAPBQ1UTeUQJA9U9dPMKfQ
     primitives-pageheader--title-only--light:
@@ -696,10 +692,6 @@ snapshots:
         hash: v1.k4693efd2.e747a3b5d0983a7a125335f1d95cc7735dafda73abdb3f63ccfadde0482c5ce9.tjc4lMKeaOJjLLxd9tivmgKLshzHZwuSAa_MbqwN_20
     skill-buttons-skillbuttonactionmessage--run-experiment--light:
         hash: v1.k4693efd2.c18264887c67224ea1196646ff27f31ef9d79add87b5e9dfead377fcaf0dc941.MwzR7Yyd4le31Qm7RB2yk-qLk5ujgLkN-cMAB2WQ9_k
-    skill-buttons-skillbuttonsmenu--default--dark:
-        hash: v1.k4693efd2.cfff4c6bbb0acef1c9941b21d2f69c24b234c2c206282acf6fcada0cb2bd2386.xILjVPp8ecQmGbPjGDdhbRyi9KFPpA_1nfYF3bfjwuc
-    skill-buttons-skillbuttonsmenu--default--light:
-        hash: v1.k4693efd2.eb9bd49b9700641f6f3c90653447c9767c52e997afec9843e8649b90752faad3.VdxEtBwtkU3ioy2evcNbrEKxPjQ1GDUpZAQzFe-Uho4
     spaces-taskfeedrow--agent-origin--dark:
         hash: v1.k4693efd2.82f8c70a399c9ea768201933e202fcc2fde74332c5153aeabf6835ace79beee6.yEZq_qnKxItv5u0Ydcqa1B4VCwv8lwXUvcaFScE2XO0
     spaces-taskfeedrow--agent-origin--light:

apps/code/src/main/window.ts

@@ -208,11 +208,14 @@ export function createWindow(): void {
   const platformWindowConfig =
     process.platform === "darwin"
       ? {
-          titleBarStyle: "hiddenInset" as const,
+          // "hidden", not "hiddenInset": hiddenInset keeps macOS's own inset and
+          // ignores trafficLightPosition's y, which parked the dots near the
+          // bottom of the bar. "hidden" honours the position we ask for.
+          titleBarStyle: "hidden" as const,
           // Centre the traffic lights vertically with the title bar's back/forward
           // buttons (40px bar, 24px buttons → centre at y=20; 12px dots → top at 14).
           // x mirrors y so the inset from the top and the left match.
-          trafficLightPosition: { x: 14, y: 14 },
+          trafficLightPosition: { x: 14, y: 12 },
           // Exposes the titlebar-area-* CSS env vars so the renderer can
           // clear the traffic lights exactly; their size varies by macOS
           // version (bigger on Tahoe), so it must not hardcode a width.

apps/mobile/package.json

@@ -24,6 +24,11 @@
     "clean": "node ../../scripts/rimraf.mjs .turbo .expo"
   },
   "expo": {
+    "autolinking": {
+      "buildFromSource": [
+        "react-native-worklets"
+      ]
+    },
     "doctor": {
       "reactNativeDirectoryCheck": {
         "exclude": [

apps/mobile/src/app/inbox/[...id].tsx

@@ -46,6 +46,7 @@ import {
   DismissReportSheet,
 } from "@/features/inbox/components/DismissReportSheet";
 import { ReportActivity } from "@/features/inbox/components/ReportActivity";
+import { ReportFeedbackFooter } from "@/features/inbox/components/ReportFeedbackFooter";
 import { SignalCard } from "@/features/inbox/components/SignalCard";
 import {
   type ReviewerActionExtra,
@@ -463,7 +464,7 @@ export default function ReportDetailScreen() {
 
         {/* Title */}
         <Text className="mb-2 font-semibold text-[18px] text-gray-12">
-          {report.title ?? "Untitled signal"}
+          {report.title ?? "Untitled report"}
         </Text>
 
         {/* Meta row */}
@@ -573,6 +574,9 @@ export default function ReportDetailScreen() {
 
         {/* Activity log */}
         <ReportActivity reportId={report.id} artefacts={artefacts} />
+
+        {/* Usefulness feedback */}
+        <ReportFeedbackFooter report={report} />
       </ScrollView>
 
       <View
@@ -638,7 +642,7 @@ export default function ReportDetailScreen() {
       <DismissReportSheet
         visible={dismissOpen}
         reportId={report.id}
-        reportTitle={report.title?.trim() ? report.title : "Untitled signal"}
+        reportTitle={report.title?.trim() ? report.title : "Untitled report"}
         onClose={() => setDismissOpen(false)}
         onDismissed={handleDismissed}
       />

apps/mobile/src/app/settings/index.tsx

@@ -1,4 +1,8 @@
 import { Text } from "@components/text";
+import {
+  EFFORT_LEVEL_LABELS,
+  EFFORT_LEVELS,
+} from "@posthog/shared/domain-types";
 import { router } from "expo-router";
 import { ArrowSquareOut, CaretRight, SpeakerHigh } from "phosphor-react-native";
 import { useState } from "react";
@@ -103,11 +107,10 @@ const REASONING_EFFORT_OPTIONS: ReadonlyArray<{
     label: "Last used",
     description: "Remember the effort level you picked last time",
   },
-  { value: "low", label: "Low" },
-  { value: "medium", label: "Medium" },
-  { value: "high", label: "High" },
-  { value: "xhigh", label: "Extra High" },
-  { value: "max", label: "Max" },
+  ...EFFORT_LEVELS.map((value) => ({
+    value,
+    label: EFFORT_LEVEL_LABELS[value],
+  })),
 ];
 
 function themeLabel(theme: ThemePreference): string {
@@ -415,7 +418,7 @@ export default function SettingsScreen() {
           />
           <SettingsRow
             label="Messaging mode"
-            description="What happens when you send while a turn is running"
+            description="Mode new sessions start in. Steer applies messages mid-turn. Queue holds them until the turn ends."
             onPress={() => setMessagingModeSheetOpen(true)}
             rightSlot={
               <>

apps/mobile/src/app/task/[id].tsx

@@ -16,6 +16,7 @@ import {
   isModalModelId,
   isSupportedReasoningEffort,
   KIMI_MODEL_FLAG,
+  readPrUrls,
   type SupportedReasoningEffort,
   serializeCloudPrompt,
   type Task,
@@ -44,6 +45,10 @@ import { StopRunButton } from "@/features/tasks/components/StopRunButton";
 import { TaskSessionView } from "@/features/tasks/components/TaskSessionView";
 import { buildCloudPromptBlocks } from "@/features/tasks/composer/attachments/buildCloudPrompt";
 import type { PendingAttachment } from "@/features/tasks/composer/attachments/types";
+import {
+  type ContextWindow,
+  DEFAULT_CONTEXT_WINDOW,
+} from "@/features/tasks/composer/options";
 import { QueuedMessagesDock } from "@/features/tasks/composer/QueuedMessagesDock";
 import { TaskChatComposer } from "@/features/tasks/composer/TaskChatComposer";
 import {
@@ -214,6 +219,13 @@ export default function TaskDetailScreen() {
     )
       ? requestedComposerReasoning
       : DEFAULT_REASONING_EFFORT;
+  const composerContextWindow: ContextWindow =
+    (composerConfigMatchesAdapter
+      ? composerConfig?.contextWindow
+      : undefined) ?? DEFAULT_CONTEXT_WINDOW;
+  const composerFastMode: boolean =
+    (composerConfigMatchesAdapter ? composerConfig?.fastMode : undefined) ??
+    false;
 
   const messagingMode = useMessagingMode(taskId);
   const queuedCount = useQueuedCount(taskId);
@@ -367,6 +379,8 @@ export default function TaskDetailScreen() {
               mode: composerMode,
               model: composerModel,
               reasoning: composerReasoning,
+              contextWindow: composerContextWindow,
+              fastMode: composerFastMode,
             }),
             rtkEnabled: usePreferencesStore.getState().rtkEnabledCloud,
           },
@@ -396,6 +410,8 @@ export default function TaskDetailScreen() {
       composerAdapter,
       composerModel,
       composerReasoning,
+      composerContextWindow,
+      composerFastMode,
     ],
   );
 
@@ -553,10 +569,14 @@ export default function TaskDetailScreen() {
   const handleAdapterChange = useCallback(
     (selection: CloudComposerSelection) => {
       if (!taskId) return;
-      setComposerConfig(taskId, selection);
-      const preferences = usePreferencesStore.getState();
-      preferences.setLastNewTaskMode(selection.mode);
-      preferences.setLastUsedReasoningEffort(selection.reasoning);
+      setComposerConfig(taskId, {
+        ...selection,
+        contextWindow: DEFAULT_CONTEXT_WINDOW,
+        fastMode: false,
+      });
+      usePreferencesStore
+        .getState()
+        .resetLastUsedAgentConfig(selection.mode, selection.reasoning);
     },
     [taskId, setComposerConfig],
   );
@@ -584,6 +604,24 @@ export default function TaskDetailScreen() {
     [taskId, composerAdapter, setComposerConfig, setConfigOption],
   );
 
+  const handleContextWindowChange = useCallback(
+    (value: ContextWindow) => {
+      if (!taskId) return;
+      setComposerConfig(taskId, { contextWindow: value });
+      usePreferencesStore.getState().setLastUsedContextWindow(value);
+    },
+    [taskId, setComposerConfig],
+  );
+
+  const handleFastModeChange = useCallback(
+    (value: boolean) => {
+      if (!taskId) return;
+      setComposerConfig(taskId, { fastMode: value });
+      usePreferencesStore.getState().setLastUsedFastMode(value);
+    },
+    [taskId, setComposerConfig],
+  );
+
   const handleStop = useCallback(() => {
     if (!taskId) return;
     // cancelPrompt returns false on failure — no need to alert,
@@ -638,6 +676,8 @@ export default function TaskDetailScreen() {
             mode: composerMode,
             model: composerModel,
             reasoning: composerReasoning,
+            contextWindow: composerContextWindow,
+            fastMode: composerFastMode,
           }),
           rtkEnabled: usePreferencesStore.getState().rtkEnabledCloud,
         },
@@ -665,6 +705,8 @@ export default function TaskDetailScreen() {
     composerModel,
     composerReasoning,
     composerMode,
+    composerContextWindow,
+    composerFastMode,
   ]);
 
   // Clear retrying once the agent finishes a turn or the run terminates.
@@ -696,7 +738,7 @@ export default function TaskDetailScreen() {
     [router],
   );
 
-  const prUrl = task?.latest_run?.output?.pr_url as string | undefined;
+  const prUrl = readPrUrls(task?.latest_run?.output)[0];
 
   const activityPhase = getSessionActivityPhase({ retrying, session });
   const isConnecting = activityPhase === "connecting";
@@ -795,6 +837,7 @@ export default function TaskDetailScreen() {
         <TaskSessionView
           events={session?.events ?? []}
           taskId={taskId}
+          runId={task?.latest_run?.id}
           pendingPermissions={session?.pendingPermissions}
           isConnecting={isConnecting}
           isThinking={isThinking}
@@ -875,10 +918,14 @@ export default function TaskDetailScreen() {
             mode={composerMode}
             model={composerModel}
             reasoning={composerReasoning}
+            contextWindow={composerContextWindow}
+            fastMode={composerFastMode}
             onAdapterChange={handleAdapterChange}
             onModeChange={handleModeChange}
             onModelChange={handleModelChange}
             onReasoningChange={handleReasoningChange}
+            onContextWindowChange={handleContextWindowChange}
+            onFastModeChange={handleFastModeChange}
             messagingMode={messagingMode}
             queuedCount={queuedCount}
             onToggleMessagingMode={toggleMessagingMode}